Migrate base::Contains() to std::ranges::contains() in content [chromium/src : main]

2 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Jan 13, 2026, 11:01:47 AMJan 13
to Avi Drissman, James Su, Hiroki Nakagawa, Kaan Icer, Rijubrata Bhaumik, Peter Beverloo, (Julie)Jeongeun Kim, Christian Biesinger, AyeAye, Chromium LUCI CQ, servicewor...@chromium.org, yongshun+...@google.com, kyungjunle...@google.com, nektar...@chromium.org, creis...@chromium.org, toyosh...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, gavin...@chromium.org, yuzo+...@chromium.org, arthursonzog...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, alexmo...@chromium.org, spang...@chromium.org, chfreme...@chromium.org, francisjp...@google.com, msrame...@chromium.org, cambickel...@google.com, mkwst+w...@chromium.org, edgesto...@microsoft.com, yhanad...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, npm+...@chromium.org, mfoltz+wa...@chromium.org, enne...@chromium.org, ajwong...@chromium.org, tbansal+...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, michaelchec...@google.com, antoniosarto...@chromium.org, blink-work...@chromium.org, dullweb...@chromium.org, cfredri...@chromium.org, kinuko...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, jbauma...@chromium.org, shimazu+se...@chromium.org, tracing...@chromium.org, dmurph+wa...@chromium.org, apaselti...@chromium.org, alexmt...@chromium.org, bfcach...@chromium.org, devtools...@chromium.org, wfh+...@chromium.org, feature-v...@chromium.org, navigation...@chromium.org, prerenderi...@chromium.org, storage...@chromium.org, keithle...@chromium.org, tburkar...@chromium.org
Attention needed from Avi Drissman

Victor Vianna voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7217e2324f417ff4e4cc7d045ca6fbe92047f3c
Gerrit-Change-Number: 7459701
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 16:01:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
Jan 13, 2026, 1:28:06 PMJan 13
to Victor Vianna, Avi Drissman, James Su, Hiroki Nakagawa, Kaan Icer, Rijubrata Bhaumik, Peter Beverloo, (Julie)Jeongeun Kim, Christian Biesinger, AyeAye, Chromium LUCI CQ, servicewor...@chromium.org, yongshun+...@google.com, kyungjunle...@google.com, nektar...@chromium.org, creis...@chromium.org, toyosh...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, gavin...@chromium.org, yuzo+...@chromium.org, arthursonzog...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, alexmo...@chromium.org, spang...@chromium.org, chfreme...@chromium.org, francisjp...@google.com, msrame...@chromium.org, cambickel...@google.com, mkwst+w...@chromium.org, edgesto...@microsoft.com, yhanad...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, npm+...@chromium.org, mfoltz+wa...@chromium.org, enne...@chromium.org, ajwong...@chromium.org, tbansal+...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, michaelchec...@google.com, antoniosarto...@chromium.org, blink-work...@chromium.org, dullweb...@chromium.org, cfredri...@chromium.org, kinuko...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, jbauma...@chromium.org, shimazu+se...@chromium.org, tracing...@chromium.org, dmurph+wa...@chromium.org, apaselti...@chromium.org, alexmt...@chromium.org, bfcach...@chromium.org, devtools...@chromium.org, wfh+...@chromium.org, feature-v...@chromium.org, navigation...@chromium.org, prerenderi...@chromium.org, storage...@chromium.org, keithle...@chromium.org, tburkar...@chromium.org
Attention needed from Victor Vianna

Avi Drissman voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib7217e2324f417ff4e4cc7d045ca6fbe92047f3c
    Gerrit-Change-Number: 7459701
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 18:27:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Jan 13, 2026, 1:28:46 PMJan 13
    to Avi Drissman, James Su, Hiroki Nakagawa, Kaan Icer, Rijubrata Bhaumik, Peter Beverloo, (Julie)Jeongeun Kim, Christian Biesinger, AyeAye, Chromium LUCI CQ, servicewor...@chromium.org, yongshun+...@google.com, kyungjunle...@google.com, nektar...@chromium.org, creis...@chromium.org, toyosh...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, gavin...@chromium.org, yuzo+...@chromium.org, arthursonzog...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, alexmo...@chromium.org, spang...@chromium.org, chfreme...@chromium.org, francisjp...@google.com, msrame...@chromium.org, cambickel...@google.com, mkwst+w...@chromium.org, edgesto...@microsoft.com, yhanad...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, npm+...@chromium.org, mfoltz+wa...@chromium.org, enne...@chromium.org, ajwong...@chromium.org, tbansal+...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, michaelchec...@google.com, antoniosarto...@chromium.org, blink-work...@chromium.org, dullweb...@chromium.org, cfredri...@chromium.org, kinuko...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, jbauma...@chromium.org, shimazu+se...@chromium.org, tracing...@chromium.org, dmurph+wa...@chromium.org, apaselti...@chromium.org, alexmt...@chromium.org, bfcach...@chromium.org, devtools...@chromium.org, wfh+...@chromium.org, feature-v...@chromium.org, navigation...@chromium.org, prerenderi...@chromium.org, storage...@chromium.org, keithle...@chromium.org, tburkar...@chromium.org
    Attention needed from Avi Drissman

    Victor Vianna added 1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Victor Vianna . resolved

    I'll add the remaining owners

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 18:28:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Jan 13, 2026, 1:29:38 PMJan 13
    to Avi Drissman, James Su, Hiroki Nakagawa, Kaan Icer, Rijubrata Bhaumik, Peter Beverloo, (Julie)Jeongeun Kim, Christian Biesinger, AyeAye, Chromium LUCI CQ, servicewor...@chromium.org, yongshun+...@google.com, kyungjunle...@google.com, nektar...@chromium.org, creis...@chromium.org, toyosh...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, gavin...@chromium.org, yuzo+...@chromium.org, arthursonzog...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, alexmo...@chromium.org, spang...@chromium.org, chfreme...@chromium.org, francisjp...@google.com, msrame...@chromium.org, cambickel...@google.com, mkwst+w...@chromium.org, edgesto...@microsoft.com, yhanad...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, npm+...@chromium.org, mfoltz+wa...@chromium.org, enne...@chromium.org, ajwong...@chromium.org, tbansal+...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, michaelchec...@google.com, antoniosarto...@chromium.org, blink-work...@chromium.org, dullweb...@chromium.org, cfredri...@chromium.org, kinuko...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, jbauma...@chromium.org, shimazu+se...@chromium.org, tracing...@chromium.org, dmurph+wa...@chromium.org, apaselti...@chromium.org, alexmt...@chromium.org, bfcach...@chromium.org, devtools...@chromium.org, wfh+...@chromium.org, feature-v...@chromium.org, navigation...@chromium.org, prerenderi...@chromium.org, storage...@chromium.org, keithle...@chromium.org, tburkar...@chromium.org

    Victor Vianna added 1 comment

    Patchset-level comments
    Victor Vianna . resolved

    +alexmos@ for content/browser/child_process_security_policy_impl.cc

    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Tue, 13 Jan 2026 18:29:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Jan 13, 2026, 1:30:11 PMJan 13
    to Alex Moshchuk, Avi Drissman, James Su, Hiroki Nakagawa, Kaan Icer, Rijubrata Bhaumik, Peter Beverloo, (Julie)Jeongeun Kim, Christian Biesinger, AyeAye, Chromium LUCI CQ, servicewor...@chromium.org, yongshun+...@google.com, kyungjunle...@google.com, nektar...@chromium.org, creis...@chromium.org, toyosh...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, gavin...@chromium.org, yuzo+...@chromium.org, arthursonzog...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, alexmo...@chromium.org, spang...@chromium.org, chfreme...@chromium.org, francisjp...@google.com, msrame...@chromium.org, cambickel...@google.com, mkwst+w...@chromium.org, edgesto...@microsoft.com, yhanad...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, npm+...@chromium.org, mfoltz+wa...@chromium.org, enne...@chromium.org, ajwong...@chromium.org, tbansal+...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, michaelchec...@google.com, antoniosarto...@chromium.org, blink-work...@chromium.org, dullweb...@chromium.org, cfredri...@chromium.org, kinuko...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, jbauma...@chromium.org, shimazu+se...@chromium.org, tracing...@chromium.org, dmurph+wa...@chromium.org, apaselti...@chromium.org, alexmt...@chromium.org, bfcach...@chromium.org, devtools...@chromium.org, wfh+...@chromium.org, feature-v...@chromium.org, navigation...@chromium.org, prerenderi...@chromium.org, storage...@chromium.org, keithle...@chromium.org, tburkar...@chromium.org
    Attention needed from Alex Moshchuk

    Victor Vianna added 1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Victor Vianna . resolved

    +alexmos@ for content/browser/child_process_security_policy_impl.cc

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Moshchuk
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib7217e2324f417ff4e4cc7d045ca6fbe92047f3c
    Gerrit-Change-Number: 7459701
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 18:29:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Moshchuk (Gerrit)

    unread,
    Jan 13, 2026, 6:28:52 PMJan 13
    to Victor Vianna, Avi Drissman, James Su, Hiroki Nakagawa, Kaan Icer, Rijubrata Bhaumik, Peter Beverloo, (Julie)Jeongeun Kim, Christian Biesinger, AyeAye, Chromium LUCI CQ, servicewor...@chromium.org, yongshun+...@google.com, kyungjunle...@google.com, nektar...@chromium.org, creis...@chromium.org, toyosh...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, gavin...@chromium.org, yuzo+...@chromium.org, arthursonzog...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, alexmo...@chromium.org, spang...@chromium.org, chfreme...@chromium.org, francisjp...@google.com, msrame...@chromium.org, cambickel...@google.com, mkwst+w...@chromium.org, edgesto...@microsoft.com, yhanad...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, npm+...@chromium.org, mfoltz+wa...@chromium.org, enne...@chromium.org, ajwong...@chromium.org, tbansal+...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, michaelchec...@google.com, antoniosarto...@chromium.org, blink-work...@chromium.org, dullweb...@chromium.org, cfredri...@chromium.org, kinuko...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, jbauma...@chromium.org, shimazu+se...@chromium.org, tracing...@chromium.org, dmurph+wa...@chromium.org, apaselti...@chromium.org, alexmt...@chromium.org, bfcach...@chromium.org, devtools...@chromium.org, wfh+...@chromium.org, feature-v...@chromium.org, navigation...@chromium.org, prerenderi...@chromium.org, storage...@chromium.org, keithle...@chromium.org, tburkar...@chromium.org
    Attention needed from Victor Vianna

    Alex Moshchuk voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Victor Vianna
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib7217e2324f417ff4e4cc7d045ca6fbe92047f3c
    Gerrit-Change-Number: 7459701
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 23:28:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 6:32:10 PMJan 13
    to Victor Vianna, Alex Moshchuk, Avi Drissman, James Su, Hiroki Nakagawa, Kaan Icer, Akihiro Ota, Rijubrata Bhaumik, Peter Beverloo, (Julie)Jeongeun Kim, Christian Biesinger, AyeAye, servicewor...@chromium.org, yongshun+...@google.com, kyungjunle...@google.com, nektar...@chromium.org, creis...@chromium.org, toyosh...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, gavin...@chromium.org, yuzo+...@chromium.org, arthursonzog...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, alexmo...@chromium.org, spang...@chromium.org, chfreme...@chromium.org, francisjp...@google.com, msrame...@chromium.org, cambickel...@google.com, mkwst+w...@chromium.org, edgesto...@microsoft.com, yhanad...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, npm+...@chromium.org, mfoltz+wa...@chromium.org, enne...@chromium.org, ajwong...@chromium.org, tbansal+...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, michaelchec...@google.com, antoniosarto...@chromium.org, blink-work...@chromium.org, dullweb...@chromium.org, cfredri...@chromium.org, kinuko...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, jbauma...@chromium.org, shimazu+se...@chromium.org, tracing...@chromium.org, dmurph+wa...@chromium.org, apaselti...@chromium.org, alexmt...@chromium.org, bfcach...@chromium.org, devtools...@chromium.org, wfh+...@chromium.org, feature-v...@chromium.org, navigation...@chromium.org, prerenderi...@chromium.org, storage...@chromium.org, keithle...@chromium.org, tburkar...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Migrate base::Contains() to std::ranges::contains() in content

    base::Contains() is an alias to std::ranges::contains() since
    crrev.com/c/7415207, so this CL has no behavior change.
    Bug: 470391351
    Change-Id: Ib7217e2324f417ff4e4cc7d045ca6fbe92047f3c
    Reviewed-by: Avi Drissman <a...@chromium.org>
    Commit-Queue: Alex Moshchuk <ale...@chromium.org>
    Auto-Submit: Victor Vianna <victor...@google.com>
    Reviewed-by: Alex Moshchuk <ale...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568769}
    Files:
    • M content/browser/accessibility/accessibility_action_browsertest.cc
    • M content/browser/accessibility/browser_accessibility_android.cc
    • M content/browser/accessibility/browser_accessibility_manager_android.cc
    • M content/browser/accessibility/browser_accessibility_state_impl.cc
    • M content/browser/accessibility/browser_accessibility_state_impl_android.cc
    • M content/browser/attribution_reporting/attribution_resolver_impl.cc
    • M content/browser/back_forward_cache_browsertest.cc
    • M content/browser/back_forward_cache_features_browsertest.cc
    • M content/browser/bluetooth/advertisement_client.cc
    • M content/browser/browsing_data/browsing_data_remover_impl.cc
    • M content/browser/browsing_data/clear_site_data_handler.cc
    • M content/browser/child_process_launcher_helper_ios.mm
    • M content/browser/child_process_security_policy_impl.cc
    • M content/browser/content_security_policy_browsertest.cc
    • M content/browser/device_posture/device_posture_registry_watcher_win.cc
    • M content/browser/devtools/devtools_agent_host_impl_unittest.cc
    • M content/browser/devtools/devtools_http_handler.cc
    • M content/browser/devtools/protocol/network_handler.cc
    • M content/browser/file_system_access/file_path_watcher/file_path_watcher_fsevents_change_tracker.cc
    • M content/browser/file_system_access/file_system_access_file_writer_impl_unittest.cc
    • M content/browser/file_system_access/file_system_chooser_browsertest.cc
    • M content/browser/file_system_access/file_system_chooser_unittest.cc
    • M content/browser/find_request_manager.cc
    • M content/browser/first_party_sets/first_party_set_parser.cc
    • M content/browser/hid/hid_service.cc
    • M content/browser/indexed_db/instance/leveldb/backing_store.cc
    • M content/browser/interest_group/ad_auction_service_impl_unittest.cc
    • M content/browser/interest_group/auction_runner_unittest.cc
    • M content/browser/interest_group/interest_group_auction.cc
    • M content/browser/interest_group/interest_group_browsertest.cc
    • M content/browser/interest_group/trusted_signals_cache_impl_unittest.cc
    • M content/browser/loader/navigation_url_loader_impl.cc
    • M content/browser/media/active_media_session_controller.cc
    • M content/browser/media/capture/sub_capture_target_id_web_contents_helper.cc
    • M content/browser/media/midi_host.cc
    • M content/browser/media/session/media_session_impl.cc
    • M content/browser/memory_coordinator/browser_memory_consumer_registry.cc
    • M content/browser/network/sandboxed_nqe_browsertest.cc
    • M content/browser/permissions/permission_overrides.cc
    • M content/browser/plugin_list.cc
    • M content/browser/posix_file_descriptor_info_impl.cc
    • M content/browser/preloading/preconnect/preconnect_manager_impl_unittest.cc
    • M content/browser/preloading/prefetch/prefetch_container_unittest.cc
    • M content/browser/preloading/preloading_decider.cc
    • M content/browser/preloading/preloading_decider_unittest.cc
    • M content/browser/preloading/prerender/prerender_browsertest.cc
    • M content/browser/preloading/prerender/prerender_host.cc
    • M content/browser/preloading/prerender/prerender_host_registry.cc
    • M content/browser/preloading/prerender/prerender_navigation_throttle.cc
    • M content/browser/private_aggregation/private_aggregation_pending_contributions_unittest.cc
    • M content/browser/renderer_host/clipboard_host_impl_unittest.cc
    • M content/browser/renderer_host/compositor_impl_android.cc
    • M content/browser/renderer_host/dwrite_font_proxy_impl_win_unittest.cc
    • M content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
    • M content/browser/renderer_host/media/media_devices_manager.cc
    • M content/browser/renderer_host/media/media_stream_manager.cc
    • M content/browser/renderer_host/media/video_capture_controller.cc
    • M content/browser/renderer_host/media/video_capture_manager.cc
    • M content/browser/renderer_host/mixed_content_checker.cc
    • M content/browser/renderer_host/navigation_controller_impl_browsertest.cc
    • M content/browser/renderer_host/navigation_request.cc
    • M content/browser/renderer_host/render_frame_host_impl.cc
    • M content/browser/renderer_host/render_frame_host_impl_browsertest.cc
    • M content/browser/renderer_host/render_process_host_impl.cc
    • M content/browser/renderer_host/render_widget_host_browsertest.cc
    • M content/browser/renderer_host/render_widget_host_impl.cc
    • M content/browser/renderer_host/render_widget_host_view_browsertest.cc
    • M content/browser/renderer_host/spare_render_process_host_manager_browsertest.cc
    • M content/browser/renderer_host/spare_render_process_host_manager_impl.cc
    • M content/browser/service_worker/embedded_worker_instance.cc
    • M content/browser/site_info.cc
    • M content/browser/site_instance_impl.cc
    • M content/browser/site_per_process_browsertest.cc
    • M content/browser/site_per_process_hit_test_browsertest.cc
    • M content/browser/snapshot_browsertest.cc
    • M content/browser/tracing/background_tracing_manager_impl.cc
    • M content/browser/web_contents/web_contents_impl.cc
    • M content/browser/web_contents/web_contents_impl_browsertest.cc
    • M content/browser/webauth/authenticator_common_impl.cc
    • M content/browser/webid/accounts_fetcher.cc
    • M content/browser/webid/url_computations.cc
    • M content/browser/websockets/websocket_connector_impl.cc
    • M content/browser/webui/url_data_manager.cc
    • M content/browser/webui/url_data_manager_backend.cc
    • M content/browser/webui/web_ui_data_source_unittest.cc
    • M content/browser/xr/service/browser_xr_runtime_impl.cc
    • M content/browser/xr/service/vr_service_impl.cc
    • M content/child/memory_coordinator/child_memory_consumer_registry.cc
    • M content/common/font_cache_dispatcher_win.cc
    • M content/common/origin_util.cc
    • M content/common/webid/identity_url_loader_throttle.cc
    • M content/public/common/content_client.cc
    • M content/public/test/back_forward_cache_util.cc
    • M content/public/test/browser_test_utils.cc
    • M content/public/test/mock_render_process_host.cc
    • M content/renderer/accessibility/annotations/ax_image_annotator.cc
    • M content/shell/browser/shell_devtools_bindings.cc
    • M content/shell/browser/shell_platform_delegate_aura.cc
    • M content/shell/browser/shell_platform_delegate_ios.mm
    • M content/test/mock_clipboard_host.cc
    • M content/test/web_contents_observer_consistency_checker.cc
    • M content/web_test/renderer/test_runner.cc
    Change size: L
    Delta: 102 files changed, 366 insertions(+), 359 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Avi Drissman, +1 by Alex Moshchuk
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib7217e2324f417ff4e4cc7d045ca6fbe92047f3c
    Gerrit-Change-Number: 7459701
    Gerrit-PatchSet: 2
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement

    Demetrios Papadopoulos (Gerrit)

    unread,
    Jan 16, 2026, 6:34:45 PMJan 16
    to Chromium LUCI CQ, Alex Moshchuk, Avi Drissman, James Su, Hiroki Nakagawa, Kaan Icer, Rijubrata Bhaumik, Peter Beverloo, (Julie)Jeongeun Kim, Christian Biesinger, AyeAye, servicewor...@chromium.org, yongshun+...@google.com, kyungjunle...@google.com, nektar...@chromium.org, creis...@chromium.org, toyosh...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, gavin...@chromium.org, yuzo+...@chromium.org, arthursonzog...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, alexmo...@chromium.org, spang...@chromium.org, chfreme...@chromium.org, francisjp...@google.com, msrame...@chromium.org, cambickel...@google.com, mkwst+w...@chromium.org, edgesto...@microsoft.com, yhanad...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, npm+...@chromium.org, mfoltz+wa...@chromium.org, enne...@chromium.org, ajwong...@chromium.org, tbansal+...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, michaelchec...@google.com, antoniosarto...@chromium.org, blink-work...@chromium.org, dullweb...@chromium.org, cfredri...@chromium.org, kinuko...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, jbauma...@chromium.org, shimazu+se...@chromium.org, tracing...@chromium.org, dmurph+wa...@chromium.org, apaselti...@chromium.org, alexmt...@chromium.org, bfcach...@chromium.org, devtools...@chromium.org, wfh+...@chromium.org, feature-v...@chromium.org, navigation...@chromium.org, prerenderi...@chromium.org, storage...@chromium.org, keithle...@chromium.org, tburkar...@chromium.org

    Demetrios Papadopoulos added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Demetrios Papadopoulos . unresolved

    I can't build content_unittests locally after this CL landed, getting the following error. Curious why this isn't turning the bots red. Do I need to change something in my environment to fix?

    ```
    stdout:
    ../../content/browser/webui/web_ui_data_source_unittest.cc:490:15: error: no matching function for call to object of type 'const __contains'
      490 |   EXPECT_TRUE(std::ranges::contains(result, "hello plain!"));
          |               ^~~~~~~~~~~~~~~~~~~~~
    ../../third_party/googletest/src/googletest/include/gtest/gtest.h:1826:50: note: expanded from macro 'EXPECT_TRUE'
     1826 | #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
          |                                                  ^~~~~~~~~
    ../../third_party/googletest/src/googletest/include/gtest/gtest.h:1811:23: note: expanded from macro 'GTEST_EXPECT_TRUE'
     1811 |   GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
          |                       ^~~~~~~~~
    ../../third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:1450:38: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
     1450 |           ::testing::AssertionResult(expression))                     \
          |                                      ^~~~~~~~~~
    gen/third_party/libc++/src/include/__algorithm/ranges_contains.h:47:3: note: candidate template ignored: constraints not satisfied [with _Range = std::string &, _Type = char[13], _Proj = identity]
       47 |   operator()(_Range&& __range, const _Type& __value, _Proj __proj = {}) {
          |   ^
    gen/third_party/libc++/src/include/__algorithm/ranges_contains.h:45:14: note: because 'indirect_binary_predicate<ranges::equal_to, projected<iterator_t<std::string &>, identity>, const char *[13]>' evaluated to false
       45 |     requires indirect_binary_predicate<ranges::equal_to, projected<iterator_t<_Range>, _Proj>, const _Type*>
          |              ^
    gen/third_party/libc++/src/include/__iterator/concepts.h:264:5: note: because 'predicate<std::ranges::equal_to &, __indirect_value_t<std::__projected_impl<std::__wrap_iter<char *>, std::identity>::__type>, __indirect_value_t<const char (*)[13]>>' evaluated to false
      264 |     predicate<_Fp&, __indirect_value_t<_It1>, __indirect_value_t<_It2>> &&
          |     ^
    gen/third_party/libc++/src/include/__concepts/predicate.h:28:21: note: because 'regular_invocable<std::ranges::equal_to &, char &, char (&)[13]>' evaluated to false
       28 | concept predicate = regular_invocable<_Fn, _Args...> && __boolean_testable<invoke_result_t<_Fn, _Args...>>;
          |                     ^
    gen/third_party/libc++/src/include/__concepts/invocable.h:34:29: note: because 'invocable<std::ranges::equal_to &, char &, char (&)[13]>' evaluated to false
       34 | concept regular_invocable = invocable<_Fn, _Args...>;
          |                             ^
    gen/third_party/libc++/src/include/__concepts/invocable.h:28:3: note: because 'std::invoke(std::forward<_Fn>(__fn), std::forward<_Args>(__args)...)' would be invalid: no matching function for call to 'invoke'
       28 |   std::invoke(std::forward<_Fn>(__fn), std::forward<_Args>(__args)...); // not required to be equality preserving
          |   ^
    gen/third_party/libc++/src/include/__algorithm/ranges_contains.h:40:3: note: candidate function template not viable: requires at least 3 arguments, but 2 were provided
       40 |   operator()(_Iter __first, _Sent __last, const _Type& __value, _Proj __proj = {}) {
          |   ^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.

    build failed
    ```

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib7217e2324f417ff4e4cc7d045ca6fbe92047f3c
    Gerrit-Change-Number: 7459701
    Gerrit-PatchSet: 2
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Comment-Date: Fri, 16 Jan 2026 23:34:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Demetrios Papadopoulos (Gerrit)

    unread,
    Jan 20, 2026, 3:08:06 PMJan 20
    to Chromium LUCI CQ, Alex Moshchuk, Avi Drissman, James Su, Hiroki Nakagawa, Kaan Icer, Rijubrata Bhaumik, Peter Beverloo, (Julie)Jeongeun Kim, Christian Biesinger, AyeAye, servicewor...@chromium.org, yongshun+...@google.com, kyungjunle...@google.com, nektar...@chromium.org, creis...@chromium.org, toyosh...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, gavin...@chromium.org, yuzo+...@chromium.org, arthursonzog...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, alexmo...@chromium.org, spang...@chromium.org, chfreme...@chromium.org, francisjp...@google.com, msrame...@chromium.org, cambickel...@google.com, mkwst+w...@chromium.org, edgesto...@microsoft.com, yhanad...@chromium.org, derinel+wat...@google.com, feature-me...@chromium.org, npm+...@chromium.org, mfoltz+wa...@chromium.org, enne...@chromium.org, ajwong...@chromium.org, tbansal+...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, michaelchec...@google.com, antoniosarto...@chromium.org, blink-work...@chromium.org, dullweb...@chromium.org, cfredri...@chromium.org, kinuko...@chromium.org, dtseng...@chromium.org, josiah...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, jbauma...@chromium.org, shimazu+se...@chromium.org, tracing...@chromium.org, dmurph+wa...@chromium.org, apaselti...@chromium.org, alexmt...@chromium.org, bfcach...@chromium.org, devtools...@chromium.org, wfh+...@chromium.org, feature-v...@chromium.org, navigation...@chromium.org, prerenderi...@chromium.org, storage...@chromium.org, keithle...@chromium.org, tburkar...@chromium.org

    Demetrios Papadopoulos added 1 comment

    Patchset-level comments
    Demetrios Papadopoulos . resolved
    Demetrios Papadopoulos
    Gerrit-Comment-Date: Tue, 20 Jan 2026 20:07:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Demetrios Papadopoulos <dpa...@chromium.org>
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages