Convert to UNSAFE_TODO in services [chromium/src : main]

0 views

Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,

Nov 7, 2025, 12:08:09 PM (2 days ago) Nov 7

to Raphael Kubo da Costa, Wanming Lin, Rijubrata Bhaumik, Zijie He, Hu, Ningxin, chromium...@chromium.org, Jiewei Qian, spang...@chromium.org, fuchsia...@chromium.org, odejesu...@chromium.org, wfh+...@chromium.org, chrome-gr...@chromium.org, mac-r...@chromium.org, fuzzin...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, tracing...@chromium.org

Arthur Sonzogni has uploaded the change for review

Commit message

Convert to UNSAFE_TODO in services

This is an automated #cleanup patch using the [Script] below.

We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations, allowing
the rest of the file to be enforced as safe.

This CL was uploaded by git cl split.

Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing

AX-Relnotes: N/A

Cleanup: This is an automated #cleanup.

Bug: 409340989

Change-Id: I52baecef50ca0eb0437b0eee04b153898a96a4e1

Change diff

Change information

Files:

M services/device/generic_sensor/platform_sensor_chromeos_unittest.cc
M services/device/generic_sensor/platform_sensor_provider_chromeos_unittest.cc
M services/device/generic_sensor/platform_sensor_reader_win.cc
M services/device/geolocation/wifi_data_provider_common_win.cc
M services/device/geolocation/wifi_data_provider_win.cc
M services/device/hid/hid_preparsed_data.cc
M services/device/hid/hid_report_descriptor_fuzzer.cc
M services/device/public/cpp/generic_sensor/sensor_mojom_traits.h
M services/device/usb/usb_descriptors_fuzzer.cc
M services/device/usb/usb_device_handle_impl.cc
M services/device/usb/usb_device_impl.cc
M services/device/usb/usb_service_impl.cc
M services/device/usb/usb_string_read_fuzzer.cc
M services/network/trust_tokens/scoped_boringssl_bytes.h
M services/proxy_resolver_win/windows_system_proxy_resolver_impl.cc
M services/proxy_resolver_win/windows_system_proxy_resolver_impl_unittest.cc
M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_mac.cc
M services/shape_detection/face_detection_impl_mac_vision.mm
M services/tracing/public/cpp/perfetto/fuchsia_perfetto_producer_connector_unittest.cc
M services/tracing/public/cpp/perfetto/java_heap_profiler/hprof_buffer_android.cc
M services/tracing/public/cpp/perfetto/java_heap_profiler/hprof_buffer_android_unittest.cc
M services/tracing/public/cpp/perfetto/java_heap_profiler/hprof_data_type_android.h
M services/tracing/public/cpp/perfetto/java_heap_profiler/hprof_parser_android_unittest.cc
M services/tracing/public/cpp/perfetto/system_trace_writer.h
M services/webnn/dml/command_recorder.cc
M services/webnn/dml/command_recorder_test.cc
M services/webnn/dml/context_impl_dml.cc
M services/webnn/dml/graph_impl_dml.cc

Change size: M

Delta: 28 files changed, 58 insertions(+), 176 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Arthur Sonzogni (Gerrit)

unread,

Nov 8, 2025, 2:39:52 AM (yesterday) Nov 8

to chromium...@chromium.org, Raphael Kubo da Costa, Hu, Ningxin, Jiewei Qian, Rijubrata Bhaumik, Wanming Lin, Zijie He, chrome-gr...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Arthur Sonzogni voted Commit-Queue+1

Commit-Queue