etw-stackwalk: send debug GUIDs from browser [requires perfetto change] [chromium/src : main]

2 views

Skip to first unread message

Sean Maher (Gerrit)

unread,

May 16, 2026, 9:17:19 PM (5 days ago) May 16

to Jesse McKenna, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Jesse McKenna

Sean Maher added 3 comments

File components/tracing/common/active_processes_win.h

Line 148, Patchset 2 (Latest): std::unordered_map<std::string, std::string> image_guids_;

Sean Maher . unresolved

if this is more than like 8 items large i think we should use a more performant map, say absl::flat_hash_map or whatever it's called

File components/tracing/common/tracing_scenarios_config.cc

Line 226, Patchset 2 (Latest): L"advapi32.dll"};

Sean Maher . unresolved

in system32: ntoskrnl.exe, dbghelp.dll, user32.dll, apphelp.dll
in chrome: libEGL.dll, libGLESv2.dll, dxil.dll, dxcompiler.dll, vulkan-1.dll, maybe also the other ones

Line 244, Patchset 2 (Latest): // ⭐⭐⭐ TODO: do we also need age? it's needed to pull symbols

Sean Maher . unresolved

are you typing these stars

Open in Gerrit

Related details

Attention is currently required from:

Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sean Maher (Gerrit)

unread,

May 16, 2026, 9:23:32 PM (5 days ago) May 16

to Jesse McKenna, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Jesse McKenna

Sean Maher added 1 comment

File components/tracing/common/etw_system_data_source_win.cc

Line 162, Patchset 1: image_guids.emplace(entry.key(), entry.value());

Sean Maher . unresolved

keep in mind that these are gonna be NT kernel pathes (start with `\HardDisk0\` or whatedver)

Open in Gerrit

Related details

Attention is currently required from:

Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages