Jack Miller (Gerrit)

unread,

May 8, 2026, 1:48:41 PM (13 days ago) May 8

to Jesse McKenna, David Bienvenu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu and Jesse McKenna

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Bienvenu (Gerrit)

unread,

May 8, 2026, 2:48:33 PM (13 days ago) May 8

to Jack Miller, Jesse McKenna, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Jack Miller and Jesse McKenna

David Bienvenu voted and added 2 comments

Votes added by David Bienvenu

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

David Bienvenu . resolved

lgtm modulo comment nit.

File components/tracing/common/etw_consumer_win.cc

Line 795, Patchset 3 (Latest):

  //   3 pointers + 3 `uint32`s + wide string contents + wide string terminator.
  const size_t kMinimumSize =

David Bienvenu . unresolved

comment doesn't match code. I think code is correct.

Open in Gerrit

Related details

Attention is currently required from:

Jack Miller
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jack Miller (Gerrit)

unread,

May 8, 2026, 4:33:46 PM (13 days ago) May 8

to Etienne Pierre-Doray, David Bienvenu, Jesse McKenna, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu, Etienne Pierre-Doray and Jesse McKenna

Jack Miller added 1 comment

File components/tracing/common/etw_consumer_win.cc

Line 795, Patchset 3:

  //   3 pointers + 3 `uint32`s + wide string contents + wide string terminator.
  const size_t kMinimumSize =

David Bienvenu . resolved

comment doesn't match code. I think code is correct.

Jack Miller

Good catch! I updated the comment to align with the code.

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Etienne Pierre-Doray
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

May 11, 2026, 2:05:21 PM (10 days ago) May 11

to Jack Miller, David Bienvenu, Jesse McKenna, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu, Jack Miller and Jesse McKenna

Etienne Pierre-Doray added 2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Etienne Pierre-Doray . resolved

LG, but let's wait for perfetto CL to land and roll

File components/tracing/common/etw_consumer_win.cc

Line 787, Patchset 4 (Latest):bool EtwConsumer::DecodeFileIoPathOperationEvent(

Etienne Pierre-Doray . unresolved

Can you add a minimal test in components/tracing/common/etw_consumer_win_unittest.cc similar to FileIoFltOpEvent

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Jack Miller
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jesse McKenna (Gerrit)

unread,

May 11, 2026, 2:32:12 PM (10 days ago) May 11

to Jack Miller, Etienne Pierre-Doray, David Bienvenu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu and Jack Miller

Jesse McKenna voted and added 5 comments

Votes added by Jesse McKenna

Code-Review

+1

5 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Jesse McKenna . resolved

LGTM with nits : )

File components/tracing/common/etw_consumer_win.h

Line 181, Patchset 4 (Latest): // Decodes a FileIo_PathOperation event and emits a Perfetto trace event.

Jesse McKenna . unresolved

nit: enclose in backticks
```suggestion
  // Decodes a `FileIo_PathOperation` event and emits a Perfetto trace event.
```

File components/tracing/common/etw_consumer_win.cc

Line 318, Patchset 4 (Latest):

    case 79:  // PathDelete
    case 80:  // PathRename

Jesse McKenna . unresolved

Optional: I couldn't find any docs for PathDelete or PathRename - where did you find these? It might be better to match the comments above and use plain English, e.g., "Delete path", "Rename path". Disregard if these are the real event names and you think including them is useful.

Line 322, Patchset 4 (Latest): DLOG(ERROR) << "Error decoding FileIO_PathOperation event";

Jesse McKenna . unresolved

FileIo

Line 802, Patchset 4 (Latest): // Read the contents of `packet_data` and generate a `FileIoInfo` event.

Jesse McKenna . unresolved

Should this be FileIo_PathOperation?

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Jack Miller

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jack Miller (Gerrit)

unread,

May 11, 2026, 7:01:28 PM (10 days ago) May 11

to Jesse McKenna, Etienne Pierre-Doray, David Bienvenu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu, Etienne Pierre-Doray and Jesse McKenna

Jack Miller voted and added 3 comments

Votes added by Jack Miller

Commit-Queue

+0

3 comments

File components/tracing/common/etw_consumer_win.cc

Line 318, Patchset 4:

    case 79:  // PathDelete
    case 80:  // PathRename

Jesse McKenna . resolved

Optional: I couldn't find any docs for PathDelete or PathRename - where did you find these? It might be better to match the comments above and use plain English, e.g., "Delete path", "Rename path". Disregard if these are the real event names and you think including them is useful.

Jack Miller

I wasn't able to find any docs for these events. The "PathOperation" part came from https://gist.github.com/jdu2600/a2b03e4e9cf19282a41ad766388c9856 and the rename/delete part by matching the `InfoClass` value with https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/wdm/ne-wdm-_file_information_class.

I'll update them to match the ones above since these aren't "official" names

Line 322, Patchset 4: DLOG(ERROR) << "Error decoding FileIO_PathOperation event";

Jesse McKenna . resolved

FileIo

Jack Miller

Good catch! Updated

Line 787, Patchset 4:bool EtwConsumer::DecodeFileIoPathOperationEvent(

Etienne Pierre-Doray . resolved

Can you add a minimal test in components/tracing/common/etw_consumer_win_unittest.cc similar to FileIoFltOpEvent

Jack Miller

Absolutely! Added

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Etienne Pierre-Doray
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jack Miller (Gerrit)

unread,

May 11, 2026, 7:05:52 PM (10 days ago) May 11

to Jesse McKenna, Etienne Pierre-Doray, David Bienvenu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu, Etienne Pierre-Doray and Jesse McKenna

Jack Miller added 2 comments

File components/tracing/common/etw_consumer_win.h

Line 181, Patchset 4: // Decodes a FileIo_PathOperation event and emits a Perfetto trace event.

Jesse McKenna . resolved

nit: enclose in backticks
```suggestion
  // Decodes a `FileIo_PathOperation` event and emits a Perfetto trace event.
```

Jack Miller

Done

File components/tracing/common/etw_consumer_win.cc

Line 802, Patchset 4: // Read the contents of `packet_data` and generate a `FileIoInfo` event.

Jesse McKenna . resolved

Should this be FileIo_PathOperation?

Jack Miller

Ya, good catch. Updated

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Etienne Pierre-Doray
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Bienvenu (Gerrit)

unread,

May 11, 2026, 7:18:54 PM (10 days ago) May 11

to Jack Miller, Jesse McKenna, Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Etienne Pierre-Doray, Jack Miller and Jesse McKenna

David Bienvenu voted and added 1 comment

Votes added by David Bienvenu

Code-Review

+1

1 comment

File components/tracing/common/etw_consumer_win_unittest.cc

Line 1344, Patchset 7 (Latest):

// Tests that a FileIoPathOperationEtwEvent is emitted for a
// FileIo_PathOperation ETW event.

David Bienvenu . unresolved

backticks around these, here and on the other test.

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray
Jack Miller
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jesse McKenna (Gerrit)

unread,

May 11, 2026, 7:27:43 PM (10 days ago) May 11

to Jack Miller, David Bienvenu, Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Etienne Pierre-Doray and Jack Miller

Jesse McKenna voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray
Jack Miller

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jack Miller (Gerrit)

unread,

May 13, 2026, 7:21:17 PM (8 days ago) May 13

to Jesse McKenna, David Bienvenu, Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu, Etienne Pierre-Doray and Jesse McKenna

Jack Miller voted and added 1 comment

Votes added by Jack Miller

Commit-Queue

+0

1 comment

File components/tracing/common/etw_consumer_win_unittest.cc

Line 1344, Patchset 7:

// Tests that a FileIoPathOperationEtwEvent is emitted for a
// FileIo_PathOperation ETW event.

David Bienvenu . resolved

backticks around these, here and on the other test.

Jack Miller

Thanks, updated

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Etienne Pierre-Doray
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jesse McKenna (Gerrit)

unread,

May 13, 2026, 8:05:34 PM (8 days ago) May 13

to Jack Miller, David Bienvenu, Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu, Etienne Pierre-Doray and Jack Miller

Jesse McKenna voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Etienne Pierre-Doray
Jack Miller

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Bienvenu (Gerrit)

unread,

May 14, 2026, 4:39:07 PM (7 days ago) May 14

to Jack Miller, Jesse McKenna, Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Etienne Pierre-Doray and Jack Miller

David Bienvenu voted and added 1 comment

Votes added by David Bienvenu

Code-Review

+1

1 comment

File components/tracing/common/etw_consumer_win.cc

Line 792, Patchset 10 (Latest): using perfetto::protos::pbzero::FileIoPathOperationEtwEvent;

David Bienvenu . unresolved

is this useful?

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray
Jack Miller

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jack Miller (Gerrit)

unread,

May 15, 2026, 1:02:03 PM (6 days ago) May 15

to David Bienvenu, Jesse McKenna, Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu, Etienne Pierre-Doray and Jesse McKenna

Jack Miller voted and added 1 comment

Votes added by Jack Miller

Commit-Queue

+1

1 comment

File components/tracing/common/etw_consumer_win.cc

Line 792, Patchset 10 (Latest): using perfetto::protos::pbzero::FileIoPathOperationEtwEvent;

David Bienvenu . unresolved

is this useful?

Jack Miller

I never tried writing the method without it because the other `DecodeFileIo*` methods in the file all had a similar `using` statement. But I just tried compiling without it and it works file. Do you know why these were added in the first place?

I can remove this and the other `using` statements from the `DecodeFileIo*` methods if they don't have a specific purpose

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Etienne Pierre-Doray
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

May 15, 2026, 1:09:52 PM (6 days ago) May 15

to Jack Miller, David Bienvenu, Jesse McKenna, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu, Jack Miller and Jesse McKenna

Etienne Pierre-Doray voted and added 2 comments

Votes added by Etienne Pierre-Doray

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Etienne Pierre-Doray . resolved

LGTM % comment, thanks!

File components/tracing/common/etw_consumer_win.cc

Line 792, Patchset 10 (Latest): using perfetto::protos::pbzero::FileIoPathOperationEtwEvent;

David Bienvenu . unresolved

is this useful?

Jack Miller

I never tried writing the method without it because the other `DecodeFileIo*` methods in the file all had a similar `using` statement. But I just tried compiling without it and it works file. Do you know why these were added in the first place?
I can remove this and the other `using` statements from the `DecodeFileIo*` methods if they don't have a specific purpose

Etienne Pierre-Doray

+1, looks like FileIoPathOperationEtwEvent alias isn't used.

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Jack Miller
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jack Miller (Gerrit)

unread,

May 15, 2026, 1:25:14 PM (6 days ago) May 15

to Etienne Pierre-Doray, David Bienvenu, Jesse McKenna, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from David Bienvenu, Etienne Pierre-Doray and Jesse McKenna

Jack Miller added 1 comment

File components/tracing/common/etw_consumer_win.cc

Line 792, Patchset 10: using perfetto::protos::pbzero::FileIoPathOperationEtwEvent;

David Bienvenu . resolved

is this useful?

Jack Miller

I never tried writing the method without it because the other `DecodeFileIo*` methods in the file all had a similar `using` statement. But I just tried compiling without it and it works file. Do you know why these were added in the first place?
I can remove this and the other `using` statements from the `DecodeFileIo*` methods if they don't have a specific purpose

Etienne Pierre-Doray

+1, looks like FileIoPathOperationEtwEvent alias isn't used.

Jack Miller

Thanks, I removed `FileIoPathOperationEtwEvent` and the other using statements from the `DecodeFileIo*` methods

Open in Gerrit

Related details

Attention is currently required from:

David Bienvenu
Etienne Pierre-Doray
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Bienvenu (Gerrit)

unread,

May 15, 2026, 1:42:27 PM (6 days ago) May 15

to Jack Miller, Etienne Pierre-Doray, Jesse McKenna, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Etienne Pierre-Doray, Jack Miller and Jesse McKenna

David Bienvenu added 1 comment

File components/tracing/common/etw_consumer_win.cc

Line 792, Patchset 10: using perfetto::protos::pbzero::FileIoPathOperationEtwEvent;

David Bienvenu . resolved

is this useful?

Jack Miller

I never tried writing the method without it because the other `DecodeFileIo*` methods in the file all had a similar `using` statement. But I just tried compiling without it and it works file. Do you know why these were added in the first place?
I can remove this and the other `using` statements from the `DecodeFileIo*` methods if they don't have a specific purpose

Etienne Pierre-Doray

+1, looks like FileIoPathOperationEtwEvent alias isn't used.

Jack Miller

Thanks, I removed `FileIoPathOperationEtwEvent` and the other using statements from the `DecodeFileIo*` methods

David Bienvenu

I'm going to blame AI :-)

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray
Jack Miller
Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Bienvenu (Gerrit)

unread,

May 15, 2026, 3:26:05 PM (6 days ago) May 15

to Jack Miller, Etienne Pierre-Doray, Jesse McKenna, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Etienne Pierre-Doray, Jack Miller and Jesse McKenna

David Bienvenu voted Code-Review+1

Code-Review

+1

satisfied_requirement

unsatisfied_requirement

open

diffy

Jesse McKenna (Gerrit)

unread,

May 15, 2026, 4:01:36 PM (6 days ago) May 15

to Jack Miller, David Bienvenu, Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Etienne Pierre-Doray and Jack Miller

Jesse McKenna voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray
Jack Miller

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Jack Miller (Gerrit)

unread,

May 15, 2026, 4:58:52 PM (6 days ago) May 15

to Jesse McKenna, David Bienvenu, Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Etienne Pierre-Doray

Jack Miller voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

May 15, 2026, 6:08:35 PM (6 days ago) May 15

to Jack Miller, Jesse McKenna, David Bienvenu, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Add FileIo_PathOperation event support

Bug: 400769108

Change-Id: I7bc74b687cba1d29c3d17102b97fd94b56712ee5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7804710

Commit-Queue: Jack Miller <jac...@google.com>

Reviewed-by: David Bienvenu <davidb...@chromium.org>

Reviewed-by: Jesse McKenna <jessem...@google.com>

Cr-Commit-Position: refs/heads/main@{#1631592}

Files:

M components/tracing/common/etw_consumer_win.cc
M components/tracing/common/etw_consumer_win.h
M components/tracing/common/etw_consumer_win_unittest.cc

Change size: M

Delta: 3 files changed, 182 insertions(+), 17 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by David Bienvenu, +1 by Jesse McKenna

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Add FileIo_PathOperation event support [chromium/src : main]

Jack Miller (Gerrit)

New activity on the change

Related details

David Bienvenu (Gerrit)

David Bienvenu voted and added 2 comments

Votes added by David Bienvenu

2 comments

Related details

Jack Miller (Gerrit)

Jack Miller added 1 comment

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray added 2 comments

Related details

Jesse McKenna (Gerrit)

Jesse McKenna voted and added 5 comments

Votes added by Jesse McKenna

5 comments

Related details

Jack Miller (Gerrit)

Jack Miller voted and added 3 comments

Votes added by Jack Miller

3 comments

Related details

Jack Miller (Gerrit)

Jack Miller added 2 comments

Related details

David Bienvenu (Gerrit)

David Bienvenu voted and added 1 comment

Votes added by David Bienvenu

1 comment

Related details

Jesse McKenna (Gerrit)

Jesse McKenna voted Code-Review+1

Related details

Jack Miller (Gerrit)

Jack Miller voted and added 1 comment

Votes added by Jack Miller

1 comment

Related details

Jesse McKenna (Gerrit)

Jesse McKenna voted Code-Review+1

Related details

David Bienvenu (Gerrit)

David Bienvenu voted and added 1 comment

Votes added by David Bienvenu

1 comment

Related details

Jack Miller (Gerrit)

Jack Miller voted and added 1 comment

Votes added by Jack Miller

1 comment

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted and added 2 comments

Votes added by Etienne Pierre-Doray

2 comments

Related details

Jack Miller (Gerrit)

Jack Miller added 1 comment

Related details

David Bienvenu (Gerrit)

David Bienvenu added 1 comment

Related details

David Bienvenu (Gerrit)

David Bienvenu voted Code-Review+1

Jesse McKenna (Gerrit)

Jesse McKenna voted Code-Review+1

Related details

Jack Miller (Gerrit)

Jack Miller voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information