Track password elements using the TrackedElement framework [chromium/src : main]

0 views
Skip to first unread message

Ryan Kalla (Gerrit)

unread,
May 18, 2026, 12:31:50 PM (3 days ago) May 18
to Nan Lin, srirama chandra sekhar, Hiroki Nakagawa, Chromium Metrics Reviews, Kevin Babbitt, (Julie)Jeongeun Kim, Peter Beverloo, android-bu...@system.gserviceaccount.com, SLSA Policy Verification Service, Khushal Sagar, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, eric.c...@apple.com, media-wi...@chromium.org, siashah+au...@chromium.org, mfoltz+wa...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, lucasrada...@google.com, johnche...@chromium.org, vaapi-...@chromium.org, osaul+aut...@google.com, ender...@chromium.org, dewitt...@chromium.org, abigailbk...@google.com, feature-me...@chromium.org, asvitki...@chromium.org, lens-chrome...@google.com, tracing...@chromium.org, chromotin...@chromium.org, dullweb...@chromium.org, marq+...@chromium.org, tommyw+w...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, christia...@chromium.org, stanfie...@google.com, mfoltz+wa...@chromium.org, horo+...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, jophba...@chromium.org, spang...@chromium.org, sky+...@chromium.org, dtseng...@chromium.org, vinnypersky+...@google.com, roblia...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, chromiumme...@microsoft.com, shgar+aut...@google.com, armalhotra+a...@google.com, dfried...@chromium.org, ios-r...@chromium.org, siyua+aut...@chromium.org, ntp-dev...@chromium.org, odejesu...@chromium.org, chromium-a...@chromium.org, blink-re...@chromium.org, peilinwa...@google.com, omnibox-...@chromium.org, cros-system-ui-prod...@google.com, blink-rev...@chromium.org, blink-work...@chromium.org, estali...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, blink-revie...@chromium.org, mac-r...@chromium.org, shimazu+se...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, lwinston+watc...@google.com, mercer...@google.com, telemetr...@chromium.org, kinuko+ser...@chromium.org, media-cro...@chromium.org, chromeos-gfx-...@google.com, oshima...@chromium.org, trewin...@google.com, mattreyno...@chromium.org, ios-revie...@chromium.org, asvitkine...@chromium.org, jatapiaro+wat...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Khushal Sagar and Nan Lin

Ryan Kalla voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Khushal Sagar
  • Nan Lin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic715ed4b13fc59f27e9c7ae03b02db97e7ac444f
Gerrit-Change-Number: 7837758
Gerrit-PatchSet: 12
Gerrit-Owner: Nan Lin <lin...@chromium.org>
Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>
Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Nan Lin <lin...@chromium.org>
Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>
Gerrit-Comment-Date: Mon, 18 May 2026 16:31:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nan Lin (Gerrit)

unread,
May 18, 2026, 12:34:10 PM (3 days ago) May 18
to Ryan Kalla, srirama chandra sekhar, Hiroki Nakagawa, Chromium Metrics Reviews, Kevin Babbitt, (Julie)Jeongeun Kim, Peter Beverloo, android-bu...@system.gserviceaccount.com, SLSA Policy Verification Service, Khushal Sagar, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, eric.c...@apple.com, media-wi...@chromium.org, siashah+au...@chromium.org, mfoltz+wa...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, lucasrada...@google.com, johnche...@chromium.org, vaapi-...@chromium.org, osaul+aut...@google.com, ender...@chromium.org, dewitt...@chromium.org, abigailbk...@google.com, feature-me...@chromium.org, asvitki...@chromium.org, lens-chrome...@google.com, tracing...@chromium.org, chromotin...@chromium.org, dullweb...@chromium.org, marq+...@chromium.org, tommyw+w...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, christia...@chromium.org, stanfie...@google.com, mfoltz+wa...@chromium.org, horo+...@chromium.org, yuzo+...@chromium.org, francisjp...@google.com, jophba...@chromium.org, spang...@chromium.org, sky+...@chromium.org, dtseng...@chromium.org, vinnypersky+...@google.com, roblia...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, chromiumme...@microsoft.com, shgar+aut...@google.com, armalhotra+a...@google.com, dfried...@chromium.org, ios-r...@chromium.org, siyua+aut...@chromium.org, ntp-dev...@chromium.org, odejesu...@chromium.org, chromium-a...@chromium.org, blink-re...@chromium.org, peilinwa...@google.com, omnibox-...@chromium.org, cros-system-ui-prod...@google.com, blink-rev...@chromium.org, blink-work...@chromium.org, estali...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, blink-revie...@chromium.org, mac-r...@chromium.org, shimazu+se...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, lwinston+watc...@google.com, mercer...@google.com, telemetr...@chromium.org, kinuko+ser...@chromium.org, media-cro...@chromium.org, chromeos-gfx-...@google.com, oshima...@chromium.org, trewin...@google.com, mattreyno...@chromium.org, ios-revie...@chromium.org, asvitkine...@chromium.org, jatapiaro+wat...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Khushal Sagar

Nan Lin added 1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Nan Lin . resolved

@khusha...@chromium.org Just friendly ping, could you PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Khushal Sagar
Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>
Gerrit-Comment-Date: Mon, 18 May 2026 16:33:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nan Lin (Gerrit)

unread,
May 18, 2026, 12:37:16 PM (3 days ago) May 18
to vinnypersky+...@google.com, Ryan Kalla, srirama chandra sekhar, Hiroki Nakagawa, Chromium Metrics Reviews, Kevin Babbitt, (Julie)Jeongeun Kim, Peter Beverloo, android-bu...@system.gserviceaccount.com, SLSA Policy Verification Service, Khushal Sagar, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, eric.c...@apple.com, media-wi...@chromium.org, siashah+au...@chromium.org, mfoltz+wa...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, lucasrada...@google.com, johnche...@chromium.org, vaapi-...@chromium.org, osaul+aut...@google.com, ender...@chromium.org, dewitt...@chromium.org, abigailbk...@google.com, feature-me...@chromium.org, asvitki...@chromium.org, lens-chrome...@google.com, tracing...@chromium.org, chromotin...@chromium.org, dullweb...@chromium.org, marq+...@chromium.org, tommyw+w...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, christia...@chromium.org, stanfie...@google.com, mfoltz+wa...@chromium.org, horo+...@chromium.org, francisjp...@google.com, jophba...@chromium.org, spang...@chromium.org, sky+...@chromium.org, dtseng...@chromium.org, roblia...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, chromiumme...@microsoft.com, shgar+aut...@google.com, armalhotra+a...@google.com, dfried...@chromium.org, ios-r...@chromium.org, siyua+aut...@chromium.org, ntp-dev...@chromium.org, odejesu...@chromium.org, chromium-a...@chromium.org, blink-re...@chromium.org, peilinwa...@google.com, omnibox-...@chromium.org, cros-system-ui-prod...@google.com, blink-rev...@chromium.org, blink-work...@chromium.org, estali...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, blink-revie...@chromium.org, mac-r...@chromium.org, shimazu+se...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, lwinston+watc...@google.com, mercer...@google.com, telemetr...@chromium.org, kinuko+ser...@chromium.org, media-cro...@chromium.org, chromeos-gfx-...@google.com, oshima...@chromium.org, trewin...@google.com, mattreyno...@chromium.org, ios-revie...@chromium.org, asvitkine...@chromium.org, jatapiaro+wat...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Khushal Sagar

Nan Lin removed vinnypersky+...@google.com from this change

Deleted Reviewers:
Open in Gerrit

Related details

Attention is currently required from:
  • Khushal Sagar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
satisfied_requirement
unsatisfied_requirement
open
diffy

Nan Lin (Gerrit)

unread,
May 18, 2026, 12:37:18 PM (3 days ago) May 18
to yuzo+...@chromium.org, Ryan Kalla, srirama chandra sekhar, Hiroki Nakagawa, Chromium Metrics Reviews, Kevin Babbitt, (Julie)Jeongeun Kim, Peter Beverloo, android-bu...@system.gserviceaccount.com, SLSA Policy Verification Service, Khushal Sagar, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, eric.c...@apple.com, media-wi...@chromium.org, siashah+au...@chromium.org, mfoltz+wa...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, lucasrada...@google.com, johnche...@chromium.org, vaapi-...@chromium.org, osaul+aut...@google.com, ender...@chromium.org, dewitt...@chromium.org, abigailbk...@google.com, feature-me...@chromium.org, asvitki...@chromium.org, lens-chrome...@google.com, tracing...@chromium.org, chromotin...@chromium.org, dullweb...@chromium.org, marq+...@chromium.org, tommyw+w...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, christia...@chromium.org, stanfie...@google.com, mfoltz+wa...@chromium.org, horo+...@chromium.org, francisjp...@google.com, jophba...@chromium.org, spang...@chromium.org, sky+...@chromium.org, dtseng...@chromium.org, vinnypersky+...@google.com, roblia...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, chromiumme...@microsoft.com, shgar+aut...@google.com, armalhotra+a...@google.com, dfried...@chromium.org, ios-r...@chromium.org, siyua+aut...@chromium.org, ntp-dev...@chromium.org, odejesu...@chromium.org, chromium-a...@chromium.org, blink-re...@chromium.org, peilinwa...@google.com, omnibox-...@chromium.org, cros-system-ui-prod...@google.com, blink-rev...@chromium.org, blink-work...@chromium.org, estali...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, blink-revie...@chromium.org, mac-r...@chromium.org, shimazu+se...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, lwinston+watc...@google.com, mercer...@google.com, telemetr...@chromium.org, kinuko+ser...@chromium.org, media-cro...@chromium.org, chromeos-gfx-...@google.com, oshima...@chromium.org, trewin...@google.com, mattreyno...@chromium.org, ios-revie...@chromium.org, asvitkine...@chromium.org, jatapiaro+wat...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Khushal Sagar

Nan Lin removed yuzo+...@chromium.org from this change

Deleted Reviewers:
satisfied_requirement
unsatisfied_requirement
open
diffy

Nan Lin (Gerrit)

unread,
May 18, 2026, 12:37:18 PM (3 days ago) May 18
to trewin...@google.com, Ryan Kalla, srirama chandra sekhar, Hiroki Nakagawa, Chromium Metrics Reviews, Kevin Babbitt, (Julie)Jeongeun Kim, Peter Beverloo, android-bu...@system.gserviceaccount.com, SLSA Policy Verification Service, Khushal Sagar, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, eric.c...@apple.com, media-wi...@chromium.org, siashah+au...@chromium.org, mfoltz+wa...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, lucasrada...@google.com, johnche...@chromium.org, vaapi-...@chromium.org, osaul+aut...@google.com, ender...@chromium.org, dewitt...@chromium.org, abigailbk...@google.com, feature-me...@chromium.org, asvitki...@chromium.org, lens-chrome...@google.com, tracing...@chromium.org, chromotin...@chromium.org, dullweb...@chromium.org, marq+...@chromium.org, tommyw+w...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, christia...@chromium.org, stanfie...@google.com, mfoltz+wa...@chromium.org, horo+...@chromium.org, francisjp...@google.com, jophba...@chromium.org, spang...@chromium.org, sky+...@chromium.org, dtseng...@chromium.org, roblia...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, chromiumme...@microsoft.com, shgar+aut...@google.com, armalhotra+a...@google.com, dfried...@chromium.org, ios-r...@chromium.org, siyua+aut...@chromium.org, ntp-dev...@chromium.org, odejesu...@chromium.org, chromium-a...@chromium.org, blink-re...@chromium.org, peilinwa...@google.com, omnibox-...@chromium.org, cros-system-ui-prod...@google.com, blink-rev...@chromium.org, blink-work...@chromium.org, estali...@chromium.org, jdonnel...@chromium.org, extension...@chromium.org, blink-revie...@chromium.org, mac-r...@chromium.org, shimazu+se...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, lwinston+watc...@google.com, mercer...@google.com, telemetr...@chromium.org, kinuko+ser...@chromium.org, media-cro...@chromium.org, chromeos-gfx-...@google.com, oshima...@chromium.org, mattreyno...@chromium.org, ios-revie...@chromium.org, asvitkine...@chromium.org, jatapiaro+wat...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Khushal Sagar

Nan Lin removed trewin...@google.com from this change

Deleted Reviewers:
satisfied_requirement
unsatisfied_requirement
open
diffy

Nan Lin (Gerrit)

unread,
May 18, 2026, 12:39:27 PM (3 days ago) May 18
to siyua+aut...@chromium.org, ntp-dev...@chromium.org, spang...@chromium.org, roblia...@chromium.org, odejesu...@chromium.org, stanfie...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, tracing...@chromium.org, lizeb+watch...@chromium.org, wfh+...@chromium.org, mercer...@google.com, osaul+aut...@google.com, oshima...@chromium.org, lwinston+watc...@google.com, mfoltz+wa...@chromium.org, vaapi-...@chromium.org, sky+...@chromium.org, tommyw+w...@chromium.org, shgar+aut...@google.com, marq+...@chromium.org, msrame...@chromium.org, peilinwa...@google.com, servicewor...@chromium.org, siashah+au...@chromium.org, omnibox-...@chromium.org, media-wi...@chromium.org, telemetr...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, shimazu+se...@chromium.org
Attention needed from Khushal Sagar

Nan Lin has uploaded the change for review

Nan Lin removed siyua+aut...@chromium.org, ntp-dev...@chromium.org, spang...@chromium.org, roblia...@chromium.org, odejesu...@chromium.org, stanfie...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, tracing...@chromium.org, lizeb+watch...@chromium.org, wfh+...@chromium.org, mercer...@google.com, osaul+aut...@google.com, oshima...@chromium.org, lwinston+watc...@google.com, mfoltz+wa...@chromium.org, vaapi-...@chromium.org, sky+...@chromium.org, tommyw+w...@chromium.org, shgar+aut...@google.com, marq+...@chromium.org, msrame...@chromium.org, peilinwa...@google.com, servicewor...@chromium.org, siashah+au...@chromium.org, omnibox-...@chromium.org, media-wi...@chromium.org, telemetr...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org and shimazu+se...@chromium.org from reviewers of this change.

Commit message

Track password elements using the TrackedElement framework

This CL leverages the existing TrackedElement infrastructure to track
the coordinates of password elements. This is a prerequisite for
screenshot redaction via compositor, ensuring that sensitive fields can
be accurately masked in sync with the captured viewport bitmap.
Bug: 439921639
Change-Id: Ic715ed4b13fc59f27e9c7ae03b02db97e7ac444f

Change diff


Change information

Files:
  • M components/viz/common/surfaces/tracked_element_rects.h
  • M third_party/blink/renderer/core/dom/element.cc
  • M third_party/blink/renderer/core/dom/element.h
  • M third_party/blink/renderer/core/dom/element_test.cc
  • M third_party/blink/renderer/core/html/forms/html_input_element.cc
  • M third_party/blink/renderer/core/html/forms/html_input_element.h
  • M third_party/blink/renderer/core/html/forms/html_input_element_test.cc
  • M third_party/blink/renderer/core/html/forms/text_control_element.cc
  • M third_party/blink/renderer/core/html/forms/text_control_element.h
  • M third_party/blink/renderer/core/html/forms/text_control_element_test.cc
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: M
Delta: 11 files changed, 203 insertions(+), 4 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Khushal Sagar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages