Helmut Januschka (Gerrit)

unread,

Jun 6, 2024, 3:04:26 PMJun 6

to Helmut Januschka, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Nico Weber

Helmut Januschka added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Helmut Januschka . resolved

@tha...@google.com - here is another batch, its a slice of: https://chromium-review.googlesource.com/c/chromium/src/+/5546431

so in theorie, after this CL - the other one has around 20-30 files - and after that StringPiece is gone from base 🙌

stats after the 2 CLs

```
git grep -l base::StringPiece | awk -F "/" '{r[$1] +=1} END{for(x in r) { printf("%05d\t %s\n",r[x], x) }}'|sort

00001 base
00001 chrome
00001 PRESUBMIT.py
00001 styleguide
00001 ui
00002 net
00004 docs
00017 tools
00033 third_party
```
(most of them are "false-positve" as the grep is pretty open; but it's meant to, better than miss one)

todos after both:

some exotic places and a few "follow ups" of method name's that might make no sense any more (StringPieceTo....)

Open in Gerrit

Related details

Attention is currently required from:

Nico Weber

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Helmut Januschka (Gerrit)

unread,

Jun 6, 2024, 3:04:36 PMJun 6

to Helmut Januschka, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Nico Weber

Helmut Januschka voted Auto-Submit+1

Auto-Submit

+1

satisfied_requirement

unsatisfied_requirement

open

diffy

Nico Weber (Gerrit)

unread,

Jun 7, 2024, 12:04:55 PMJun 7

to Helmut Januschka, Nico Weber, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Helmut Januschka and Nico Weber

Nico Weber voted and added 3 comments

Votes added by Nico Weber

Code-Review	+1
Commit-Queue	+2

3 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Nico Weber . resolved

\o/

File mojo/core/test/test_support_impl.cc

Line 35, Patchset 3 (Latest): for (std::string_view component : base::SplitStringPiece(

Nico Weber . resolved

(unrelated, tsk tsk)

File mojo/public/cpp/bindings/README.md

Line 1650, Patchset 3 (Latest):

| `Foo?`                       | `std::optional<CppType>`, where `CppType` is the value type defined by the appropriate traits class specialization (e.g. `StructTraits`, `mojo::MapTraits`, etc.). This may be customized by the [typemapping](#Enabling-a-New-Type-Mapping).

Nico Weber . resolved

(also unrelated)

Open in Gerrit

Related details

Attention is currently required from:

Helmut Januschka
Nico Weber

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Helmut Januschka (Gerrit)

unread,

Jun 10, 2024, 5:49:56 AMJun 10

to Helmut Januschka, Ayu Ishii, K. Moon, Derek Schuff, Daniel Cheng, Nico Weber, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Ayu Ishii, Daniel Cheng, Derek Schuff, K. Moon, Nico Weber and Nico Weber

Helmut Januschka added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Helmut Januschka . resolved

hello reviewers!
thanks in advance, for your review-energy and patience!
this is one of the final CL's for the StringPiece removal!

the script is linked in the commit-message, and it has already been run/merged multiple times

anyway, let me know if you'd want me to address anything

Open in Gerrit

Related details

Attention is currently required from:

Ayu Ishii
Daniel Cheng
Derek Schuff
K. Moon
Nico Weber
Nico Weber

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nico Weber (Gerrit)

unread,

Jun 10, 2024, 9:39:26 AMJun 10

to Helmut Januschka, Nico Weber, Ayu Ishii, K. Moon, Derek Schuff, Daniel Cheng, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Ayu Ishii, Daniel Cheng, Derek Schuff, Helmut Januschka, K. Moon and Nico Weber

Nico Weber voted and added 1 comment

Votes added by Nico Weber

Commit-Queue	+2
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Nico Weber . resolved

Sorry, forgot to set oo+1

Open in Gerrit

Related details

Attention is currently required from:

Ayu Ishii
Daniel Cheng
Derek Schuff

Helmut Januschka
K. Moon
Nico Weber

satisfied_requirement

open

diffy

K. Moon (Gerrit)

unread,

Jun 10, 2024, 9:57:58 AMJun 10

to Helmut Januschka, Nico Weber, Ayu Ishii, Derek Schuff, Daniel Cheng, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Ayu Ishii, Daniel Cheng, Derek Schuff, Helmut Januschka and Nico Weber

K. Moon voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Ayu Ishii
Daniel Cheng
Derek Schuff
Helmut Januschka

Nico Weber

satisfied_requirement

open

diffy

Derek Schuff (Gerrit)

unread,

Jun 10, 2024, 12:53:52 PMJun 10

to Helmut Januschka, K. Moon, Nico Weber, Ayu Ishii, Daniel Cheng, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Ayu Ishii, Daniel Cheng, Helmut Januschka, K. Moon, Nico Weber and Nico Weber

Derek Schuff added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Derek Schuff . resolved

ppapi LGTM

Open in Gerrit

Related details

Attention is currently required from:

Ayu Ishii
Daniel Cheng

Helmut Januschka
K. Moon
Nico Weber

Nico Weber

satisfied_requirement

open

diffy

Derek Schuff (Gerrit)

unread,

Jun 10, 2024, 12:54:01 PMJun 10

to Helmut Januschka, K. Moon, Nico Weber, Ayu Ishii, Daniel Cheng, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Ayu Ishii, Daniel Cheng, Helmut Januschka, K. Moon, Nico Weber and Nico Weber

Derek Schuff voted Code-Review+1

Code-Review

+1

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jun 10, 2024, 4:05:23 PMJun 10

to Helmut Januschka, Daniel Cheng, Derek Schuff, K. Moon, Nico Weber, Ayu Ishii, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Ayu Ishii, Derek Schuff, K. Moon, Nico Weber and Nico Weber

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Daniel Cheng . resolved

LGTM for Mojo (I did not review //base)

Open in Gerrit

Related details

Attention is currently required from:

Ayu Ishii
Derek Schuff

K. Moon
Nico Weber
Nico Weber

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nico Weber (Gerrit)

unread,

Jun 11, 2024, 8:32:40 AMJun 11

to Helmut Januschka, Nico Weber, Daniel Cheng, Derek Schuff, K. Moon, Ayu Ishii, Nico Weber, Tricium, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Attention needed from Ayu Ishii, Derek Schuff, Helmut Januschka, K. Moon and Nico Weber

Nico Weber voted

Code-Review	+1
Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Ayu Ishii
Derek Schuff
Helmut Januschka
K. Moon
Nico Weber

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 11, 2024, 9:05:55 AMJun 11

to Helmut Januschka, Nico Weber, Daniel Cheng, Derek Schuff, K. Moon, Ayu Ishii, Nico Weber, Tricium, Zijie He, AyeAye, chromium...@chromium.org, Hans Wennborg, fuchsia...@chromium.org, fuzzin...@chromium.org, spang...@chromium.org, mac-r...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blundell+...@chromium.org, cblum...@chromium.org, danakj...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jshin...@chromium.org, pdf-r...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Convert base::StringPiece to std::string_view left overs.

The changes of this CL are made using the following script.
Script: https://issues.chromium.org/issues/40506050#comment343

Bug: 40506050

Change-Id: I768b3590141a698385319a615f2aefb71215ec84

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5601472

Reviewed-by: Nico Weber <tha...@chromium.org>

Auto-Submit: Helmut Januschka <hel...@januschka.com>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Nico Weber <tha...@chromium.org>

Owners-Override: Nico Weber <tha...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1313356}

Files:

M base/BUILD.gn
M base/debug/stack_trace_fuchsia.cc
M base/files/file_path.cc
M base/files/file_path.h
M base/files/file_path_unittest.cc
M base/files/file_util.h
M base/files/file_util_posix.cc
M base/files/file_util_win.cc
M base/files/important_file_writer.cc
M base/files/important_file_writer.h
M base/files/os_validation_win_unittest.cc
M base/functional/function_ref.h
M base/native_library.h
M base/native_library_fuchsia.cc
M base/native_library_ios.mm
M base/native_library_mac.mm
M base/native_library_posix.cc
M base/native_library_win.cc
M base/pickle.cc
M base/pickle.h
M base/pickle_unittest.cc
M base/scoped_add_feature_flags.cc
M base/scoped_add_feature_flags.h
M base/scoped_add_feature_flags_unittest.cc
M base/strings/abseil_string_number_conversions.cc
M base/strings/abseil_string_number_conversions.h
M base/strings/escape.cc
M base/strings/escape.h
M base/strings/escape_fuzzer.cc
M base/strings/pattern.cc
M base/strings/pattern.h
M base/strings/strcat.cc
M base/strings/strcat.h
M base/strings/string_number_conversions.cc
M base/strings/string_number_conversions_fuzzer.cc
M base/strings/string_number_conversions_internal.h
M base/strings/string_number_conversions_unittest.cc
M base/strings/sys_string_conversions.h
M base/strings/sys_string_conversions_apple.mm
M base/strings/sys_string_conversions_posix.cc
M base/strings/sys_string_conversions_win.cc
M base/strings/utf_offset_string_conversions.cc
M base/strings/utf_offset_string_conversions.h
M base/strings/utf_string_conversions.cc
M base/strings/utf_string_conversions.h
M base/strings/utf_string_conversions_fuzzer.cc
M base/token.cc
M base/token.h
M base/trace_event/traced_value_support_unittest.cc
M base/values.cc
M base/values.h
M base/values_unittest.cc
M chrome/browser/mac/code_sign_clone_manager.mm
M components/winhttp/network_fetcher.cc
M components/zucchini/disassembler_ztf_unittest.cc
M components/zucchini/main_utils.cc
M mojo/core/test/test_support_impl.cc
M mojo/public/cpp/base/string16_mojom_traits.h
M mojo/public/cpp/bindings/README.md
M mojo/public/cpp/bindings/string_traits_string_piece.h
M pdf/pdf_utils/dates.cc
M ppapi/shared_impl/private/ppb_x509_util_shared.cc
M ppapi/shared_impl/var.cc
M skia/ext/image_operations_bench.cc
M sql/statement.cc
M styleguide/c++/c++-features.md
M third_party/inspector_protocol/crdtp/chromium/protocol_traits.cc
M third_party/inspector_protocol/crdtp/chromium/protocol_traits.h
M third_party/zlib/google/zip_internal.cc
M third_party/zlib/google/zip_reader.cc
M third_party/zlib/google/zip_reader.h
M third_party/zlib/google/zip_reader_unittest.cc
M third_party/zlib/google/zip_unittest.cc
M third_party/zxcvbn-cpp/test/matching_unittest.cc
M tools/android/forwarder2/command.cc
M tools/android/forwarder2/device_forwarder_main.cc
M tools/android/forwarder2/host_forwarder_main.cc
M tools/android/io_benchmark/compression_benchmark.cc
M tools/android/memdump/memdump.cc
M tools/memory/partition_allocator/pa_tcache_inspect.cc

Change size: XL

Delta: 80 files changed, 594 insertions(+), 506 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Nico Weber, +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Convert base::StringPiece to std::string_view left overs. [chromium/src : main]

Helmut Januschka (Gerrit)

Helmut Januschka added 1 comment

Related details

Helmut Januschka (Gerrit)

Helmut Januschka voted Auto-Submit+1

Nico Weber (Gerrit)

Nico Weber voted and added 3 comments

Votes added by Nico Weber

3 comments

Related details

Helmut Januschka (Gerrit)

Helmut Januschka added 1 comment

Related details

Nico Weber (Gerrit)

Nico Weber voted and added 1 comment

Votes added by Nico Weber

1 comment

Related details

K. Moon (Gerrit)

K. Moon voted

Related details

Derek Schuff (Gerrit)

Derek Schuff added 1 comment

Related details

Derek Schuff (Gerrit)

Derek Schuff voted Code-Review+1

Daniel Cheng (Gerrit)

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

1 comment

Related details

Nico Weber (Gerrit)

Nico Weber voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information