tracing: pass file I/O opcodes to Perfetto [chromium/src : main]
0 views
Skip to first unread message
Jesse McKenna (Gerrit)
Dec 10, 2025, 11:55:53 PM (10 days ago) Dec 10
to Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jesse McKenna . resolved
This is a small improvement idea I had while I was working on the UI change. I'll wait for the prerequisite Perfetto PR (which modifies the protos) to land before merging this, but would you mind taking a look in the meantime? Thanks! : )
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Dec 11, 2025, 7:52:57 AM (10 days ago) Dec 11
to Jesse McKenna, AyeAye, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jesse McKenna
Etienne Pierre-Doray voted and added 2 comments![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
2 comments
Patchset-level comments
Etienne Pierre-Doray . resolved
LGTM, thanks!
File components/tracing/common/etw_consumer_win.cc
Line 284, Patchset 1 (Latest):
packet_data, opcode)) {Etienne Pierre-Doray . unresolved
Nit: we don't quite need to plumb opcode here because `header` is also passed, which contains EventDescriptor.Opcode.
Related details
Attention is currently required from:
- Jesse McKenna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Dec 11, 2025, 7:45:58 PM (9 days ago) Dec 11
to Chromium LUCI CQ, Etienne Pierre-Doray, AyeAye, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Jesse McKenna . resolved
Would you mind taking another look? The CR+1 was removed since the set of files changed. Thanks again!
File components/tracing/common/etw_consumer_win.cc
Nit: we don't quite need to plumb opcode here because `header` is also passed, which contains EventDescriptor.Opcode.
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Dec 12, 2025, 8:48:18 AM (9 days ago) Dec 12
to Jesse McKenna, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jesse McKenna
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jesse McKenna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Dec 12, 2025, 3:49:18 PM (8 days ago) Dec 12
to Etienne Pierre-Doray, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Jesse McKenna voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 12, 2025, 3:52:42 PM (8 days ago) Dec 12
to Jesse McKenna, Etienne Pierre-Doray, AyeAye, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
tracing: pass file I/O opcodes to Perfetto
This change passes an opcode field to Perfetto for file I/O events that
correspond to multiple opcodes.
Some file I/O ETW events correspond to multiple types (each with their
own opcode). For example, the FileIo_ReadWrite event can have opcode 67
(file read) or 68 (file write) [1]. Both have the same structure.
Knowing the opcode at the time of parsing will enable Perfetto to be
most descriptive (e.g., distinguishing reads from writes).
The full list of opcodes is here:
https://learn.microsoft.com/en-us/windows/win32/etw/fileio
The Perfetto change to add opcode to these protos is here:
https://github.com/google/perfetto/pull/4086
Bug: 400769108
Change-Id: Iefcbca641f77a16b35b14baab5b0746f5decc541
Commit-Queue: Jesse McKenna <jessem...@google.com>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558244}
Files:
- M components/tracing/common/etw_consumer_win.cc
- M components/tracing/common/etw_consumer_win_unittest.cc
Change size: M
Delta: 2 files changed, 38 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages