etw-stackwalk: track modules in tracing service [chromium/src : main]

0 views

Skip to first unread message

Sean Maher (Gerrit)

unread,

May 16, 2026, 9:19:21 PM (5 days ago) May 16

to Jesse McKenna, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Jesse McKenna

Sean Maher added 4 comments

File components/tracing/common/etw_consumer_win.h

Line 255, Patchset 1: // ⭐⭐⭐ TODO: filenames or full paths?

Sean Maher . unresolved

hmmm

File components/tracing/common/etw_consumer_win.cc

Line 443, Patchset 2 (Latest): static constexpr char kNoDebugId[] = "fffffffffffffffffffffffffffffff";

Sean Maher . unresolved

you should make it something cooler than _this_

Line 462, Patchset 2 (Latest): if (!interned_module.was_emitted) {

Sean Maher . unresolved

to avoid nesting you could do the same early return thing as in the place i commented 'naisu'

File components/tracing/common/etw_system_data_source_win.cc

Line 126, Patchset 2 (Latest): EVENT_TRACE_FLAG_IMAGE_LOAD; // ⭐⭐⭐ TODO: is this needed?

Sean Maher . unresolved

⭐⭐⭐

Open in Gerrit

Related details

Attention is currently required from:

Jesse McKenna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages