[WIP] Fix flakiness in TracingServiceInstantiate [chromium/src : main]
5 views
Skip to first unread message
Mikhail Khokhlov (Gerrit)
May 18, 2026, 6:32:14 AM (3 days ago) May 18
to Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Message from Mikhail Khokhlov![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
May 18, 2026, 6:57:57 AM (3 days ago) May 18
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mikhail Khokhlov
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 18, 2026, 9:16:17 AM (3 days ago) May 18
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
May 18, 2026, 10:18:25 AM (3 days ago) May 18
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Mikhail Khokhlov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 18, 2026, 10:21:41 AM (3 days ago) May 18
to Mikhail Khokhlov, Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix flakiness in TracingServiceInstantiate
Update TestTracingClient to wait for OnTracingEnabled instead of
RequestBufferUsage response. Using RequestBufferUsage as a signal
for tracing start was unreliable and could lead to race conditions
where DisableTracing is called before the service has fully enabled
tracing.
AI tools were used in generating the code.
Bug: 508373987
Change-Id: Ia3f77b1968848d9f9286b820c16ca91e0fd47aa4
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Mikhail Khokhlov <khok...@google.com>
Cr-Commit-Position: refs/heads/main@{#1632147}
Files:
- M services/tracing/tracing_service_unittest.cc
Change size: S
Delta: 1 file changed, 12 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages