[tracing] Make TraceLog test only [chromium/src : main]
1 view
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
May 25, 2026, 7:41:56 AMMay 25
to Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
May 26, 2026, 6:30:47 AMMay 26
to Etienne Pierre-Doray, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted and added 3 comments![]( "Open in Gerrit")
Votes added by Mikhail Khokhlov
| Code-Review | +1 |
3 comments
Patchset-level comments
Mikhail Khokhlov . resolved
Cool, thanks!
File services/tracing/public/cpp/perfetto/track_name_recorder.cc
Line 50, Patchset 6 (Latest):
base::GetUniqueIdForProcess().GetUnsafeValue());Mikhail Khokhlov . unresolved
Why not `perfetto::Platform::GetCurrentProcessId()`?
File services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
Line 389, Patchset 6 (Latest):
base::GetUniqueIdForProcess().GetUnsafeValue()) {Mikhail Khokhlov . unresolved
ditto
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 26, 2026, 4:10:56 PMMay 26
to Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dave Tapuska and mmenke
Etienne Pierre-Doray added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6:
Etienne Pierre-Doray . resolved
+dtapuska@ for content/ and t_p/b/renderer
+mmenke@ for net/log
File services/tracing/public/cpp/perfetto/track_name_recorder.cc
Why not `perfetto::Platform::GetCurrentProcessId()`?
Etienne Pierre-Doray
Ya that works.
File services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
Line 389, Patchset 6:
base::GetUniqueIdForProcess().GetUnsafeValue()) {Mikhail Khokhlov . resolved
Etienne Pierre-Dorayditto
Done
Related details
Attention is currently required from:
- Dave Tapuska
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
May 26, 2026, 4:20:27 PMMay 26
to Etienne Pierre-Doray, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and mmenke
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 26, 2026, 4:31:39 PMMay 26
to Nate Fischer, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Nate Fischer and mmenke
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Etienne Pierre-Doray . resolved
+ ntfschr@ for android_webview/lib/aw_main_delegate.cc
Related details
Attention is currently required from:
- Nate Fischer
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
May 26, 2026, 4:34:01 PMMay 26
to Etienne Pierre-Doray, Nate Fischer, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and Nate Fischer
mmenke voted and added 1 comment![]( "Open in Gerrit")
Votes added by mmenke
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
- Nate Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Fischer (Gerrit)
May 26, 2026, 4:47:06 PMMay 26
to Etienne Pierre-Doray, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Nate Fischer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nate Fischer
| Code-Review | +1 |
1 comment
Patchset-level comments
Nate Fischer . resolved
aw lgtm
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 27, 2026, 2:17:34 PMMay 27
to Rohit Rao, Vasilii Sukhanov, Tom Sepez, Nate Fischer, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Rohit Rao, Tom Sepez and Vasilii Sukhanov
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Etienne Pierre-Doray . resolved
+tsepez@ for ipc/
+vasilii@ for chrome/browser/
+rohitrao@ for ios/c/b/t/
Related details
Attention is currently required from:
- Rohit Rao
- Tom Sepez
- Vasilii Sukhanov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
May 27, 2026, 2:18:33 PMMay 27
to Etienne Pierre-Doray, Rohit Rao, Vasilii Sukhanov, Nate Fischer, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Rohit Rao and Vasilii Sukhanov
Tom Sepez voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rohit Rao
- Vasilii Sukhanov
Rohit Rao (Gerrit)
Jun 1, 2026, 11:38:21 AM (10 days ago) Jun 1
to Etienne Pierre-Doray, Rohit Rao, Tom Sepez, Vasilii Sukhanov, Nate Fischer, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and Vasilii Sukhanov
Rohit Rao voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rohit Rao
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
- Vasilii Sukhanov
Etienne Pierre-Doray (Gerrit)
Jun 1, 2026, 11:42:45 AM (10 days ago) Jun 1
to Avi Drissman, Rohit Rao, Tom Sepez, Nate Fischer, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Jun 1, 2026, 1:42:58 PM (10 days ago) Jun 1
to Etienne Pierre-Doray, Avi Drissman, Rohit Rao, Tom Sepez, Nate Fischer, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 1, 2026, 1:43:14 PM (10 days ago) Jun 1
to Avi Drissman, Rohit Rao, Tom Sepez, Nate Fischer, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Chromium LUCI CQ (Gerrit)
Jun 1, 2026, 4:07:05 PM (10 days ago) Jun 1
to Etienne Pierre-Doray, Avi Drissman, Rohit Rao, Tom Sepez, Nate Fischer, Dave Tapuska, Mikhail Khokhlov, Peter Beverloo, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, net-r...@chromium.org, ios-revie...@chromium.org, bnc+...@chromium.org, ios-r...@chromium.org, android-web...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Make TraceLog test only
The only reason TraceLog was instantiated in production was
to track "real pid". This CL uses existing GetUniqueIdForProcess()
instead, and removes all references to TraceLog in production.
Change-Id: I932da1fc10c062e6de3512864392aab8959dda85
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Reviewed-by: Tom Sepez <tse...@chromium.org>
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: mmenke <mme...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Reviewed-by: Nate Fischer <ntf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1639611}
Files:
- M android_webview/lib/aw_main_delegate.cc
- M base/trace_event/trace_event_impl.cc
- M base/trace_event/trace_event_unittest.cc
- M base/trace_event/trace_log.cc
- M base/trace_event/trace_log.h
- M base/trace_event/traced_value.cc
- M base/tracing/perfetto_platform.cc
- M base/tracing/perfetto_platform.h
- M chrome/browser/profiling_host/profiling_process_host.cc
- M components/power_metrics/system_power_monitor.h
- M content/browser/tracing/tracing_controller_impl.cc
- M content/renderer/render_thread_impl.h
- M content/shell/app/shell_main_delegate.cc
- M content/utility/utility_thread_impl.cc
- M content/zygote/zygote_linux.cc
- M ios/chrome/browser/tracing/ios_tracing_controller.mm
- M ipc/ipc_message.cc
- M net/log/trace_net_log_observer.h
- M net/log/trace_net_log_observer_unittest.cc
- M services/tracing/perfetto/consumer_host.cc
- M services/tracing/public/cpp/perfetto/perfetto_traced_process.cc
- M services/tracing/public/cpp/perfetto/track_name_recorder.cc
- M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
- M services/tracing/public/cpp/trace_startup.cc
- M services/tracing/public/cpp/trace_startup_config.cc
- M third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
- M third_party/blink/renderer/platform/instrumentation/tracing/trace_event.cc
- M third_party/blink/renderer/platform/instrumentation/tracing/trace_event.h
Change size: M
Delta: 28 files changed, 56 insertions(+), 73 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mikhail Khokhlov, +1 by Nate Fischer, +1 by Tom Sepez, +1 by Avi Drissman, +1 by Rohit Rao, +1 by mmenke, +1 by Dave Tapuska
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages