[tracing] Update SystemMetricsSampler's default sampling interval [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Feb 6, 2026, 8:28:32 AMFeb 6
to Etienne Bergeron, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Bergeron

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Bergeron
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I245e40a7d633621c941d65c9f102761ee8bec05a
Gerrit-Change-Number: 7549230
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Bergeron <etie...@chromium.org>
Gerrit-Attention: Etienne Bergeron <etie...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Feb 2026 13:28:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Bergeron (Gerrit)

unread,
Feb 10, 2026, 12:46:40 PMFeb 10
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Etienne Bergeron voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I245e40a7d633621c941d65c9f102761ee8bec05a
    Gerrit-Change-Number: 7549230
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Bergeron <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 17:46:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Feb 10, 2026, 12:46:48 PMFeb 10
    to Etienne Bergeron, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Etienne Pierre-Doray voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I245e40a7d633621c941d65c9f102761ee8bec05a
    Gerrit-Change-Number: 7549230
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Bergeron <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 17:46:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 10, 2026, 2:58:27 PMFeb 10
    to Etienne Pierre-Doray, Etienne Bergeron, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [tracing] Update SystemMetricsSampler's default sampling interval

    From 5s to 500ms.
    Change-Id: I245e40a7d633621c941d65c9f102761ee8bec05a
    Reviewed-by: Etienne Bergeron <etie...@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1582711}
    Files:
    • M services/tracing/public/cpp/system_metrics_sampler.cc
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Etienne Bergeron
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I245e40a7d633621c941d65c9f102761ee8bec05a
    Gerrit-Change-Number: 7549230
    Gerrit-PatchSet: 3
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Bergeron <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages