PartitionAlloc: Track wasted size from rounding for AlignedAlloc. [chromium/src : main]

3 views
Skip to first unread message

Stephen Nusko (Gerrit)

unread,
Jul 31, 2026, 1:31:34 AM (6 days ago) Jul 31
to Takashi Sakamoto, Chromium Metrics Reviews, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, lizeb...@chromium.org, bartek...@chromium.org, wfh+...@chromium.org, lize...@chromium.org, tracing...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com
Attention needed from Takashi Sakamoto

Stephen Nusko voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Sakamoto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia36785627b6fc9e4c51c92e31fa76b7ca271f3a9
Gerrit-Change-Number: 8152860
Gerrit-PatchSet: 2
Gerrit-Owner: Stephen Nusko <nus...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Takashi Sakamoto <ta...@google.com>
Gerrit-Comment-Date: Fri, 31 Jul 2026 05:31:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Takashi Sakamoto (Gerrit)

unread,
Aug 2, 2026, 10:11:47 PM (3 days ago) Aug 2
to Stephen Nusko, Chromium Metrics Reviews, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, lizeb...@chromium.org, bartek...@chromium.org, wfh+...@chromium.org, lize...@chromium.org, tracing...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com
Attention needed from Stephen Nusko

Takashi Sakamoto voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Stephen Nusko
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia36785627b6fc9e4c51c92e31fa76b7ca271f3a9
    Gerrit-Change-Number: 8152860
    Gerrit-PatchSet: 2
    Gerrit-Owner: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: Stephen Nusko <nus...@chromium.org>
    Gerrit-Comment-Date: Mon, 03 Aug 2026 02:11:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Stephen Nusko (Gerrit)

    unread,
    Aug 2, 2026, 10:16:22 PM (3 days ago) Aug 2
    to Takashi Sakamoto, Chromium Metrics Reviews, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, lizeb...@chromium.org, bartek...@chromium.org, wfh+...@chromium.org, lize...@chromium.org, tracing...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com

    Stephen Nusko voted and added 1 comment

    Votes added by Stephen Nusko

    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Stephen Nusko . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia36785627b6fc9e4c51c92e31fa76b7ca271f3a9
    Gerrit-Change-Number: 8152860
    Gerrit-PatchSet: 2
    Gerrit-Owner: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Comment-Date: Mon, 03 Aug 2026 02:15:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Stephen Nusko (Gerrit)

    unread,
    Aug 2, 2026, 10:17:48 PM (3 days ago) Aug 2
    to Takashi Sakamoto, Chromium Metrics Reviews, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, lizeb...@chromium.org, bartek...@chromium.org, wfh+...@chromium.org, lize...@chromium.org, tracing...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com
    Attention needed from Joe Mason

    Stephen Nusko voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joe Mason
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia36785627b6fc9e4c51c92e31fa76b7ca271f3a9
    Gerrit-Change-Number: 8152860
    Gerrit-PatchSet: 2
    Gerrit-Owner: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: Joe Mason <joenot...@google.com>
    Gerrit-Comment-Date: Mon, 03 Aug 2026 02:17:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joe Mason (Gerrit)

    unread,
    Aug 4, 2026, 3:20:50 PM (2 days ago) Aug 4
    to Stephen Nusko, Takashi Sakamoto, Chromium Metrics Reviews, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, lizeb...@chromium.org, bartek...@chromium.org, wfh+...@chromium.org, lize...@chromium.org, tracing...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com
    Attention needed from Stephen Nusko

    Joe Mason voted and added 1 comment

    Votes added by Joe Mason

    Code-Review+1

    1 comment

    File chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
    Line 1122, Patchset 2 (Latest): "aligned_alloc_wasted_size", 16 * kKiB);
    Joe Mason . unresolved

    Why is this multiplied by kKiB when the metric is in bytes?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Stephen Nusko
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia36785627b6fc9e4c51c92e31fa76b7ca271f3a9
    Gerrit-Change-Number: 8152860
    Gerrit-PatchSet: 2
    Gerrit-Owner: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: Stephen Nusko <nus...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Aug 2026 19:20:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages