[iOS Blink] Use content layer Perfetto tracing instead [chromium/src : main]
Xiaobin Cui (Gerrit)
Xiaobin Cui voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Etienne Pierre-Doray
- Justin Cohen
- Rohit Rao
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Related details
- Justin Cohen
- Rohit Rao
- Xiaobin Cui
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Rohit Rao added 1 comment![]( "Open in Gerrit")
Can you please file a new bug with more details about what is broken here?
I support changing the ifdef to USE_BLINK in StartupTracingController, that seems like a straightforward and correct change.
I'm less clear on why we need to stop using IOSTracingController, and more worried about having partially-divergent startup paths. Where exactly are we creating the startup controller when USE_BLINK is true? What specifically goes wrong when we create the IOSTracingController here?
Related details
- Justin Cohen
- Xiaobin Cui
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaobin Cui (Gerrit)
Xiaobin Cui added 1 comment![]( "Open in Gerrit")
Can you please file a new bug with more details about what is broken here?
I support changing the ifdef to USE_BLINK in StartupTracingController, that seems like a straightforward and correct change.
I'm less clear on why we need to stop using IOSTracingController, and more worried about having partially-divergent startup paths. Where exactly are we creating the startup controller when USE_BLINK is true? What specifically goes wrong when we create the IOSTracingController here?
@rohi...@chromium.org thank you!
Created a new bug crbug.com/511304747
After CL crrev.com/c/7700720 Blink-based Chromium on iOS will crash when launching. The reason is that Perfetto has been initialized twice.
One is from `content/app/content_main_runner_impl.cc`, another is from `iOS/chrome/browser/tracing/iOS_tracing_controller.mm`.
As for iOS Blink, Perfetto is already initialized by the content layer, and the Perfetto is initialized first in the content layer.
After adding `IOSTracingController`, Perfetto is initialized again in `IOSChromeMainParts::PreCreateThreads`.
We have to choose one of them, and no matter which one we choose, we will diverge from another. I tried to use initialization from `IOSTracingController` first, but it is more complicated and found that it will be simpler to reuse the initialization from the content layer.
And I also confirm that we can generate the tracing report correctly, and can see tracing data from render, GPU process and network process.
Related details
- Justin Cohen
- Rohit Rao
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaobin Cui (Gerrit)
Xiaobin Cui added 1 comment![]( "Open in Gerrit")
Xiaobin CuiCan you please file a new bug with more details about what is broken here?
I support changing the ifdef to USE_BLINK in StartupTracingController, that seems like a straightforward and correct change.
I'm less clear on why we need to stop using IOSTracingController, and more worried about having partially-divergent startup paths. Where exactly are we creating the startup controller when USE_BLINK is true? What specifically goes wrong when we create the IOSTracingController here?
@rohi...@chromium.org thank you!
Created a new bug crbug.com/511304747
After CL crrev.com/c/7700720 Blink-based Chromium on iOS will crash when launching. The reason is that Perfetto has been initialized twice.
One is from `content/app/content_main_runner_impl.cc`, another is from `iOS/chrome/browser/tracing/iOS_tracing_controller.mm`.
As for iOS Blink, Perfetto is already initialized by the content layer, and the Perfetto is initialized first in the content layer.
After adding `IOSTracingController`, Perfetto is initialized again in `IOSChromeMainParts::PreCreateThreads`.
We have to choose one of them, and no matter which one we choose, we will diverge from another. I tried to use initialization from `IOSTracingController` first, but it is more complicated and found that it will be simpler to reuse the initialization from the content layer.
And I also confirm that we can generate the tracing report correctly, and can see tracing data from render, GPU process and network process.
@rohi...@chromium.org gentle ping~ Thanks!
Rohit Rao (Gerrit)
Rohit Rao added 1 comment![]( "Open in Gerrit")
lg, will stamp once the trybots are happy
Related details
- Justin Cohen
- Xiaobin Cui
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rohit Rao (Gerrit)
Rohit Rao voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Justin Cohen
- Xiaobin Cui
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaobin Cui (Gerrit)
Xiaobin Cui voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
- Justin Cohen
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaobin Cui (Gerrit)
Xiaobin Cui added 2 comments![]( "Open in Gerrit")
Xiaobin CuiCan you please file a new bug with more details about what is broken here?
I support changing the ifdef to USE_BLINK in StartupTracingController, that seems like a straightforward and correct change.
I'm less clear on why we need to stop using IOSTracingController, and more worried about having partially-divergent startup paths. Where exactly are we creating the startup controller when USE_BLINK is true? What specifically goes wrong when we create the IOSTracingController here?
Xiaobin Cui@rohi...@chromium.org thank you!
Created a new bug crbug.com/511304747
After CL crrev.com/c/7700720 Blink-based Chromium on iOS will crash when launching. The reason is that Perfetto has been initialized twice.
One is from `content/app/content_main_runner_impl.cc`, another is from `iOS/chrome/browser/tracing/iOS_tracing_controller.mm`.
As for iOS Blink, Perfetto is already initialized by the content layer, and the Perfetto is initialized first in the content layer.
After adding `IOSTracingController`, Perfetto is initialized again in `IOSChromeMainParts::PreCreateThreads`.
We have to choose one of them, and no matter which one we choose, we will diverge from another. I tried to use initialization from `IOSTracingController` first, but it is more complicated and found that it will be simpler to reuse the initialization from the content layer.
And I also confirm that we can generate the tracing report correctly, and can see tracing data from render, GPU process and network process.
@rohi...@chromium.org gentle ping~ Thanks!
Done
tvOS-rel-fyi build error is not related.
Xiaobin Cui (Gerrit)
Xiaobin Cui voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[iOS Blink] Use content layer Perfetto tracing instead
Guard IOSTracingController behind !USE_BLINK so the content layer
handles Perfetto initialization normally for iOS Blink, matching other
platforms.
Also fix StartupTracingController to use kCustomBackend when USE_BLINK
is enabled, so startup traces are actually collected.
- M ios/chrome/browser/web/model/chrome_main_parts.mm
- M services/tracing/public/cpp/startup_tracing_controller.cc
Code-Review: +1 by Rohit Rao, +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |