[tracing] Remove TraceEventMetadataSource [chromium/src : main]
3 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Sep 5, 2025, 11:43:48 AM (4 days ago) Sep 5
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Sep 5, 2025, 12:05:44 PM (4 days ago) Sep 5
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mikhail Khokhlov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Sep 5, 2025, 12:11:39 PM (4 days ago) Sep 5
to Chromium IPC Reviews, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Chromium IPC Reviews
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Chromium IPC Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Sep 5, 2025, 12:16:59 PM (4 days ago) Sep 5
to Etienne Pierre-Doray, Chromium IPC Reviews, Ken Buchanan, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Ken Buchanan
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ke...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ke...@chromium.org
Reviewer source(s):
ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Ken Buchanan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Buchanan (Gerrit)
Sep 5, 2025, 12:42:12 PM (4 days ago) Sep 5
to Etienne Pierre-Doray, Chromium IPC Reviews, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Ken Buchanan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ken Buchanan
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Sep 5, 2025, 12:42:55 PM (4 days ago) Sep 5
to Ken Buchanan, Chromium IPC Reviews, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 5, 2025, 1:39:14 PM (4 days ago) Sep 5
to Etienne Pierre-Doray, Ken Buchanan, Chromium IPC Reviews, Mikhail Khokhlov, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Remove TraceEventMetadataSource
"org.chromium.trace_metadata" is no longer used anywhere,
this CL removes the data source and related code.
Change-Id: If35579ad75f0fb823596fbac94f3db4d17c24b2e
Reviewed-by: Ken Buchanan <ke...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Cr-Commit-Position: refs/heads/main@{#1511698}
Files:
- M content/browser/tracing/background_tracing_manager_impl.cc
- M content/browser/tracing/background_tracing_manager_impl.h
- M content/browser/tracing/traces_internals/traces_internals_handler.cc
- M content/browser/tracing/tracing_controller_browsertest.cc
- M content/browser/tracing/tracing_controller_impl.cc
- M content/browser/tracing/tracing_controller_impl.h
- M services/tracing/public/cpp/BUILD.gn
- M services/tracing/public/cpp/perfetto/perfetto_config_unittest.cc
- D services/tracing/public/cpp/perfetto/trace_event_metadata_source.cc
- D services/tracing/public/cpp/perfetto/trace_event_metadata_source.h
- M services/tracing/public/mojom/perfetto_service.mojom
Change size: L
Delta: 11 files changed, 6 insertions(+), 804 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ken Buchanan, +1 by Mikhail Khokhlov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages