Convert base::StringPiece to std::string_view final //base [chromium/src : main]

0 views
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Jun 12, 2024, 4:05:04 PMJun 12
to Helmut Januschka, Nico Weber, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Nico Weber

Helmut Januschka voted and added 1 comment

Votes added by Helmut Januschka

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Helmut Januschka . resolved

@tha...@chromium.org - here we go last batch. after only a few mini_chromium/crashpad/tools... will be left (mini_chromium is already prepared/WIP -> https://crrev.com/c/5523573)


```
git grep -l base::StringPiece | awk -F "/" '{r[$1] +=1} END{for(x in r) { printf("%05d\t %s\n",r[x], x) }}'|sort
00001 chrome
00001 PRESUBMIT.py
00001 styleguide
00001 ui
00002 net
00004 docs
00005 base
00017 tools
00033 third_party
```


close to closing bug 🥳

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 8
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Jun 2024 20:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 17, 2024, 10:01:07 AMJun 17
to Helmut Januschka, Nico Weber, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Nico Weber

Helmut Januschka added 1 comment

Patchset-level comments
Helmut Januschka . resolved

ping

Gerrit-Comment-Date: Mon, 17 Jun 2024 14:00:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
Jun 17, 2024, 1:44:51 PM (14 days ago) Jun 17
to Helmut Januschka, Nico Weber, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka

Nico Weber voted and added 4 comments

Votes added by Nico Weber

Code-Review+1

4 comments

Patchset-level comments
Nico Weber . resolved

LG. First comment is something you might want to address before hitting cq+2. The other two are for the future.

File base/strings/string_piece.h
Line 5, Patchset 8 (Latest):// This header is deprecated. `std::string_view` is now `std::string_view`.
Nico Weber . resolved

🤨

Probably want to keep the LHS here and then remove this file in a follow-up instead.

File base/strings/string_piece_nocompile.nc
Line 20, Patchset 8 (Latest): [[maybe_unused]] std::string_view piece = f(); // expected-error {{object backing the pointer will be destroyed at the end of the full-expression}}
Nico Weber . resolved

Not sure if having a .nc test for a libc++ type is useful. Maybe we should toss this too now that this is done?

File base/strings/string_piece_unittest.cc
Line 572, Patchset 8 (Latest): [[maybe_unused]] std::string_view b(s1);
Nico Weber . resolved

Similar to the .nc comment: Do we still need this unittest file? (If so, we should probably rename it? Not in this CL though.)

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 8
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Mon, 17 Jun 2024 17:44:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 18, 2024, 2:43:56 AM (13 days ago) Jun 18
to Helmut Januschka, Nico Weber, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org

Helmut Januschka added 4 comments

Patchset-level comments
Helmut Januschka . resolved

thanks for your feedback, removed the not-needed anymore tests.
not sure if i fully understand the first comment, about the string_piece.h.

ready for submit?

File base/strings/string_piece.h
Line 5, Patchset 8 (Latest):// This header is deprecated. `std::string_view` is now `std::string_view`.
Nico Weber . resolved

🤨

Probably want to keep the LHS here and then remove this file in a follow-up instead.

Helmut Januschka

changed the comment, will remove the file in a follow up - once mini_chromium and tools are done

File base/strings/string_piece_nocompile.nc
Line 20, Patchset 8 (Latest): [[maybe_unused]] std::string_view piece = f(); // expected-error {{object backing the pointer will be destroyed at the end of the full-expression}}
Nico Weber . resolved

Not sure if having a .nc test for a libc++ type is useful. Maybe we should toss this too now that this is done?

Helmut Januschka

TIL about no-compile tests, thank you, removed the case.

File base/strings/string_piece_unittest.cc
Line 572, Patchset 8 (Latest): [[maybe_unused]] std::string_view b(s1);
Nico Weber . resolved

Similar to the .nc comment: Do we still need this unittest file? (If so, we should probably rename it? Not in this CL though.)

Helmut Januschka

removed

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 8
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Tue, 18 Jun 2024 06:43:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Weber <tha...@chromium.org>
satisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
Jun 18, 2024, 8:48:10 AM (13 days ago) Jun 18
to Helmut Januschka, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka

Nico Weber voted and added 1 comment

Votes added by Nico Weber

Code-Review+1
Commit-Queue+2

1 comment

File base/strings/string_piece.h
Line 5, Patchset 11 (Latest):// This header is deprecated. use `std::string_view` and <string_view> instead.
Nico Weber . resolved

very very nit: upper case after a period

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 11
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Tue, 18 Jun 2024 12:47:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 18, 2024, 11:56:56 AM (13 days ago) Jun 18
to Helmut Januschka, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Nico Weber

Helmut Januschka voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 12
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Jun 2024 15:56:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 18, 2024, 12:36:46 PM (13 days ago) Jun 18
to Helmut Januschka, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Gerrit-Comment-Date: Tue, 18 Jun 2024 16:36:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 18, 2024, 1:45:52 PM (13 days ago) Jun 18
to Helmut Januschka, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Gerrit-Comment-Date: Tue, 18 Jun 2024 17:45:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 18, 2024, 4:26:13 PM (13 days ago) Jun 18
to Helmut Januschka, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Nico Weber

Helmut Januschka voted and added 1 comment

Votes added by Helmut Januschka

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Helmut Januschka . resolved

@tha...@chromium.org - this seems to fail on some non-public code.
on slack it was mentioned that it most likely be of a transitive include (in non-public chromeos).

as i cannot see any build-messages, could you be so kind and take a look? i am happy and ready to change whatever is needed.

Gerrit-Comment-Date: Tue, 18 Jun 2024 20:25:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 20, 2024, 4:23:28 PM (11 days ago) Jun 20
to Helmut Januschka, Peter Kasting, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Nico Weber and Peter Kasting

Helmut Januschka added 1 comment

Patchset-level comments
Helmut Januschka . resolved

@pkas...@chromium.org could you help me unblock this? seems to be some non-public code transitively relying on string_piece.h include. i cannot see the code nor the error message.

happy to address what ever is needed, this is the last big CL - for stringpiece removal, after this, only a few minors and a lot of followups (like method names; GetStringPiece) 🙌

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
  • Peter Kasting
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 12
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Peter Kasting <pkas...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Peter Kasting <pkas...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Thu, 20 Jun 2024 20:23:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 24, 2024, 5:14:48 PM (7 days ago) Jun 24
to Helmut Januschka, Lei Zhang, Peter Kasting, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka, Nico Weber and Peter Kasting

Lei Zhang added 1 comment

Patchset-level comments
Lei Zhang . resolved

I'll help take a look. Note that there are still some base::StringPiece usage in the rest of the Chromium code base.

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Nico Weber
  • Peter Kasting
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 12
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Peter Kasting <pkas...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Peter Kasting <pkas...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Mon, 24 Jun 2024 21:14:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 24, 2024, 5:23:09 PM (7 days ago) Jun 24
to Helmut Januschka, Lei Zhang, Peter Kasting, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka, Nico Weber and Peter Kasting

Lei Zhang added 1 comment

Patchset-level comments
Lei Zhang . resolved

I'll help take a look. Note that there are still some base::StringPiece usage in the rest of the Chromium code base.

Lei Zhang

I sent out a CL in a Google-internal repo that I have never touched. We'll see how that goes.

You may be able to make progress by splitting the base/strings/string_util* part into a separate CL and landing that first?

Gerrit-Comment-Date: Mon, 24 Jun 2024 21:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 25, 2024, 2:26:08 PM (6 days ago) Jun 25
to Helmut Januschka, Lei Zhang, Peter Kasting, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka, Nico Weber and Peter Kasting

Lei Zhang added 1 comment

Patchset-level comments
Lei Zhang . resolved

I'll help take a look. Note that there are still some base::StringPiece usage in the rest of the Chromium code base.

Lei Zhang

I sent out a CL in a Google-internal repo that I have never touched. We'll see how that goes.

You may be able to make progress by splitting the base/strings/string_util* part into a separate CL and landing that first?

Lei Zhang

Landed the Google-internal CL. It may need a DEPS roll. I also have https://crrev.com/c/5653995 in flight.

Gerrit-Comment-Date: Tue, 25 Jun 2024 18:25:56 +0000
satisfied_requirement
open
diffy

Peter Kasting (Gerrit)

unread,
Jun 25, 2024, 3:46:10 PM (6 days ago) Jun 25
to Helmut Januschka, Lei Zhang, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka, Lei Zhang and Nico Weber

Peter Kasting added 1 comment

Patchset-level comments
Lei Zhang . resolved

I'll help take a look. Note that there are still some base::StringPiece usage in the rest of the Chromium code base.

Lei Zhang

I sent out a CL in a Google-internal repo that I have never touched. We'll see how that goes.

You may be able to make progress by splitting the base/strings/string_util* part into a separate CL and landing that first?

Lei Zhang

Landed the Google-internal CL. It may need a DEPS roll. I also have https://crrev.com/c/5653995 in flight.

Peter Kasting

Based on where the build error was, yeah we'll need a DEPS roll.

If we want to get as much of this in as quickly as possible, I might leave the string_piece.h #include in string_split.h, with a TODO to remove it?

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Lei Zhang
  • Nico Weber
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 19:46:00 +0000
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 25, 2024, 3:57:57 PM (6 days ago) Jun 25
to Helmut Januschka, Lei Zhang, Peter Kasting, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Lei Zhang, Nico Weber and Peter Kasting

Helmut Januschka voted and added 1 comment

Votes added by Helmut Januschka

Auto-Submit+1

1 comment

Patchset-level comments
Lei Zhang . resolved

I'll help take a look. Note that there are still some base::StringPiece usage in the rest of the Chromium code base.

Lei Zhang

I sent out a CL in a Google-internal repo that I have never touched. We'll see how that goes.

You may be able to make progress by splitting the base/strings/string_util* part into a separate CL and landing that first?

Lei Zhang

Landed the Google-internal CL. It may need a DEPS roll. I also have https://crrev.com/c/5653995 in flight.

Peter Kasting

Based on where the build error was, yeah we'll need a DEPS roll.

If we want to get as much of this in as quickly as possible, I might leave the string_piece.h #include in string_split.h, with a TODO to remove it?

Helmut Januschka

thank you both! uploaded a PS - with the revert of #include

@the...@chromium.org - i know some places still not done. but most of them are due to the fact that mini_chromium needs to change.

```
git grep -l base::StringPiece | awk -F "/" '{r[$1"/"$2] +=1} END{for(x in r) { printf("%05d\t %s\n",r[x], x) }}'|sort
00001 base/json
00001 chrome/updater
00001 docs/debugging_with_crash_keys.md
00001 docs/security
00001 docs/speed
00001 docs/threading_and_tasks_testing.md
00001 PRESUBMIT.py/
00001 services/screen_ai
00001 styleguide/c++
00001 third_party/blink
00001 third_party/leveldatabase
00001 third_party/liburlpattern
00001 third_party/rust
00001 tools/ipc_fuzzer
00001 tools/metrics
00001 tools/win
00001 ui/ozone
00002 net/device_bound_sessions
00002 tools/mac
00003 third_party/hunspell
00003 third_party/webrtc_overrides
00003 third_party/zxcvbn-cpp
00003 tools/clang
00009 tools/json_schema_compiler
00020 third_party/crashpad
````

already started the work on mini_chromium: https://crrev.com/c/5523573
(was mentioned to first get //base done in chromium itself)

once min_chromium is done, the crashpad's matches can be tackled.

with a few "false-positiv" matches of the `grep` - i think after that we are almost there.


what a ride! 🤣

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
  • Nico Weber
  • Peter Kasting
Gerrit-Attention: Peter Kasting <pkas...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 19:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Peter Kasting <pkas...@chromium.org>
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 25, 2024, 3:59:23 PM (6 days ago) Jun 25
to Helmut Januschka, Lei Zhang, Peter Kasting, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka, Nico Weber and Peter Kasting

Lei Zhang added 1 comment

Patchset-level comments
Lei Zhang

Here is the DEPS roll here: https://crrev.com/c/5654679

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Nico Weber
  • Peter Kasting
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 13
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Peter Kasting <pkas...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Peter Kasting <pkas...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 19:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Kasting <pkas...@chromium.org>
Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 25, 2024, 4:07:46 PM (6 days ago) Jun 25
to Helmut Januschka, Lei Zhang, Peter Kasting, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Lei Zhang, Nico Weber and Peter Kasting

Helmut Januschka voted and added 1 comment

Votes added by Helmut Januschka

Auto-Submit+1

1 comment

Patchset-level comments
Helmut Januschka

not 100% sure about DEPS - if the above CL is landed, i should be able to rebase this one - and it should pass? would'nt it make sense to wait for this? or does it take longer for the DEPS cl to land?

rebasing is pretty straight forward - not sure what is better

 //TODO vs "just wait a bit"
 
 (sorry if that might be a stupid question)
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
  • Nico Weber
  • Peter Kasting
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 20:07:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 25, 2024, 4:11:13 PM (6 days ago) Jun 25
to Helmut Januschka, Lei Zhang, Peter Kasting, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka, Nico Weber and Peter Kasting

Lei Zhang added 1 comment

Patchset-level comments
Lei Zhang

You can chain this CL to my CL and then run try jobs. I don't know if there are any other issues in the Chrome OS build.

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Nico Weber
  • Peter Kasting
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 20:11:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 25, 2024, 5:17:37 PM (6 days ago) Jun 25
to Helmut Januschka, Lei Zhang, Peter Kasting, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Patchset-level comments
Lei Zhang

Or just sync your checkout, as that CL landed.

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Nico Weber
  • Peter Kasting
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 15
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Peter Kasting <pkas...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Peter Kasting <pkas...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 21:17:24 +0000
satisfied_requirement
open
diffy

Peter Kasting (Gerrit)

unread,
Jun 25, 2024, 5:39:42 PM (6 days ago) Jun 25
to Helmut Januschka, Lei Zhang, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Helmut Januschka, Lei Zhang and Nico Weber

Peter Kasting voted and added 1 comment

Votes added by Peter Kasting

Code-Review+1

1 comment

Patchset-level comments
Peter Kasting

(For future reference: if you chain a CL atop another, then run tryjobs, the tryjobs will include all CLs in the chain up to the CL in question. So the currently-running tryjobs should include Lei's change.)

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Lei Zhang
  • Nico Weber
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 21:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 26, 2024, 12:56:41 AM (5 days ago) Jun 26
to Helmut Januschka, Peter Kasting, Lei Zhang, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Lei Zhang and Nico Weber

Helmut Januschka voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
  • Nico Weber
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Jun 2024 04:56:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 26, 2024, 12:58:22 AM (5 days ago) Jun 26
to Helmut Januschka, Peter Kasting, Lei Zhang, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org
Attention needed from Lei Zhang and Nico Weber

Helmut Januschka voted and added 1 comment

Votes added by Helmut Januschka

Auto-Submit+1

1 comment

Patchset-level comments
Helmut Januschka

thank you. chaining feels like magic

Gerrit-Comment-Date: Wed, 26 Jun 2024 04:58:06 +0000
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 26, 2024, 1:31:21 AM (5 days ago) Jun 26
to Helmut Januschka, Peter Kasting, Lei Zhang, Nico Weber, Chromium Metrics Reviews, AyeAye, Tricium, chromium...@chromium.org, Andrew Rayskiy, Hans Wennborg, Permissions Reviews, Simon Hangl, Zijie He, dullweber+watch...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, olesiamarukhno+wat...@google.com, tommasin+watch-...@chromium.org, alimariam+watch...@google.com, ios-r...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chasej...@chromium.org, chromiumme...@microsoft.com, danakj...@chromium.org, dominickn+wat...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, hayato...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jbrom...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, mfoltz...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Convert base::StringPiece to std::string_view final //base

The changes of this CL are made using the following script.
Script: https://issues.chromium.org/issues/40506050#comment343

Bug: 40506050
Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Reviewed-by: Nico Weber <tha...@chromium.org>
Reviewed-by: Peter Kasting <pkas...@chromium.org>
Commit-Queue: Helmut Januschka <hel...@januschka.com>
Auto-Submit: Helmut Januschka <hel...@januschka.com>
Cr-Commit-Position: refs/heads/main@{#1319573}
Files:
  • M base/BUILD.gn
  • M base/files/file_util.cc
  • M base/strings/string_piece.h
  • D base/strings/string_piece_nocompile.nc
  • M base/strings/string_piece_rust.h
  • M base/strings/string_piece_rust_unittest.cc
  • D base/strings/string_piece_unittest.cc
  • M base/strings/string_split.cc
  • M base/strings/string_split.h
  • M base/strings/string_split_internal.h
  • M base/strings/string_split_unittest.cc
  • M base/strings/string_split_win.cc
  • M base/strings/string_split_win.h
  • M base/strings/string_tokenizer.h
  • M base/strings/string_util.cc
  • M base/strings/string_util.h
  • M base/strings/string_util_impl_helpers.h
  • M base/strings/string_util_unittest.cc
  • M base/strings/string_util_win.cc
  • M base/strings/string_util_win.h
  • M base/system/sys_info_unittest.cc
  • M base/unguessable_token.cc
  • M base/unguessable_token.h
Change size: XL
Delta: 23 files changed, 342 insertions(+), 1270 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nico Weber, +1 by Peter Kasting
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf16c1f1549d0e66f5b513296c73bd2d1c60a7b7
Gerrit-Change-Number: 5546431
Gerrit-PatchSet: 16
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Peter Kasting <pkas...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages