Allow list new fields introduced in https://crrev.com/c/7223770 [chromium/src : main]

0 views
Skip to first unread message

Petr Cermak (Gerrit)

unread,
Dec 10, 2025, 6:03:16 AM (11 days ago) Dec 10
to Petr Cermak, Kartar Singh, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Kartar Singh

Petr Cermak voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kartar Singh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I49be77e12ca451a0890b788c75e7ef17e7f44dfd
Gerrit-Change-Number: 7246012
Gerrit-PatchSet: 1
Gerrit-Owner: Petr Cermak <petrc...@chromium.org>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
Gerrit-Attention: Kartar Singh <karta...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 11:03:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kartar Singh (Gerrit)

unread,
Dec 10, 2025, 6:08:47 AM (11 days ago) Dec 10
to Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Petr Cermak

Kartar Singh voted and added 1 comment

Votes added by Kartar Singh

Code-Review+1

1 comment

File base/tracing/protos/chrome_track_event.proto
Line 938, Patchset 1 (Latest): optional float abs_total_raw_delta_pixels = 3;
Kartar Singh . unresolved

Do we want to "delete" these fields as well?
https://protobuf.dev/programming-guides/proto3/#deleting

Open in Gerrit

Related details

Attention is currently required from:
  • Petr Cermak
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I49be77e12ca451a0890b788c75e7ef17e7f44dfd
    Gerrit-Change-Number: 7246012
    Gerrit-PatchSet: 1
    Gerrit-Owner: Petr Cermak <petrc...@chromium.org>
    Gerrit-Reviewer: Kartar Singh <karta...@google.com>
    Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
    Gerrit-Attention: Petr Cermak <petrc...@chromium.org>
    Gerrit-Comment-Date: Wed, 10 Dec 2025 11:08:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Petr Cermak (Gerrit)

    unread,
    Dec 10, 2025, 6:17:27 AM (11 days ago) Dec 10
    to Petr Cermak, Kartar Singh, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Petr Cermak voted and added 1 comment

    Votes added by Petr Cermak

    Commit-Queue+2

    1 comment

    File base/tracing/protos/chrome_track_event.proto
    Line 938, Patchset 1 (Latest): optional float abs_total_raw_delta_pixels = 3;
    Kartar Singh . resolved

    Do we want to "delete" these fields as well?
    https://protobuf.dev/programming-guides/proto3/#deleting

    Petr Cermak

    I think the answer is _no_ because that might prevent us from querying the fields in older traces. Even if so, let's do it in a separate CL (because there's no urgency for cherry-picking the deletion). In fact, I think a more interesting question is whether we can un-allowlist deprecated fields.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I49be77e12ca451a0890b788c75e7ef17e7f44dfd
      Gerrit-Change-Number: 7246012
      Gerrit-PatchSet: 1
      Gerrit-Owner: Petr Cermak <petrc...@chromium.org>
      Gerrit-Reviewer: Kartar Singh <karta...@google.com>
      Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
      Gerrit-Comment-Date: Wed, 10 Dec 2025 11:17:12 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Kartar Singh <karta...@google.com>
      satisfied_requirement
      open
      diffy

      Kartar Singh (Gerrit)

      unread,
      Dec 10, 2025, 6:23:29 AM (11 days ago) Dec 10
      to Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
      Attention needed from Petr Cermak

      Kartar Singh added 1 comment

      File base/tracing/protos/chrome_track_event.proto
      Line 938, Patchset 1 (Latest): optional float abs_total_raw_delta_pixels = 3;
      Kartar Singh . resolved

      Do we want to "delete" these fields as well?
      https://protobuf.dev/programming-guides/proto3/#deleting

      Petr Cermak

      I think the answer is _no_ because that might prevent us from querying the fields in older traces. Even if so, let's do it in a separate CL (because there's no urgency for cherry-picking the deletion). In fact, I think a more interesting question is whether we can un-allowlist deprecated fields.

      Kartar Singh

      I think the answer is no because that might prevent us from querying the fields in older traces. Even if so, let's do it in a separate CL (because there's no urgency for cherry-picking the deletion).

      Makes sense.

      In fact, I think a more interesting question is whether we can un-allowlist deprecated fields.

      From what I understand `deprecated` doesn't do much more than adding some warnings for new uses of field. Not sure what the concern might be when marking deprecated fields as reserved.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Petr Cermak
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I49be77e12ca451a0890b788c75e7ef17e7f44dfd
      Gerrit-Change-Number: 7246012
      Gerrit-PatchSet: 1
      Gerrit-Owner: Petr Cermak <petrc...@chromium.org>
      Gerrit-Reviewer: Kartar Singh <karta...@google.com>
      Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
      Gerrit-Attention: Petr Cermak <petrc...@chromium.org>
      Gerrit-Comment-Date: Wed, 10 Dec 2025 11:22:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Petr Cermak <petrc...@chromium.org>
      Comment-In-Reply-To: Kartar Singh <karta...@google.com>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Dec 10, 2025, 7:10:56 AM (11 days ago) Dec 10
      to Petr Cermak, Kartar Singh, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Allow list new fields introduced in https://crrev.com/c/7223770

      Also bring back comments for deprecated fields.
      Bug: b:456180776
      Change-Id: I49be77e12ca451a0890b788c75e7ef17e7f44dfd
      Reviewed-by: Kartar Singh <karta...@google.com>
      Auto-Submit: Petr Cermak <petrc...@chromium.org>
      Commit-Queue: Petr Cermak <petrc...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1556656}
      Files:
      • M base/tracing/protos/chrome_track_event.proto
      • M services/tracing/perfetto/privacy_filtered_fields-inl.h
      Change size: S
      Delta: 2 files changed, 41 insertions(+), 4 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Kartar Singh
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I49be77e12ca451a0890b788c75e7ef17e7f44dfd
      Gerrit-Change-Number: 7246012
      Gerrit-PatchSet: 2
      Gerrit-Owner: Petr Cermak <petrc...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kartar Singh <karta...@google.com>
      Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages