[iOS tracing] Add chrome://tracing WebUI [chromium/src : main]

0 views
Skip to first unread message

Justin Cohen (Gerrit)

unread,
Apr 22, 2026, 9:52:33 PM (4 days ago) Apr 22
to Mark Cogan, Justin Novosad, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Justin Novosad and Mark Cogan

Justin Cohen added 1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Justin Cohen . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Novosad
  • Mark Cogan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72ae795a2293834e3bdae151ddd3adfc19504731
Gerrit-Change-Number: 7751575
Gerrit-PatchSet: 12
Gerrit-Owner: Justin Cohen <justi...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@google.com>
Gerrit-Reviewer: Mark Cogan <ma...@chromium.org>
Gerrit-CC: Justin Novosad <ju...@chromium.org>
Gerrit-Attention: Justin Novosad <ju...@chromium.org>
Gerrit-Attention: Mark Cogan <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Apr 2026 01:52:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Cohen (Gerrit)

unread,
Apr 23, 2026, 2:45:58 PM (3 days ago) Apr 23
to Daniel White, Justin Novosad, Justin Novosad, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Daniel White, Justin Novosad and Justin Novosad

Justin Cohen added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel White
  • Justin Novosad
  • Justin Novosad
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I72ae795a2293834e3bdae151ddd3adfc19504731
Gerrit-Change-Number: 7751575
Gerrit-PatchSet: 16
Gerrit-Owner: Justin Cohen <justi...@google.com>
Gerrit-Reviewer: Daniel White <daniel...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@google.com>
Gerrit-Reviewer: Justin Novosad <ju...@google.com>
Gerrit-Attention: Daniel White <daniel...@google.com>
Gerrit-Attention: Justin Novosad <ju...@google.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 18:45:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel White (Gerrit)

unread,
Apr 23, 2026, 3:31:06 PM (3 days ago) Apr 23
to Justin Cohen, Justin Novosad, Justin Novosad, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Justin Cohen, Justin Novosad and Justin Novosad

Daniel White voted and added 1 comment

Votes added by Daniel White

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 17 (Latest):
Daniel White . resolved

Code looks good. I went ahead and built this locally and everything is working. LGTM.

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
  • Justin Novosad
  • Justin Novosad
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I72ae795a2293834e3bdae151ddd3adfc19504731
    Gerrit-Change-Number: 7751575
    Gerrit-PatchSet: 17
    Gerrit-Owner: Justin Cohen <justi...@google.com>
    Gerrit-Reviewer: Daniel White <daniel...@google.com>
    Gerrit-Reviewer: Justin Cohen <justi...@google.com>
    Gerrit-Reviewer: Justin Novosad <ju...@google.com>
    Gerrit-CC: Justin Novosad <ju...@chromium.org>
    Gerrit-Attention: Justin Novosad <ju...@chromium.org>
    Gerrit-Attention: Justin Cohen <justi...@google.com>
    Gerrit-Attention: Justin Novosad <ju...@google.com>
    Gerrit-Comment-Date: Thu, 23 Apr 2026 19:30:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Justin Cohen (Gerrit)

    unread,
    Apr 23, 2026, 8:44:35 PM (3 days ago) Apr 23
    to Rohit Rao, Daniel White, Justin Novosad, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Justin Novosad and Rohit Rao

    Justin Cohen voted and added 1 comment

    Votes added by Justin Cohen

    Auto-Submit+1
    Commit-Queue+1

    1 comment

    Patchset-level comments
    Justin Cohen . resolved

    Over to rohitrao for OWNERS

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Justin Novosad
    • Rohit Rao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I72ae795a2293834e3bdae151ddd3adfc19504731
    Gerrit-Change-Number: 7751575
    Gerrit-PatchSet: 17
    Gerrit-Owner: Justin Cohen <justi...@google.com>
    Gerrit-Reviewer: Daniel White <daniel...@google.com>
    Gerrit-Reviewer: Justin Cohen <justi...@google.com>
    Gerrit-Reviewer: Rohit Rao <rohi...@chromium.org>
    Gerrit-Attention: Rohit Rao <rohi...@chromium.org>
    Gerrit-Comment-Date: Fri, 24 Apr 2026 00:44:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rohit Rao (Gerrit)

    unread,
    Apr 23, 2026, 10:12:03 PM (3 days ago) Apr 23
    to Justin Cohen, Rohit Rao, Daniel White, Justin Novosad, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Justin Cohen and Justin Novosad

    Rohit Rao voted and added 1 comment

    Votes added by Rohit Rao

    Code-Review+1

    1 comment

    File ios/chrome/browser/webui/ui_bundled/tracing/tracing_ui.mm
    Line 44, Patchset 18 (Latest): return cache_dir.Append("manual_trace.perfetto-trace");
    Rohit Rao . unresolved

    Ok if we overwrite the previous trace?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Justin Cohen
    • Justin Novosad
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I72ae795a2293834e3bdae151ddd3adfc19504731
    Gerrit-Change-Number: 7751575
    Gerrit-PatchSet: 18
    Gerrit-Owner: Justin Cohen <justi...@google.com>
    Gerrit-Reviewer: Daniel White <daniel...@google.com>
    Gerrit-Reviewer: Justin Cohen <justi...@google.com>
    Gerrit-Reviewer: Rohit Rao <rohi...@chromium.org>
    Gerrit-CC: Justin Novosad <ju...@chromium.org>
    Gerrit-Attention: Justin Novosad <ju...@chromium.org>
    Gerrit-Attention: Justin Cohen <justi...@google.com>
    Gerrit-Comment-Date: Fri, 24 Apr 2026 02:11:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages