[tracing] Fix wrong sql statement in TraceReportDatabase [chromium/src : main]

1 view

Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,

Jan 7, 2026, 11:46:54 AM (5 days ago) Jan 7

to Etienne Bergeron, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 7, 2026, 12:43:41 PM (5 days ago) Jan 7

to Etienne Pierre-Doray, Etienne Bergeron, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[tracing] Fix wrong sql statement in TraceReportDatabase

DROP TABLE <table name> IF EXISTS -> DROP TABLE IF EXISTS <table name>

This statement was run in version migration code path, and would
log an error in console, without crashing.

Change-Id: I07e9aa5dc131cd800c9bfda333d5d97c46e22543

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7409613

Reviewed-by: Etienne Bergeron <etie...@chromium.org>

Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1565741}

Files:

M content/browser/tracing/trace_report_database.cc

Change size: XS

Delta: 1 file changed, 3 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Etienne Bergeron

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages