Convert to UNSAFE_TODO in components [2/4] [chromium/src : main]

0 views

Skip to first unread message

Colin Blundell (Gerrit)

unread,

Dec 4, 2025, 9:14:34 AMDec 4

to Arthur Sonzogni, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, crostin...@chromium.org, fuzzin...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, security-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org

Attention needed from Arthur Sonzogni

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Arthur Sonzogni

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Dec 4, 2025, 9:49:11 AMDec 4

to Arthur Sonzogni, Colin Blundell, chromium...@chromium.org, Enterprise Policy Reviews, crostin...@chromium.org, fuzzin...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, security-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Convert to UNSAFE_TODO in components [2/4]

This is an automated #cleanup patch using the [Script] below.

We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.

This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).

R=blun...@chromium.org

Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing

AX-Relnotes: N/A

Cleanup: This is an automated #cleanup.

Bug: 409340989

Change-Id: I1a1cb2499719c08a8afe58fc4049df2e9102d041

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7228423

Reviewed-by: Colin Blundell <blun...@chromium.org>

Commit-Queue: Colin Blundell <blun...@chromium.org>

Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>

Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1553973}

Files:

M components/allocation_recorder/crash_handler/allocation_recorder_holder.cc
M components/allocation_recorder/crash_handler/allocation_recorder_holder_unittest.cc
M components/android_autofill/browser/android_autofill_features.cc
M components/browser_ui/photo_picker/android/features.cc
M components/cbor/reader_fuzzer.cc
M components/download/internal/common/in_memory_download_file.cc
M components/exo/data_offer_unittest.cc
M components/exo/data_source.cc
M components/exo/shell_surface_unittest.cc
M components/exo/surface_tree_host_unittest.cc
M components/exo/wm_helper.cc
M components/external_intents/android/external_intents_features.cc
M components/gwp_asan/client/guarded_page_allocator_unittest.cc
M components/gwp_asan/client/sampling_malloc_shims_unittest.cc
M components/gwp_asan/common/extreme_lightweight_detector_util.h
M components/gwp_asan/common/pack_stack_trace_differential_fuzzer.cc
M components/gwp_asan/common/pack_stack_trace_unpack_fuzzer.cc
M components/ownership/owner_key_util_impl_unittest.cc
M components/page_info/android/page_info_features.cc
M components/password_manager/core/browser/leak_detection/fuzzer/cypher_decrypt_fuzzer.cc
M components/password_manager/core/browser/leak_detection/fuzzer/cypher_encrypt_with_key_fuzzer.cc
M components/password_manager/core/common/passwords_directory_util_ios_unittest.cc
M components/policy/core/common/registry_dict.cc
M components/power_metrics/energy_metrics_provider_win.cc
M components/spellcheck/browser/spellcheck_host_metrics_unittest.cc
M components/spellcheck/browser/spellcheck_platform_mac_unittest.cc
M components/system_cpu/host_processor_info_scanner.cc
M components/tracing/common/graphics_memory_dump_provider_android.cc
M components/webui/flags/flags_state.cc
M components/wifi/network_properties.cc

Change size: L

Delta: 30 files changed, 140 insertions(+), 238 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Colin Blundell

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages