[base] Pass base::Time{,Ticks,Delta} by value instead of reference [chromium/src : main]
0 views
Skip to first unread message
Sylvain Defresne (Gerrit)
Jul 29, 2026, 7:57:46 AM (8 days ago) Jul 29
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Sylvain Defresne added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
Jul 29, 2026, 7:57:51 AM (8 days ago) Jul 29
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Sylvain Defresne voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Jul 29, 2026, 8:54:21 AM (8 days ago) Jul 29
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Sylvain Defresne
Mikhail Khokhlov voted![]( "Open in Gerrit")
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 29, 2026, 9:08:05 AM (8 days ago) Jul 29
to Sylvain Defresne, Mikhail Khokhlov, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[base] Pass base::Time{,Ticks,Delta} by value instead of reference
The types are copyable, moveable and have the same size as a 64-bit
integer. The documentation recommends passing them by value instead
of const reference.
Update code in //base/trace_event.Bug: none
Change-Id: Icd6530d20b1d050af686eb6dd636cb02806ac83a
Auto-Submit: Sylvain Defresne <sdef...@chromium.org>
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Commit-Queue: Mikhail Khokhlov <khok...@google.com>
Cr-Commit-Position: refs/heads/main@{#1670174}
Files:
- M base/trace_event/traced_value_support.h
Change size: XS
Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mikhail Khokhlov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages