Lei Zhang (Gerrit)

unread,

Oct 24, 2025, 4:45:17 PMOct 24

to Lei Zhang, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Hiroki Nakagawa, Peter Beverloo, Rijubrata Bhaumik, Chromium LUCI CQ, alexmo...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Avi Drissman

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Lei Zhang . resolved

Please OO+1 for content/browser/child_process_security_policy_impl.h.

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Oct 24, 2025, 4:46:23 PMOct 24

to Lei Zhang, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Hiroki Nakagawa, Peter Beverloo, Rijubrata Bhaumik, Chromium LUCI CQ, alexmo...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Lei Zhang

Avi Drissman voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Oct 24, 2025, 7:49:38 PMOct 24

to Lei Zhang, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Hiroki Nakagawa, Peter Beverloo, Rijubrata Bhaumik, Chromium LUCI CQ, alexmo...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Commit-Queue	+2
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Lei Zhang . resolved

Please OO+1 for content/browser/child_process_security_policy_impl.h.

Lei Zhang

I'll OO+1.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Oct 24, 2025, 7:52:57 PMOct 24

to Lei Zhang, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, Hiroki Nakagawa, Peter Beverloo, Rijubrata Bhaumik, alexmo...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Swap ref_counted.h for scoped_refptr.h when appropriate in //content

At some point, scoped_refptr got split off into its own header. Use it
in //content headers when appropriate in place of ref_counted.h.

Mostly automated with the following commands:

git ls-files content | grep '\.h$' | \
  xargs grep -l base/memory/ref_counted.h | xargs grep -L RefCounted | \
  xargs grep -l 'scoped_refptr<' | \
  xargs grep -L base/memory/scoped_refptr.h > list.txt

cat list.txt | \
  xargs tools/add_header.py --header '"base/memory/scoped_refptr.h"'

cat list.txt | \
  xargs tools/add_header.py --header '"base/memory/ref_counted.h"' \
    --remove

Then do IWYU to fix the build.

Bug: 40245294

Change-Id: I3206293a8802e265bf3deee8de2f01e9918b06c4

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7082314

Reviewed-by: Avi Drissman <a...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Owners-Override: Lei Zhang <the...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1535412}

Files:

M content/browser/android/content_url_loader_factory.h
M content/browser/android/java/gin_java_bound_object_delegate.h
M content/browser/android/synchronous_compositor_host.h
M content/browser/background_fetch/background_fetch_event_dispatcher.h
M content/browser/background_fetch/background_fetch_job_controller.h
M content/browser/background_fetch/background_fetch_service_impl.h
M content/browser/background_fetch/background_fetch_test_base.h
M content/browser/browser_main_loop.h
M content/browser/byte_stream.h
M content/browser/cache_storage/cache_storage.h
M content/browser/cache_storage/cache_storage_blob_to_disk_cache.h
M content/browser/cache_storage/cache_storage_operation.h
M content/browser/child_process_security_policy_impl.h
M content/browser/devtools/protocol/tethering_handler.h
M content/browser/download/drag_download_file.h
M content/browser/fenced_frame/fenced_frame_config.h
M content/browser/fenced_frame/fenced_frame_url_mapping.h
M content/browser/file_system/file_system_url_loader_factory.h
M content/browser/gpu/browser_gpu_channel_host_factory.h
M content/browser/gpu/gpu_data_manager_impl_private.h
M content/browser/indexed_db/instance/backing_store_pre_close_task_queue.h
M content/browser/indexed_db/instance/leveldb/backing_store.h
M content/browser/loader/file_url_loader_factory.h
M content/browser/media/capture/desktop_capture_device.h
M content/browser/media/media_internals_handler.h
M content/browser/notifications/platform_notification_context_impl.h
M content/browser/push_messaging/push_messaging_manager.h
M content/browser/renderer_host/ipc_utils.h
M content/browser/renderer_host/media/in_process_video_capture_provider.h
M content/browser/renderer_host/media/media_stream_manager.h
M content/browser/renderer_host/media/video_capture_manager.h
M content/browser/renderer_host/navigator.h
M content/browser/screenlock_monitor/screenlock_monitor.h
M content/browser/service_worker/service_worker_container_host.h
M content/browser/service_worker/service_worker_content_settings_proxy_impl.h
M content/browser/service_worker/service_worker_controllee_request_handler.h
M content/browser/service_worker/service_worker_internals_ui.h
M content/browser/service_worker/service_worker_object_host.h
M content/browser/service_worker/service_worker_registration_object_host.h
M content/browser/speech/network_speech_recognition_engine_impl.h
M content/browser/ssl/ssl_client_auth_handler.h
M content/browser/ssl_private_key_impl.h
M content/browser/tracing/tracing_controller_impl.h
M content/common/in_process_child_thread_params.h
M content/gpu/gpu_child_thread.h
M content/gpu/gpu_service_factory.h
M content/public/browser/cookie_store_factory.h
M content/public/browser/devtools_manager_delegate.h
M content/public/browser/file_url_loader.h
M content/public/browser/page_navigator.h
M content/public/browser/speech_recognition_session_config.h
M content/public/child/child_thread.h
M content/public/common/resource_request_body_android.h
M content/public/renderer/content_renderer_client.h
M content/public/test/bluetooth_test_utils.h
M content/public/test/mock_navigation_handle.h
M content/public/test/scoped_page_focus_override.h
M content/public/test/slow_http_response.h
M content/public/test/test_browser_context.h
M content/public/test/test_host_resolver.h
M content/renderer/discardable_memory_utils.h
M content/renderer/media/cast_renderer_client_factory.h
M content/renderer/media/media_permission_dispatcher.h
M content/renderer/media/renderer_webaudiodevice_impl.h
M content/renderer/render_frame_impl.h
M content/renderer/render_thread_impl.h
M content/renderer/service_worker/service_worker_provider_context.h
M content/renderer/service_worker/service_worker_subresource_loader.h
M content/renderer/service_worker/web_service_worker_provider_impl.h
M content/renderer/webgraphicscontext3d_provider_impl.h
M content/renderer/worker/worker_thread_registry.h
M content/shell/browser/shell_devtools_bindings.h
M content/test/fenced_frame_test_utils.h
M content/test/mock_overscroll_controller_delegate_aura.h
M content/test/mock_overscroll_refresh_handler_android.h
M content/test/test_background_sync_manager.h

Change size: M

Delta: 76 files changed, 80 insertions(+), 77 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Avi Drissman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Swap ref_counted.h for scoped_refptr.h when appropriate in //content [chromium/src : main]

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Avi Drissman (Gerrit)

Avi Drissman voted Code-Review+1

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information