Remove usage of MemoryPressureLevel alias. [chromium/src : main]

0 views
Skip to first unread message

Patrick Monette (Gerrit)

unread,
Oct 7, 2025, 11:12:27 AMOct 7
to Francois Pierre Doray, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Nate Chapin, prerendering-reviews, Stephen Chenney, James Su, Zijie He, Chromium LUCI CQ, agriev...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, creis...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, drott+bl...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, rginda...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, thiabaud+watch-d...@google.com, torne...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org
Attention needed from Francois Pierre Doray

Patrick Monette added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Patrick Monette . resolved

Hi, Sorry for the long patch but it's pretty mechanical, with some comment fixes.

I'd like a OO too please

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I73e8837b454177d79006d3e61bbb5ff659e429bb
Gerrit-Change-Number: 7013949
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Oct 2025 15:12:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

AI Code Reviewer (Gerrit)

unread,
Oct 7, 2025, 11:25:36 AMOct 7
to Patrick Monette, Francois Pierre Doray, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Nate Chapin, prerendering-reviews, Stephen Chenney, James Su, Zijie He, Chromium LUCI CQ, agriev...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, creis...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, drott+bl...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, rginda...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, thiabaud+watch-d...@google.com, torne...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org
Attention needed from Francois Pierre Doray

AI Code Reviewer added 2 comments

File third_party/blink/renderer/platform/graphics/image_decoding_store.h
Line 257, Patchset 8 (Latest): void OnMemoryPressure(base::MemoryPressureLevel level);
AI Code Reviewer . unresolved

nit: Per the Blink Style Guide (Naming - May leave obvious parameter names out of function declarations), parameter names in header file declarations may be omitted if the type is self-descriptive. Please consider removing the name `level`.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

File third_party/blink/renderer/platform/media/url_index.h
Line 329, Patchset 8 (Latest): UrlData::CacheMode cache_lookup_mode);
AI Code Reviewer . unresolved

nit: Per the Blink Style Guide (Naming - May leave obvious parameter names out of function declarations), parameter names in header file declarations may be omitted if the type is self-descriptive. Please consider removing the name `memory_pressure_level`.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I73e8837b454177d79006d3e61bbb5ff659e429bb
    Gerrit-Change-Number: 7013949
    Gerrit-PatchSet: 8
    Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Comment-Date: Tue, 07 Oct 2025 15:25:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Francois Pierre Doray (Gerrit)

    unread,
    Oct 7, 2025, 1:28:13 PMOct 7
    to Patrick Monette, AI Code Reviewer, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Nate Chapin, prerendering-reviews, Stephen Chenney, James Su, Zijie He, Chromium LUCI CQ, agriev...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, creis...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, drott+bl...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, rginda...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, thiabaud+watch-d...@google.com, torne...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org
    Attention needed from Patrick Monette

    Francois Pierre Doray voted and added 3 comments

    Votes added by Francois Pierre Doray

    Code-Review+1
    Commit-Queue+2
    Owners-Override+1

    3 comments

    Patchset-level comments
    File-level comment, Patchset 8 (Latest):
    Francois Pierre Doray . resolved

    CR+1
    OO+1 for mechanical change to adapt to a //base API change

    File third_party/blink/renderer/platform/graphics/image_decoding_store.h
    Line 257, Patchset 8 (Latest): void OnMemoryPressure(base::MemoryPressureLevel level);
    AI Code Reviewer . resolved

    nit: Per the Blink Style Guide (Naming - May leave obvious parameter names out of function declarations), parameter names in header file declarations may be omitted if the type is self-descriptive. Please consider removing the name `level`.

    _To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
    **Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

    This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

    Francois Pierre Doray

    Out of scope

    File third_party/blink/renderer/platform/media/url_index.h
    Line 329, Patchset 8 (Latest): UrlData::CacheMode cache_lookup_mode);
    AI Code Reviewer . resolved

    nit: Per the Blink Style Guide (Naming - May leave obvious parameter names out of function declarations), parameter names in header file declarations may be omitted if the type is self-descriptive. Please consider removing the name `memory_pressure_level`.

    _To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
    **Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

    This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

    Francois Pierre Doray

    Out of scope

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Patrick Monette
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I73e8837b454177d79006d3e61bbb5ff659e429bb
    Gerrit-Change-Number: 7013949
    Gerrit-PatchSet: 8
    Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
    Gerrit-Comment-Date: Tue, 07 Oct 2025 17:28:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 7, 2025, 2:24:14 PMOct 7
    to Patrick Monette, Francois Pierre Doray, AI Code Reviewer, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Nate Chapin, prerendering-reviews, Stephen Chenney, James Su, Zijie He, agriev...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, creis...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, drott+bl...@chromium.org, edgesto...@microsoft.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, halliwe...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, rginda...@chromium.org, scheduler-...@chromium.org, shuche...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, thiabaud+watch-d...@google.com, torne...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove usage of MemoryPressureLevel alias.

    The actual alias will be removed in another CL to reduce the chances of
    revert.
    Bug: 436324601
    Change-Id: I73e8837b454177d79006d3e61bbb5ff659e429bb
    Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>
    Commit-Queue: Patrick Monette <pmon...@chromium.org>
    Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
    Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1526427}
    Files:
    • M android_webview/browser/aw_contents.cc
    • M base/android/memory_pressure_listener_android.cc
    • M base/memory/memory_pressure_listener.h
    • M base/memory/memory_pressure_listener_unittest.cc
    • M base/memory/memory_pressure_monitor.h
    • M base/threading/hang_watcher.cc
    • M base/threading/hang_watcher.h
    • M base/trace_event/memory_pressure_level_proto.cc
    • M base/trace_event/memory_pressure_level_proto.h
    • M cc/layers/texture_layer_unittest.cc
    • M cc/raster/staging_buffer_pool.cc
    • M cc/raster/staging_buffer_pool.h
    • M cc/raster/staging_buffer_pool_unittest.cc
    • M cc/resources/resource_pool.cc
    • M cc/resources/resource_pool.h
    • M cc/resources/resource_pool_unittest.cc
    • M cc/tiles/gpu_image_decode_cache.cc
    • M cc/tiles/gpu_image_decode_cache.h
    • M cc/tiles/gpu_image_decode_cache_unittest.cc
    • M cc/tiles/image_decode_cache_utils.cc
    • M cc/tiles/image_decode_cache_utils.h
    • M cc/trees/layer_tree_host_impl.cc
    • M cc/trees/layer_tree_host_impl.h
    • M cc/trees/layer_tree_host_impl_unittest.cc
    • M chrome/browser/dbus_memory_pressure_evaluator_linux.cc
    • M chrome/browser/dbus_memory_pressure_evaluator_linux.h
    • M chrome/browser/dbus_memory_pressure_evaluator_linux_unittest.cc
    • M chrome/browser/glic/glic_profile_manager.cc
    • M chrome/browser/glic/glic_profile_manager.h
    • M chrome/browser/glic/glic_profile_manager_browsertest.cc
    • M chrome/browser/glic/glic_profile_manager_interactive_uitest.cc
    • M chrome/browser/glic/host/glic_api_browsertest.cc
    • M chrome/browser/glic/public/glic_keyed_service.cc
    • M chrome/browser/glic/public/glic_keyed_service.h
    • M chrome/browser/glic/widget/glic_window_controller_interactive_uitest.cc
    • M chrome/browser/long_screenshots/long_screenshots_tab_service.cc
    • M chrome/browser/memory/enterprise_memory_limit_evaluator.cc
    • M chrome/browser/memory/enterprise_memory_limit_evaluator_unittest.cc
    • M chrome/browser/paint_preview/services/paint_preview_tab_service.cc
    • M chrome/browser/performance_manager/policies/background_tab_loading_policy.cc
    • M chrome/browser/performance_manager/policies/background_tab_loading_policy.h
    • M chrome/browser/performance_manager/policies/background_tab_loading_policy_unittest.cc
    • M chrome/browser/performance_manager/policies/bfcache_policy_browsertest.cc
    • M chrome/browser/performance_manager/policies/urgent_page_discarding_policy.cc
    • M chrome/browser/performance_manager/policies/urgent_page_discarding_policy.h
    • M chrome/browser/performance_manager/policies/urgent_page_discarding_policy_unittest.cc
    • M chrome/browser/performance_manager/policies/userspace_swap_policy_chromeos.cc
    • M chrome/browser/performance_manager/policies/userspace_swap_policy_chromeos.h
    • M chrome/browser/performance_manager/policies/userspace_swap_policy_chromeos_unittest.cc
    • M chrome/browser/performance_manager/policies/working_set_trimmer_policy_chromeos.cc
    • M chrome/browser/performance_manager/policies/working_set_trimmer_policy_chromeos.h
    • M chrome/browser/performance_manager/policies/working_set_trimmer_policy_chromeos_unittest.cc
    • M chrome/browser/preloading/autocomplete_dictionary_preload_browsertest.cc
    • M chrome/browser/sessions/session_restore_browsertest.cc
    • M chrome/browser/sessions/tab_loader.cc
    • M chrome/browser/sessions/tab_loader.h
    • M chrome/browser/sessions/tab_loader_tester.cc
    • M chrome/browser/sessions/tab_loader_tester.h
    • M chrome/browser/sessions/tab_loader_unittest.cc
    • M chrome/browser/thumbnail/cc/thumbnail_cache.cc
    • M chrome/browser/thumbnail/cc/thumbnail_cache.h
    • M chrome/browser/ui/views/tabs/tab_hover_card_controller.cc
    • M chrome/browser/ui/views/tabs/tab_hover_card_controller_unittest.cc
    • M chrome/browser/ui/views/tabs/tab_strip_action_container_browsertest.cc
    • M chrome/browser/ui/webui/top_chrome/webui_contents_preload_manager.cc
    • M chrome/browser/ui/webui/top_chrome/webui_contents_preload_manager_unittest.cc
    • M chromecast/browser/cast_system_memory_pressure_evaluator.cc
    • M chromecast/browser/cast_system_memory_pressure_evaluator.h
    • M chromecast/browser/lru_renderer_cache.cc
    • M chromecast/browser/lru_renderer_cache.h
    • M chromecast/browser/memory_pressure_controller_impl.cc
    • M chromecast/browser/memory_pressure_controller_impl.h
    • M chromecast/common/mojom/memory_pressure.mojom
    • M chromecast/renderer/memory_pressure_observer_impl.cc
    • M chromeos/ash/components/memory/pressure/system_memory_pressure_evaluator.cc
    • M chromeos/ash/components/memory/pressure/system_memory_pressure_evaluator_unittest.cc
    • M components/breadcrumbs/core/application_breadcrumbs_logger.cc
    • M components/breadcrumbs/core/application_breadcrumbs_logger.h
    • M components/breadcrumbs/core/application_breadcrumbs_logger_unittest.cc
    • M components/discardable_memory/service/discardable_shared_memory_manager.cc
    • M components/discardable_memory/service/discardable_shared_memory_manager.h
    • M components/discardable_memory/service/discardable_shared_memory_manager_unittest.cc
    • M components/history/core/browser/history_backend.cc
    • M components/history/core/browser/history_backend.h
    • M components/memory_pressure/fake_memory_pressure_monitor.cc
    • M components/memory_pressure/fake_memory_pressure_monitor.h
    • M components/memory_pressure/memory_pressure_level_reporter.cc
    • M components/memory_pressure/memory_pressure_level_reporter.h
    • M components/memory_pressure/memory_pressure_level_reporter_unittest.cc
    • M components/memory_pressure/memory_pressure_voter.cc
    • M components/memory_pressure/memory_pressure_voter.h
    • M components/memory_pressure/memory_pressure_voter_unittest.cc
    • M components/memory_pressure/multi_source_memory_pressure_monitor.cc
    • M components/memory_pressure/multi_source_memory_pressure_monitor.h
    • M components/memory_pressure/multi_source_memory_pressure_monitor_unittest.cc
    • M components/memory_pressure/system_memory_pressure_evaluator.cc
    • M components/memory_pressure/system_memory_pressure_evaluator.h
    • M components/memory_pressure/system_memory_pressure_evaluator_fuchsia.cc
    • M components/memory_pressure/system_memory_pressure_evaluator_fuchsia_unittest.cc
    • M components/memory_pressure/system_memory_pressure_evaluator_mac.cc
    • M components/memory_pressure/system_memory_pressure_evaluator_mac.h
    • M components/memory_pressure/system_memory_pressure_evaluator_mac_unittest.cc
    • M components/memory_pressure/system_memory_pressure_evaluator_win.cc
    • M components/memory_pressure/system_memory_pressure_evaluator_win.h
    • M components/memory_pressure/system_memory_pressure_evaluator_win_unittest.cc
    • M components/omnibox/browser/on_device_tail_model_service.cc
    • M components/omnibox/browser/on_device_tail_model_service.h
    • M components/omnibox/browser/on_device_tail_model_service_unittest.cc
    • M components/paint_preview/browser/paint_preview_compositor_service_impl.cc
    • M components/paint_preview/browser/paint_preview_compositor_service_impl.h
    • M components/paint_preview/player/android/player_compositor_delegate_android.cc
    • M components/paint_preview/player/android/player_compositor_delegate_android.h
    • M components/paint_preview/player/player_compositor_delegate.cc
    • M components/paint_preview/player/player_compositor_delegate.h
    • M components/paint_preview/player/player_compositor_delegate_unittest.cc
    • M components/paint_preview/public/paint_preview_compositor_service.h
    • M components/performance_manager/graph/policies/bfcache_policy.cc
    • M components/performance_manager/graph/policies/bfcache_policy.h
    • M components/performance_manager/graph/policies/bfcache_policy_unittest.cc
    • M components/performance_manager/graph/system_node_impl.h
    • M components/performance_manager/graph/system_node_impl_unittest.cc
    • M components/performance_manager/public/graph/system_node.h
    • M components/services/paint_preview_compositor/paint_preview_compositor_collection_impl.cc
    • M components/services/paint_preview_compositor/paint_preview_compositor_collection_impl.h
    • M components/services/paint_preview_compositor/paint_preview_compositor_collection_impl_unittest.cc
    • M components/services/storage/shared_storage/shared_storage_manager.cc
    • M components/services/storage/shared_storage/shared_storage_manager.h
    • M components/services/storage/shared_storage/shared_storage_manager_unittest.cc
    • M components/services/storage/shared_storage/shared_storage_test_utils.cc
    • M components/services/storage/shared_storage/shared_storage_test_utils.h
    • M components/viz/client/frame_eviction_manager.cc
    • M components/viz/client/frame_eviction_manager.h
    • M components/viz/client/frame_eviction_manager_unittest.cc
    • M components/viz/common/gpu/vulkan_in_process_context_provider.cc
    • M components/viz/common/gpu/vulkan_in_process_context_provider.h
    • M components/viz/common/gpu/vulkan_in_process_context_provider_unittest.cc
    • M components/viz/service/display_embedder/compositor_gpu_thread.cc
    • M components/viz/service/display_embedder/compositor_gpu_thread.h
    • M components/viz/service/display_embedder/skia_output_surface_impl.cc
    • M components/viz/service/gl/gpu_service_impl.cc
    • M components/viz/service/gl/gpu_service_impl.h
    • M components/viz/test/stub_gpu_service.cc
    • M components/viz/test/stub_gpu_service.h
    • M content/app/android/javaless_child_process_service.cc
    • M content/browser/cache_storage/cache_storage_manager.cc
    • M content/browser/cache_storage/cache_storage_manager.h
    • M content/browser/cache_storage/cache_storage_manager_unittest.cc
    • M content/browser/child_process_host_impl.cc
    • M content/browser/child_process_host_impl.h
    • M content/browser/devtools/protocol/memory_handler.cc
    • M content/browser/dom_storage/dom_storage_context_wrapper.cc
    • M content/browser/dom_storage/dom_storage_context_wrapper.h
    • M content/browser/gpu/gpu_process_host.cc
    • M content/browser/gpu/gpu_process_host.h
    • M content/browser/memory_pressure/user_level_memory_pressure_signal_generator.cc
    • M content/browser/network/shared_dictionary_browsertest.cc
    • M content/browser/network_service_browsertest.cc
    • M content/browser/network_service_client.cc
    • M content/browser/network_service_client.h
    • M content/browser/preloading/prerender/prerender_browsertest.cc
    • M content/browser/preloading/prerender/prerender_host_registry.cc
    • M content/browser/preloading/prerender/prerender_host_registry.h
    • M content/browser/renderer_host/debug_urls.cc
    • M content/browser/renderer_host/navigation_transitions/navigation_entry_screenshot_cache_unittest.cc
    • M content/browser/renderer_host/navigation_transitions/navigation_entry_screenshot_manager.cc
    • M content/browser/renderer_host/navigation_transitions/navigation_entry_screenshot_manager.h
    • M content/browser/renderer_host/render_frame_host_impl.cc
    • M content/browser/renderer_host/render_process_host_impl.cc
    • M content/browser/renderer_host/render_process_host_impl.h
    • M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
    • M content/browser/renderer_host/spare_render_process_host_manager_impl.cc
    • M content/browser/renderer_host/spare_render_process_host_manager_impl.h
    • M content/child/child_thread_impl.cc
    • M content/child/child_thread_impl.h
    • M content/gpu/gpu_child_thread.cc
    • M content/gpu/gpu_child_thread.h
    • M content/public/test/network_service_test_helper.cc
    • M content/renderer/render_thread_impl.cc
    • M content/renderer/render_thread_impl.h
    • M content/renderer/render_thread_impl_discardable_memory_browsertest.cc
    • M gpu/command_buffer/service/dawn_caching_interface.cc
    • M gpu/command_buffer/service/dawn_caching_interface.h
    • M gpu/command_buffer/service/dawn_caching_interface_unittest.cc
    • M gpu/command_buffer/service/gr_shader_cache.cc
    • M gpu/command_buffer/service/gr_shader_cache.h
    • M gpu/command_buffer/service/gr_shader_cache_unittest.cc
    • M gpu/command_buffer/service/program_cache.cc
    • M gpu/command_buffer/service/program_cache.h
    • M gpu/command_buffer/service/service_transfer_cache.cc
    • M gpu/command_buffer/service/service_transfer_cache.h
    • M gpu/command_buffer/service/service_transfer_cache_unittest.cc
    • M gpu/command_buffer/service/service_utils.cc
    • M gpu/command_buffer/service/service_utils.h
    • M gpu/command_buffer/service/shared_context_state.cc
    • M gpu/command_buffer/service/shared_context_state.h
    • M gpu/ipc/service/gpu_channel_manager.cc
    • M gpu/ipc/service/gpu_channel_manager.h
    • M ios/chrome/app/application_delegate/memory_warning_helper.mm
    • M ios/chrome/app/application_delegate/memory_warning_helper_unittest.mm
    • M media/filters/chunk_demuxer.h
    • M mojo/public/cpp/base/memory_pressure_level_mojom_traits.cc
    • M mojo/public/cpp/base/memory_pressure_level_mojom_traits.h
    • M mojo/public/mojom/base/BUILD.gn
    • M mojo/public/mojom/base/memory_pressure_level.mojom
    • M net/disk_cache/backend_unittest.cc
    • M net/disk_cache/memory/mem_backend_impl.cc
    • M net/disk_cache/memory/mem_backend_impl.h
    • M net/http/http_network_session.cc
    • M net/http/http_network_session.h
    • M net/http/http_network_transaction_unittest.cc
    • M net/http/http_stream_pool_group_unittest.cc
    • M net/quic/quic_session_pool.cc
    • M net/quic/quic_session_pool.h
    • M net/ssl/ssl_client_session_cache.cc
    • M net/ssl/ssl_client_session_cache.h
    • M net/ssl/ssl_client_session_cache_unittest.cc
    • M services/device/usb/usb_device_linux.cc
    • M services/network/network_service.cc
    • M services/network/network_service.h
    • M services/network/shared_dictionary/shared_dictionary_manager.cc
    • M services/network/shared_dictionary/shared_dictionary_manager.h
    • M services/network/shared_dictionary/shared_dictionary_manager_on_disk.cc
    • M services/network/shared_dictionary/shared_dictionary_manager_on_disk.h
    • M services/network/shared_dictionary/shared_dictionary_manager_unittest.cc
    • M services/network/shared_dictionary/shared_dictionary_storage_on_disk.cc
    • M services/network/shared_dictionary/shared_dictionary_storage_on_disk.h
    • M services/network/slop_bucket.cc
    • M storage/browser/blob/blob_memory_controller.cc
    • M storage/browser/blob/blob_memory_controller.h
    • M storage/browser/blob/blob_memory_controller_unittest.cc
    • M third_party/blink/public/platform/web_memory_pressure_listener.h
    • M third_party/blink/renderer/controller/user_level_memory_pressure_signal_generator.cc
    • M third_party/blink/renderer/controller/user_level_memory_pressure_signal_generator_test.cc
    • M third_party/blink/renderer/platform/exported/web_memory_pressure_listener.cc
    • M third_party/blink/renderer/platform/graphics/image_decoding_store.cc
    • M third_party/blink/renderer/platform/graphics/image_decoding_store.h
    • M third_party/blink/renderer/platform/graphics/image_decoding_store_test.cc
    • M third_party/blink/renderer/platform/instrumentation/memory_pressure_listener.cc
    • M third_party/blink/renderer/platform/instrumentation/memory_pressure_listener.h
    • M third_party/blink/renderer/platform/loader/fetch/memory_cache.cc
    • M third_party/blink/renderer/platform/loader/fetch/memory_cache.h
    • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
    • M third_party/blink/renderer/platform/media/url_index.cc
    • M third_party/blink/renderer/platform/media/url_index.h
    • M third_party/blink/renderer/platform/scheduler/main_thread/memory_purge_manager.cc
    • M third_party/blink/renderer/platform/scheduler/main_thread/memory_purge_manager_unittest.cc
    • M third_party/leveldatabase/leveldb_chrome.cc
    Change size: XL
    Delta: 248 files changed, 836 insertions(+), 1248 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I73e8837b454177d79006d3e61bbb5ff659e429bb
    Gerrit-Change-Number: 7013949
    Gerrit-PatchSet: 9
    Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages