[tracing] Delete AutoOpenCloseEvent [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Dec 9, 2025, 9:17:06 AM (11 days ago) Dec 9
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Dec 9, 2025, 9:29:42 AM (11 days ago) Dec 9
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Dec 9, 2025, 9:53:42 AM (11 days ago) Dec 9
to Dale Curtis, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dale Curtis
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Dale Curtis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dec 9, 2025, 10:58:41 AM (11 days ago) Dec 9
to Etienne Pierre-Doray, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
Patchset-level comments
Dale Curtis . resolved
That's too bad, I always liked this for ensuring traces were properly closed.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Dec 9, 2025, 1:17:05 PM (11 days ago) Dec 9
to Dale Curtis, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 9, 2025, 1:39:51 PM (11 days ago) Dec 9
to Etienne Pierre-Doray, Dale Curtis, Mikhail Khokhlov, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[tracing] Delete AutoOpenCloseEvent
There's a few issues with AutoOpenCloseEvent:
- It uses legacy async macros and category string doesn't work with SDK
- OnTraceLogEnabled doesn't support multiple sessions
There's only 1 user of AutoOpenCloseEvent. This CL replaces this usage
with direct TRACE_EVENT_BEGIN/END and deletes AutoOpenCloseEvent.
Change-Id: I4a6668a9d6e3e6963e702d2691eba8a7a067538a
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1556259}
Files:
- M base/BUILD.gn
- D base/trace_event/auto_open_close_event.h
- M third_party/blink/renderer/platform/media/video_frame_compositor.cc
- M third_party/blink/renderer/platform/media/video_frame_compositor.h
Change size: M
Delta: 4 files changed, 3 insertions(+), 94 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dale Curtis, +1 by Mikhail Khokhlov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages