Split base::IsBaseCallback into its own header [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Nov 26, 2025, 6:36:59 PMNov 26
to Lei Zhang, Daniel Cheng, Enterprise Policy Reviews, Peter Beverloo, Simon Hangl, Tommy Li, Rijubrata Bhaumik, Zijie He, Andrew Rayskiy, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Kaan Icer, Hiroki Nakagawa, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Sean Maher, Thiabaud Engelbrecht, Chromium LUCI CQ, thegreenf...@chromium.org, filesapp...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, fuzzin...@chromium.org, language...@chromium.org, dtraino...@chromium.org, rginda...@chromium.org, loyso...@chromium.org, vasilii+watchlis...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, android-web...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, gcasto+w...@chromium.org, ios-web-view...@google.com, feature-v...@chromium.org, christia...@chromium.org, eic+...@google.com, kuragin+web-ap...@chromium.org, dibyapal+wa...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, print-rev...@chromium.org, cros-print...@google.com, mac-r...@chromium.org, hansenmichael...@google.com, tote-eng...@google.com, hais+wat...@google.com, ios-r...@chromium.org, suetfei+wa...@google.com, hansberry+w...@chromium.org, rrsilva+wat...@google.com, dclasson+w...@google.com, rmcelra...@chromium.org, marq+...@chromium.org, pushi+wat...@google.com, chfreme...@chromium.org, xlythe+wa...@google.com, ios-revie...@chromium.org, croissant-...@chromium.org, ajayramamurth...@google.com, fuchsia...@chromium.org, jackshira+w...@google.com, crisrael+w...@google.com, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+wa...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, geoffla...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, jackshira+wa...@google.com, jasonrobe...@google.com, jessemcke...@google.com, jiajunz+wat...@google.com, jophba...@chromium.org, jshin...@chromium.org, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, steimel+...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yigu+...@chromium.org, zackha...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 15 (Latest):
Lei Zhang . resolved

Please OO+1 for the IWYU changes outside of //base.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idcd348fc57c58d3f7c9caec92063702714c9cba3
Gerrit-Change-Number: 7200879
Gerrit-PatchSet: 15
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Nov 2025 23:36:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Nov 26, 2025, 6:56:21 PMNov 26
to Lei Zhang, Daniel Cheng, Enterprise Policy Reviews, Peter Beverloo, Simon Hangl, Tommy Li, Rijubrata Bhaumik, Zijie He, Andrew Rayskiy, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Kaan Icer, Hiroki Nakagawa, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Sean Maher, Thiabaud Engelbrecht, Chromium LUCI CQ, thegreenf...@chromium.org, filesapp...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, fuzzin...@chromium.org, language...@chromium.org, dtraino...@chromium.org, rginda...@chromium.org, loyso...@chromium.org, vasilii+watchlis...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, android-web...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, gcasto+w...@chromium.org, ios-web-view...@google.com, feature-v...@chromium.org, christia...@chromium.org, eic+...@google.com, kuragin+web-ap...@chromium.org, dibyapal+wa...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, print-rev...@chromium.org, cros-print...@google.com, mac-r...@chromium.org, hansenmichael...@google.com, tote-eng...@google.com, hais+wat...@google.com, ios-r...@chromium.org, suetfei+wa...@google.com, hansberry+w...@chromium.org, rrsilva+wat...@google.com, dclasson+w...@google.com, rmcelra...@chromium.org, marq+...@chromium.org, pushi+wat...@google.com, chfreme...@chromium.org, xlythe+wa...@google.com, ios-revie...@chromium.org, croissant-...@chromium.org, ajayramamurth...@google.com, fuchsia...@chromium.org, jackshira+w...@google.com, crisrael+w...@google.com, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+wa...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, geoffla...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, jackshira+wa...@google.com, jasonrobe...@google.com, jessemcke...@google.com, jiajunz+wat...@google.com, jophba...@chromium.org, jshin...@chromium.org, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, steimel+...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yigu+...@chromium.org, zackha...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments
Lei Zhang . resolved

Please OO+1 for the IWYU changes outside of //base.

Lei Zhang

Actually, I'm going to split this CL. Already seeing new files added that will not build because they transitively depend on one of these base headers.

Gerrit-Comment-Date: Wed, 26 Nov 2025 23:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Nov 26, 2025, 8:24:56 PMNov 26
to Lei Zhang, Daniel Cheng, Enterprise Policy Reviews, Peter Beverloo, Simon Hangl, Tommy Li, Rijubrata Bhaumik, Zijie He, Andrew Rayskiy, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Kaan Icer, Hiroki Nakagawa, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Sean Maher, Thiabaud Engelbrecht, Chromium LUCI CQ, thegreenf...@chromium.org, filesapp...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, fuzzin...@chromium.org, language...@chromium.org, dtraino...@chromium.org, rginda...@chromium.org, loyso...@chromium.org, vasilii+watchlis...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, android-web...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, gcasto+w...@chromium.org, ios-web-view...@google.com, feature-v...@chromium.org, christia...@chromium.org, eic+...@google.com, kuragin+web-ap...@chromium.org, dibyapal+wa...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, print-rev...@chromium.org, cros-print...@google.com, mac-r...@chromium.org, hansenmichael...@google.com, tote-eng...@google.com, hais+wat...@google.com, ios-r...@chromium.org, suetfei+wa...@google.com, hansberry+w...@chromium.org, rrsilva+wat...@google.com, dclasson+w...@google.com, rmcelra...@chromium.org, marq+...@chromium.org, pushi+wat...@google.com, chfreme...@chromium.org, xlythe+wa...@google.com, ios-revie...@chromium.org, croissant-...@chromium.org, ajayramamurth...@google.com, fuchsia...@chromium.org, jackshira+w...@google.com, crisrael+w...@google.com, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+wa...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, geoffla...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, jackshira+wa...@google.com, jasonrobe...@google.com, jessemcke...@google.com, jiajunz+wat...@google.com, jophba...@chromium.org, jshin...@chromium.org, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, steimel+...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yigu+...@chromium.org, zackha...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments
Lei Zhang . resolved

Please OO+1 for the IWYU changes outside of //base.

Lei Zhang

Actually, I'm going to split this CL. Already seeing new files added that will not build because they transitively depend on one of these base headers.

Lei Zhang

This CL is now much smaller.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idcd348fc57c58d3f7c9caec92063702714c9cba3
Gerrit-Change-Number: 7200879
Gerrit-PatchSet: 17
Gerrit-Comment-Date: Thu, 27 Nov 2025 01:24:45 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Nov 27, 2025, 12:37:34 AMNov 27
to Lei Zhang, Daniel Cheng, Enterprise Policy Reviews, Peter Beverloo, Simon Hangl, Tommy Li, Rijubrata Bhaumik, Zijie He, Andrew Rayskiy, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Kaan Icer, Hiroki Nakagawa, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Sean Maher, Thiabaud Engelbrecht, Chromium LUCI CQ, thegreenf...@chromium.org, filesapp...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, fuzzin...@chromium.org, language...@chromium.org, dtraino...@chromium.org, rginda...@chromium.org, loyso...@chromium.org, vasilii+watchlis...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, android-web...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, gcasto+w...@chromium.org, ios-web-view...@google.com, feature-v...@chromium.org, christia...@chromium.org, eic+...@google.com, kuragin+web-ap...@chromium.org, dibyapal+wa...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, print-rev...@chromium.org, cros-print...@google.com, mac-r...@chromium.org, hansenmichael...@google.com, tote-eng...@google.com, hais+wat...@google.com, ios-r...@chromium.org, suetfei+wa...@google.com, hansberry+w...@chromium.org, rrsilva+wat...@google.com, dclasson+w...@google.com, rmcelra...@chromium.org, marq+...@chromium.org, pushi+wat...@google.com, chfreme...@chromium.org, xlythe+wa...@google.com, ios-revie...@chromium.org, croissant-...@chromium.org, ajayramamurth...@google.com, fuchsia...@chromium.org, jackshira+w...@google.com, crisrael+w...@google.com, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+wa...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, geoffla...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, jackshira+wa...@google.com, jasonrobe...@google.com, jessemcke...@google.com, jiajunz+wat...@google.com, jophba...@chromium.org, jshin...@chromium.org, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, steimel+...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yigu+...@chromium.org, zackha...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Lei Zhang <the...@chromium.org>
    Gerrit-Comment-Date: Thu, 27 Nov 2025 05:37:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Dec 3, 2025, 1:23:00 PMDec 3
    to Lei Zhang, Daniel Cheng, Enterprise Policy Reviews, Peter Beverloo, Simon Hangl, Tommy Li, Rijubrata Bhaumik, Zijie He, Andrew Rayskiy, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Kaan Icer, Hiroki Nakagawa, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Sean Maher, Thiabaud Engelbrecht, Chromium LUCI CQ, thegreenf...@chromium.org, filesapp...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, fuzzin...@chromium.org, language...@chromium.org, dtraino...@chromium.org, rginda...@chromium.org, loyso...@chromium.org, vasilii+watchlis...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, android-web...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, gcasto+w...@chromium.org, ios-web-view...@google.com, feature-v...@chromium.org, christia...@chromium.org, eic+...@google.com, kuragin+web-ap...@chromium.org, dibyapal+wa...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, print-rev...@chromium.org, cros-print...@google.com, mac-r...@chromium.org, hansenmichael...@google.com, tote-eng...@google.com, hais+wat...@google.com, ios-r...@chromium.org, suetfei+wa...@google.com, hansberry+w...@chromium.org, rrsilva+wat...@google.com, dclasson+w...@google.com, rmcelra...@chromium.org, marq+...@chromium.org, pushi+wat...@google.com, chfreme...@chromium.org, xlythe+wa...@google.com, ios-revie...@chromium.org, croissant-...@chromium.org, ajayramamurth...@google.com, fuchsia...@chromium.org, jackshira+w...@google.com, crisrael+w...@google.com, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+wa...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, geoffla...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, jackshira+wa...@google.com, jasonrobe...@google.com, jessemcke...@google.com, jiajunz+wat...@google.com, jophba...@chromium.org, jshin...@chromium.org, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, steimel+...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yigu+...@chromium.org, zackha...@chromium.org
    Attention needed from Lei Zhang

    Daniel Cheng voted

    Code-Review+1
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Lei Zhang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idcd348fc57c58d3f7c9caec92063702714c9cba3
    Gerrit-Change-Number: 7200879
    Gerrit-PatchSet: 18
    Gerrit-Comment-Date: Wed, 03 Dec 2025 18:22:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Dec 3, 2025, 5:04:03 PMDec 3
    to Lei Zhang, Daniel Cheng, Enterprise Policy Reviews, Peter Beverloo, Simon Hangl, Tommy Li, Rijubrata Bhaumik, Zijie He, Andrew Rayskiy, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Kaan Icer, Hiroki Nakagawa, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Sean Maher, Thiabaud Engelbrecht, Chromium LUCI CQ, thegreenf...@chromium.org, filesapp...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, fuzzin...@chromium.org, language...@chromium.org, dtraino...@chromium.org, rginda...@chromium.org, loyso...@chromium.org, vasilii+watchlis...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, android-web...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, gcasto+w...@chromium.org, ios-web-view...@google.com, feature-v...@chromium.org, christia...@chromium.org, eic+...@google.com, kuragin+web-ap...@chromium.org, dibyapal+wa...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, print-rev...@chromium.org, cros-print...@google.com, mac-r...@chromium.org, hansenmichael...@google.com, tote-eng...@google.com, hais+wat...@google.com, ios-r...@chromium.org, suetfei+wa...@google.com, hansberry+w...@chromium.org, rrsilva+wat...@google.com, dclasson+w...@google.com, rmcelra...@chromium.org, marq+...@chromium.org, pushi+wat...@google.com, chfreme...@chromium.org, xlythe+wa...@google.com, ios-revie...@chromium.org, croissant-...@chromium.org, ajayramamurth...@google.com, fuchsia...@chromium.org, jackshira+w...@google.com, crisrael+w...@google.com, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+wa...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, geoffla...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, jackshira+wa...@google.com, jasonrobe...@google.com, jessemcke...@google.com, jiajunz+wat...@google.com, jophba...@chromium.org, jshin...@chromium.org, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, steimel+...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yigu+...@chromium.org, zackha...@chromium.org
    Attention needed from Daniel Cheng

    Lei Zhang voted and added 2 comments

    Votes added by Lei Zhang

    Auto-Submit+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 20 (Latest):
    Lei Zhang . resolved

    Had a merge conflict and need another stamp.

    File base/functional/is_callback.h
    Line 14, Patchset 20 (Latest):#include "base/functional/callback_helpers.h"
    Lei Zhang . resolved

    Added this to temporarily avoid missing includes as developers land other CLs. This CL should be able to land safely. I'll remove this afterwards.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idcd348fc57c58d3f7c9caec92063702714c9cba3
    Gerrit-Change-Number: 7200879
    Gerrit-PatchSet: 20
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Wed, 03 Dec 2025 22:03:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Dec 4, 2025, 1:26:13 PMDec 4
    to Lei Zhang, Daniel Cheng, Enterprise Policy Reviews, Peter Beverloo, Simon Hangl, Tommy Li, Rijubrata Bhaumik, Zijie He, Andrew Rayskiy, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Kaan Icer, Hiroki Nakagawa, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Sean Maher, Thiabaud Engelbrecht, Chromium LUCI CQ, thegreenf...@chromium.org, filesapp...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, fuzzin...@chromium.org, language...@chromium.org, dtraino...@chromium.org, rginda...@chromium.org, loyso...@chromium.org, vasilii+watchlis...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, android-web...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, gcasto+w...@chromium.org, ios-web-view...@google.com, feature-v...@chromium.org, christia...@chromium.org, eic+...@google.com, kuragin+web-ap...@chromium.org, dibyapal+wa...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, print-rev...@chromium.org, cros-print...@google.com, mac-r...@chromium.org, hansenmichael...@google.com, tote-eng...@google.com, hais+wat...@google.com, ios-r...@chromium.org, suetfei+wa...@google.com, hansberry+w...@chromium.org, rrsilva+wat...@google.com, dclasson+w...@google.com, rmcelra...@chromium.org, marq+...@chromium.org, pushi+wat...@google.com, chfreme...@chromium.org, xlythe+wa...@google.com, ios-revie...@chromium.org, croissant-...@chromium.org, ajayramamurth...@google.com, fuchsia...@chromium.org, jackshira+w...@google.com, crisrael+w...@google.com, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+wa...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, geoffla...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, jackshira+wa...@google.com, jasonrobe...@google.com, jessemcke...@google.com, jiajunz+wat...@google.com, jophba...@chromium.org, jshin...@chromium.org, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, steimel+...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yigu+...@chromium.org, zackha...@chromium.org
    Attention needed from Lei Zhang

    Daniel Cheng voted

    Code-Review+1
    Commit-Queue+2
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Lei Zhang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Lei Zhang <the...@chromium.org>
    Gerrit-Comment-Date: Thu, 04 Dec 2025 18:26:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 4, 2025, 1:39:31 PMDec 4
    to Lei Zhang, Daniel Cheng, Enterprise Policy Reviews, Peter Beverloo, Simon Hangl, Tommy Li, Rijubrata Bhaumik, Zijie He, Andrew Rayskiy, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Kaan Icer, Hiroki Nakagawa, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Sean Maher, Thiabaud Engelbrecht, thegreenf...@chromium.org, filesapp...@chromium.org, msrame...@chromium.org, dullweb...@chromium.org, fuzzin...@chromium.org, language...@chromium.org, dtraino...@chromium.org, rginda...@chromium.org, loyso...@chromium.org, vasilii+watchlis...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, android-web...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, gcasto+w...@chromium.org, ios-web-view...@google.com, feature-v...@chromium.org, christia...@chromium.org, eic+...@google.com, kuragin+web-ap...@chromium.org, dibyapal+wa...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, print-rev...@chromium.org, cros-print...@google.com, mac-r...@chromium.org, hansenmichael...@google.com, tote-eng...@google.com, hais+wat...@google.com, ios-r...@chromium.org, suetfei+wa...@google.com, hansberry+w...@chromium.org, rrsilva+wat...@google.com, dclasson+w...@google.com, rmcelra...@chromium.org, marq+...@chromium.org, pushi+wat...@google.com, chfreme...@chromium.org, xlythe+wa...@google.com, ios-revie...@chromium.org, croissant-...@chromium.org, ajayramamurth...@google.com, fuchsia...@chromium.org, jackshira+w...@google.com, crisrael+w...@google.com, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+wa...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, geoffla...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, jackshira+wa...@google.com, jasonrobe...@google.com, jessemcke...@google.com, jiajunz+wat...@google.com, jophba...@chromium.org, jshin...@chromium.org, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, steimel+...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yigu+...@chromium.org, zackha...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Split base::IsBaseCallback into its own header

    Move IsBaseCallback from base/functional/callback_helpers.h to
    is_callback.h. Then code that just needs IsBaseCallback can avoid
    dragging in all of callback_helpers.h. Then do IWYU to fix the build.
    Change-Id: Idcd348fc57c58d3f7c9caec92063702714c9cba3
    Reviewed-by: Daniel Cheng <dch...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Owners-Override: Daniel Cheng <dch...@chromium.org>
    Auto-Submit: Lei Zhang <the...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1554140}
    Files:
    • M PRESUBMIT.py
    • M base/BUILD.gn
    • M base/barrier_callback.h
    • M base/functional/callback_helpers.h
    • M base/functional/callback_helpers_unittest.cc
    • A base/functional/is_callback.h
    • A base/functional/is_callback_unittest.cc
    • M base/task/task_runner.h
    • M base/task/thread_pool.h
    • M base/threading/sequence_bound_internal.h
    • M chrome/browser/navigation_predictor/search_engine_preconnector.cc
    • M services/webnn/scoped_gpu_sequence.cc
    • M ui/base/interaction/interactive_test_definitions.h
    Change size: M
    Delta: 13 files changed, 89 insertions(+), 51 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Daniel Cheng
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idcd348fc57c58d3f7c9caec92063702714c9cba3
    Gerrit-Change-Number: 7200879
    Gerrit-PatchSet: 21
    Gerrit-Owner: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages