Update DisplayLink TRACE EVENT on Mac [chromium/src : main]
1 view
Skip to first unread message
Maggie Chen (Gerrit)
Mar 19, 2026, 5:34:46 PMMar 19
to Avi Drissman, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman and Etienne Pierre-Doray
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Avi Drissman
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Mar 19, 2026, 6:52:04 PMMar 19
to Maggie Chen, Avi Drissman, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and Maggie Chen
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
- Maggie Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Mar 20, 2026, 2:19:44 PM (13 days ago) Mar 20
to Maggie Chen, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Maggie Chen
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
File ui/display/mac/ca_display_link_mac.mm
Line 80, Patchset 1 (Latest):
TRACE_EVENT0("ui,gpu", "CADisplayLinkCallback");Etienne Pierre-Doray . unresolved
Is it possible to just use "gpu" here, to avoid category group?
https://chromium.googlesource.com/chromium/src.git/+/HEAD/docs/trace_events.md#avoid-category-groups
Related details
Attention is currently required from:
- Maggie Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maggie Chen (Gerrit)
Mar 20, 2026, 2:54:24 PM (13 days ago) Mar 20
to Avi Drissman, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman and Etienne Pierre-Doray
Maggie Chen added 1 comment![]( "Open in Gerrit")
File ui/display/mac/ca_display_link_mac.mm
Line 80, Patchset 1:
TRACE_EVENT0("ui,gpu", "CADisplayLinkCallback");Etienne Pierre-Doray . resolved
Is it possible to just use "gpu" here, to avoid category group?
https://chromium.googlesource.com/chromium/src.git/+/HEAD/docs/trace_events.md#avoid-category-groups
Attention is currently required from:
- Avi Drissman
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Mar 20, 2026, 2:54:58 PM (13 days ago) Mar 20
to Maggie Chen, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman and Maggie Chen
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Avi Drissman
- Maggie Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maggie Chen (Gerrit)
Mar 20, 2026, 2:55:41 PM (13 days ago) Mar 20
to Etienne Pierre-Doray, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman
Maggie Chen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Etienne Pierre-Doray . resolved
LGTM!
Maggie Chen
Thanks.
Related details
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maggie Chen (Gerrit)
Mar 20, 2026, 2:55:47 PM (13 days ago) Mar 20
to Etienne Pierre-Doray, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman
Maggie Chen voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Mar 20, 2026, 2:56:22 PM (13 days ago) Mar 20
to Maggie Chen, Avi Drissman, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Maggie Chen
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Maggie Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 20, 2026, 3:31:50 PM (13 days ago) Mar 20
to Maggie Chen, Avi Drissman, Etienne Pierre-Doray, chromium...@chromium.org, mac-r...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Update DisplayLink TRACE EVENT on Mac
Add a trace event for vsync callback in vsync_provider_mac.
Update the trace event category for CADisplayLink and CVDisplayLink.
Bug: 345275139
Change-Id: I094cb5ebc8149862b4c3a967da3d05f96fcf32c8
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Commit-Queue: Maggie Chen <mag...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1602774}
Files:
- M ui/display/mac/ca_display_link_mac.mm
- M ui/display/mac/cv_display_link_mac.mm
- M ui/display/mac/vsync_provider_mac.cc
Change size: XS
Delta: 3 files changed, 4 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray, +1 by Avi Drissman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages