Revert "[tracing] Fill typed fields in chrome metadata" [chromium/src : main]
0 views
Skip to first unread message
Fuhsin Liao (Gerrit)
Apr 17, 2026, 12:28:41 AM (10 days ago) Apr 17
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Robert Kaplow, Mikhail Khokhlov, Etienne Pierre-Doray, Dave Tapuska, Nate Fischer, chromium...@chromium.org, Chromium Metrics Reviews, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com
Attention needed from Dave Tapuska, Etienne Pierre-Doray, Mikhail Khokhlov, Nate Fischer and Robert Kaplow
Fuhsin Liao voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Dave Tapuska
- Etienne Pierre-Doray
- Mikhail Khokhlov
- Nate Fischer
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fuhsin Liao (Gerrit)
Apr 17, 2026, 12:28:51 AM (10 days ago) Apr 17
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Robert Kaplow, Mikhail Khokhlov, Etienne Pierre-Doray, Dave Tapuska, Nate Fischer, chromium...@chromium.org, Chromium Metrics Reviews, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com
Attention needed from Dave Tapuska, Etienne Pierre-Doray, Mikhail Khokhlov, Nate Fischer and Robert Kaplow
Fuhsin Liao voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Dave Tapuska
- Etienne Pierre-Doray
- Mikhail Khokhlov
- Nate Fischer
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Apr 17, 2026, 12:30:01 AM (10 days ago) Apr 17
to Fuhsin Liao, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Robert Kaplow, Mikhail Khokhlov, Etienne Pierre-Doray, Dave Tapuska, Nate Fischer, chromium...@chromium.org, Chromium Metrics Reviews, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com
Attention needed from Dave Tapuska, Etienne Pierre-Doray, Fuhsin Liao, Mikhail Khokhlov, Nate Fischer and Robert Kaplow
rubber-...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
Attention is currently required from:
- Dave Tapuska
- Etienne Pierre-Doray
- Fuhsin Liao
- Mikhail Khokhlov
- Nate Fischer
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 17, 2026, 12:30:09 AM (10 days ago) Apr 17
to Fuhsin Liao, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Robert Kaplow, Mikhail Khokhlov, Etienne Pierre-Doray, Dave Tapuska, Nate Fischer, chromium...@chromium.org, Chromium Metrics Reviews, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[tracing] Fill typed fields in chrome metadata"
This reverts commit 853791da0a00051fb3c92ca2a720a613afde647e.
Reason for revert: This cl has caused multiple builders to fail, failing builders: android-arm-tests, android-14-arm64-rel-tests. First failing build": https://ci.chromium.org/ui/p/chrome/builders/ci/android-arm-tests/37173/overview
Original change's description:
> [tracing] Fill typed fields in chrome metadata
>
> This CL fills a few typed fields in ChromeMetadataPack that we added in
> https://github.com/google/perfetto/commit/fe9b2f932a1cf9d104e6b49ee3acbf173997062c
>
> Bug: b/432275929
> Change-Id: I5ab8251de147d6126d2b2e2ea869d17496ae9beb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7748943
> Reviewed-by: Dave Tapuska <dtap...@chromium.org>
> Reviewed-by: Robert Kaplow <rka...@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Reviewed-by: Mikhail Khokhlov <khok...@google.com>
> Reviewed-by: Nate Fischer <ntf...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1615992}
Bug: b/432275929
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I20120ee4a6f4d37b93ad40c8815cdbddc5309812
Owners-Override: Fuhsin Liao <fuhsi...@google.com>
Auto-Submit: Fuhsin Liao <fuhsi...@google.com>
Reviewed-by: Fuhsin Liao <fuhsi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1616327}
Files:
- M android_webview/browser/tracing/aw_tracing_delegate.cc
- M android_webview/browser/tracing/aw_tracing_delegate.h
- M chrome/browser/tracing/chrome_tracing_delegate.cc
- M chrome/browser/tracing/chrome_tracing_delegate.h
- M components/metrics/metrics_log.cc
- M components/metrics/version_utils.cc
- M components/metrics/version_utils.h
- M components/tracing/common/system_profile_metadata_recorder.cc
- M components/tracing/common/system_profile_metadata_recorder.h
- M content/browser/tracing/tracing_controller_impl.cc
- M content/public/browser/tracing_delegate.cc
- M content/public/browser/tracing_delegate.h
- M services/tracing/public/cpp/perfetto/metadata_data_source.cc
- M services/tracing/public/cpp/perfetto/metadata_data_source.h
Change size: M
Delta: 14 files changed, 61 insertions(+), 113 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fuhsin Liao, Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages