Glic: Add metric for webui initialization [chromium/src : main]

0 views
Skip to first unread message

Aldo Culquicondor (Gerrit)

unread,
Mar 31, 2026, 11:15:05 AM (2 days ago) Mar 31
to Chromium Metrics Reviews, Roger McFarlane, Chromium LUCI CQ, Dan Harrington, AyeAye, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, dewitt...@chromium.org, asvitkine...@chromium.org
Attention needed from Dan Harrington and Roger McFarlane

Aldo Culquicondor added 1 comment

File chrome/browser/glic/service/metrics/glic_instance_metrics.cc
Line 621, Patchset 3: base::TimeDelta start_time = web_ui_load_start_time_ - creation_time_;
Dan Harrington . resolved

the glic instance lifetime is different than that of the web contents, so creation_time_ is the wrong starting point.

Aldo Culquicondor

Moved in a completely new direction.

Open in Gerrit

Related details

Attention is currently required from:
  • Dan Harrington
  • Roger McFarlane
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3124c26c9c630d19f381826edec192887fea43bb
Gerrit-Change-Number: 7711298
Gerrit-PatchSet: 4
Gerrit-Owner: Aldo Culquicondor <aco...@chromium.org>
Gerrit-Reviewer: Aldo Culquicondor <aco...@chromium.org>
Gerrit-Reviewer: Dan Harrington <harri...@chromium.org>
Gerrit-Reviewer: Roger McFarlane <rog...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Roger McFarlane <rog...@chromium.org>
Gerrit-Attention: Dan Harrington <harri...@chromium.org>
Gerrit-Comment-Date: Tue, 31 Mar 2026 15:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dan Harrington <harri...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Roger McFarlane (Gerrit)

unread,
Mar 31, 2026, 11:16:42 AM (2 days ago) Mar 31
to Aldo Culquicondor, Chromium Metrics Reviews, Chromium LUCI CQ, Dan Harrington, AyeAye, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, dewitt...@chromium.org, asvitkine...@chromium.org
Attention needed from Dan Harrington

Roger McFarlane added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Roger McFarlane . unresolved

histograms.xml

  • LGTM

CL Description

From the time of the Glic instance creation until entering the
kBeginLoad state.

This seems like an incomplete sentence? Should it start with "This CL adds metrics capturing the duration from the time..."

Even better would be something like:

```
Glic: Add metric for webui initialization.

This CL adds the following metrics:

  • Foo - Captures the time, in units, it takes to Foo, from creating to commit.
  • Bar - Captures the time, in units, it takes to Bar, from load starts, to commit.
  • ```
Open in Gerrit

Related details

Attention is currently required from:
  • Dan Harrington
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3124c26c9c630d19f381826edec192887fea43bb
    Gerrit-Change-Number: 7711298
    Gerrit-PatchSet: 4
    Gerrit-Owner: Aldo Culquicondor <aco...@chromium.org>
    Gerrit-Reviewer: Aldo Culquicondor <aco...@chromium.org>
    Gerrit-Reviewer: Dan Harrington <harri...@chromium.org>
    Gerrit-Reviewer: Roger McFarlane <rog...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Dan Harrington <harri...@chromium.org>
    Gerrit-Comment-Date: Tue, 31 Mar 2026 15:16:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dan Harrington (Gerrit)

    unread,
    Mar 31, 2026, 11:21:42 AM (2 days ago) Mar 31
    to Aldo Culquicondor, Dan Harrington, Chromium Metrics Reviews, Roger McFarlane, Chromium LUCI CQ, AyeAye, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, dewitt...@chromium.org, asvitkine...@chromium.org
    Attention needed from Aldo Culquicondor

    Dan Harrington voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aldo Culquicondor
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3124c26c9c630d19f381826edec192887fea43bb
      Gerrit-Change-Number: 7711298
      Gerrit-PatchSet: 4
      Gerrit-Owner: Aldo Culquicondor <aco...@chromium.org>
      Gerrit-Reviewer: Aldo Culquicondor <aco...@chromium.org>
      Gerrit-Reviewer: Dan Harrington <harri...@chromium.org>
      Gerrit-Reviewer: Roger McFarlane <rog...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Aldo Culquicondor <aco...@chromium.org>
      Gerrit-Comment-Date: Tue, 31 Mar 2026 15:21:27 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages