PA: Record type_id and size at intended leak [chromium/src : main]

6 views
Skip to first unread message

Takashi Sakamoto (Gerrit)

unread,
Jun 25, 2026, 3:31:50 AM (8 days ago) Jun 25
to Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, gavinp...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Keishi Hattori

Takashi Sakamoto added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Takashi Sakamoto . resolved

Would you review this CL?

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icbc80acc770d8ce8352c7ef858c884284ce971f0
Gerrit-Change-Number: 7931207
Gerrit-PatchSet: 7
Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Jun 2026 07:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Keishi Hattori (Gerrit)

unread,
Jun 25, 2026, 3:54:19 AM (8 days ago) Jun 25
to Takashi Sakamoto, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, gavinp...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Takashi Sakamoto

Keishi Hattori added 1 comment

File base/allocator/partition_allocator/src/partition_alloc/partition_root.h
Line 940, Patchset 7 (Latest): GetSlotSizeFromRequestedSizeForTesting(size_t requested_size);
Keishi Hattori . unresolved

Unnecessary duplicate declaration?

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Sakamoto
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icbc80acc770d8ce8352c7ef858c884284ce971f0
    Gerrit-Change-Number: 7931207
    Gerrit-PatchSet: 7
    Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: Takashi Sakamoto <ta...@google.com>
    Gerrit-Comment-Date: Thu, 25 Jun 2026 07:53:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Takashi Sakamoto (Gerrit)

    unread,
    Jun 28, 2026, 10:49:15 PM (5 days ago) Jun 28
    to Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, gavinp...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
    Attention needed from Keishi Hattori

    Takashi Sakamoto added 2 comments

    Patchset-level comments
    File-level comment, Patchset 8 (Latest):
    Takashi Sakamoto . resolved

    Thank you for the review.

    File base/allocator/partition_allocator/src/partition_alloc/partition_root.h
    Line 940, Patchset 7: GetSlotSizeFromRequestedSizeForTesting(size_t requested_size);
    Keishi Hattori . resolved

    Unnecessary duplicate declaration?

    Takashi Sakamoto

    Thank you. I missed this. Removed.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keishi Hattori
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Icbc80acc770d8ce8352c7ef858c884284ce971f0
      Gerrit-Change-Number: 7931207
      Gerrit-PatchSet: 8
      Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
      Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
      Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
      Gerrit-Comment-Date: Mon, 29 Jun 2026 02:49:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Keishi Hattori <kei...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Keishi Hattori (Gerrit)

      unread,
      Jun 29, 2026, 3:25:35 AM (4 days ago) Jun 29
      to Takashi Sakamoto, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, gavinp...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
      Attention needed from Takashi Sakamoto

      Keishi Hattori voted and added 1 comment

      Votes added by Keishi Hattori

      Code-Review+1

      1 comment

      Patchset-level comments
      Keishi Hattori . resolved

      LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Takashi Sakamoto
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Icbc80acc770d8ce8352c7ef858c884284ce971f0
        Gerrit-Change-Number: 7931207
        Gerrit-PatchSet: 8
        Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
        Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
        Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-Attention: Takashi Sakamoto <ta...@google.com>
        Gerrit-Comment-Date: Mon, 29 Jun 2026 07:25:10 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Takashi Sakamoto (Gerrit)

        unread,
        Jun 29, 2026, 3:29:32 AM (4 days ago) Jun 29
        to Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, gavinp...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

        Takashi Sakamoto added 1 comment

        Patchset-level comments
        Takashi Sakamoto . resolved

        Thank you for the review.

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Icbc80acc770d8ce8352c7ef858c884284ce971f0
        Gerrit-Change-Number: 7931207
        Gerrit-PatchSet: 8
        Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
        Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
        Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-Comment-Date: Mon, 29 Jun 2026 07:29:23 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        open
        diffy

        Takashi Sakamoto (Gerrit)

        unread,
        Jun 29, 2026, 3:29:35 AM (4 days ago) Jun 29
        to Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, gavinp...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

        Takashi Sakamoto voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Icbc80acc770d8ce8352c7ef858c884284ce971f0
        Gerrit-Change-Number: 7931207
        Gerrit-PatchSet: 8
        Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
        Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
        Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-Comment-Date: Mon, 29 Jun 2026 07:29:27 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jun 29, 2026, 3:37:20 AM (4 days ago) Jun 29
        to Takashi Sakamoto, Keishi Hattori, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, gavinp...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        PA: Record type_id and size at intended leak

        Add unordered_map whose keys are LeakedSecurityObjects' `type id` and
        values are total sizes of leaked memory per the `type id`.
        Bug: 501113274
        Change-Id: Icbc80acc770d8ce8352c7ef858c884284ce971f0
        Commit-Queue: Takashi Sakamoto <ta...@google.com>
        Reviewed-by: Keishi Hattori <kei...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1653895}
        Files:
        • M base/allocator/partition_allocator/src/partition_alloc/BUILD.gn
        • A base/allocator/partition_allocator/src/partition_alloc/intended_leak.cc
        • M base/allocator/partition_allocator/src/partition_alloc/internal/partition_root_internal.h
        • M base/allocator/partition_allocator/src/partition_alloc/partition_root.cc
        • M base/allocator/partition_allocator/src/partition_alloc/partition_root.h
        • M base/allocator/partition_allocator/src/partition_alloc/partition_stats.h
        Change size: M
        Delta: 6 files changed, 125 insertions(+), 17 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Keishi Hattori
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Icbc80acc770d8ce8352c7ef858c884284ce971f0
        Gerrit-Change-Number: 7931207
        Gerrit-PatchSet: 9
        Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
        Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages