Remove some deprecated base::JSONWriter::Write() calls in //base [chromium/src : main]
0 views
Skip to first unread message
Alan Cutter (Gerrit)
Sep 5, 2025, 1:50:56 AM (5 days ago) Sep 5
to Lei Zhang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Lei Zhang
Alan Cutter voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Sep 5, 2025, 2:06:57 AM (5 days ago) Sep 5
to Lei Zhang, Alan Cutter, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 5, 2025, 2:09:40 AM (5 days ago) Sep 5
to Lei Zhang, Alan Cutter, AyeAye, chromium...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove some deprecated base::JSONWriter::Write() calls in //base
Mechanically switch from base::JSONWriter::Write() to base::WriteJson().
Keep the existing behavior for all callers. So if a caller does not
check the Write() return result, then return an empty string on failure.
Change-Id: I30e451a8c22e216c6f8479fcda87ee171602d9aa
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Alan Cutter <alanc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511325}
Files:
- M base/task/sequence_manager/sequence_manager_impl.cc
- M base/test/launcher/test_results_tracker.cc
- M base/test/values_test_util.cc
- M base/trace_event/trace_config.cc
Change size: S
Delta: 4 files changed, 10 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alan Cutter
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Sep 5, 2025, 3:22:03 AM (5 days ago) Sep 5
to Chromium LUCI CQ, Lei Zhang, Alan Cutter, AyeAye, chromium...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages