ODMS Perf: Add perfetto tracing to LanguageModel [chromium/src : main]
AI Code Reviewer (Gerrit)
AI Code Reviewer added 1 comment![]( "Open in Gerrit")
const perfetto::Track& perfetto_id() { return perfetto_id_; }nit: Blink Style Guide: Naming - Use 'CamelCase' for all function names. Please rename `perfetto_id()` to `PerfettoId()` to match the naming convention used by the rest of the file.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Memmott (Gerrit)
Nathan Memmott added 1 comment![]( "Open in Gerrit")
const perfetto::Track& perfetto_id() { return perfetto_id_; }nit: Blink Style Guide: Naming - Use 'CamelCase' for all function names. Please rename `perfetto_id()` to `PerfettoId()` to match the naming convention used by the rest of the file.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Done
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steven Holte (Gerrit)
Steven Holte added 1 comment![]( "Open in Gerrit")
PerfettoId());I think you probably want a Flow rather than a Track, with regular rather than async events.
perfetto::Flow::FromPointer(this)
perfetto::TerminatingFlow::FromPointer(this)
Related details
- Nathan Memmott
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |