Spanification of base/trace_event/trace_arguments.cc, etc. [chromium/src : main]

0 views

Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,

Jun 26, 2026, 4:21:00 AM (7 days ago) Jun 26

to Daniel Angulo, Stephen Nusko, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, bartek...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Daniel Angulo and Stephen Nusko

Arthur Sonzogni voted and added 1 comment

Votes added by Arthur Sonzogni

Code-Review

1 comment

File base/allocator/partition_allocator/src/partition_alloc/partition_root.cc

Line 1586, Patchset 2 (Latest):

  std::array<PartitionBucketMemoryStats, BucketIndexLookup::kNumBuckets>
      bucket_stats;

Arthur Sonzogni . unresolved

Optional: There are a couple of PA_UNSAFE_TODO in the code that could be removed.
We can do it now if we want, or wait for a subsequent global removal using the script.

---

About performance, I am assuming this is equivalent, because we are already enforcing bound checks in T[] at the compiler level.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Angulo
Stephen Nusko

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stephen Nusko (Gerrit)

unread,

Jun 28, 2026, 10:11:34 PM (5 days ago) Jun 28

to Daniel Angulo, Arthur Sonzogni, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, bartek...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Daniel Angulo

Stephen Nusko added 1 comment

Commit Message

Line 7, Patchset 2 (Latest):Spanification of base/trace_event/trace_arguments.cc, etc.

Stephen Nusko . unresolved

This commit message is also incorrect