Reduce size of chrome_track_event descriptor [chromium/src : main]
3 views
Skip to first unread message
Daniele Di Proietto (Gerrit)
Oct 28, 2025, 12:30:31 PM (13 days ago) Oct 28
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and Joe Mason
Daniele Di Proietto voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Oct 28, 2025, 12:58:31 PM (13 days ago) Oct 28
to Daniele Di Proietto, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniele Di Proietto and Joe Mason
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Daniele Di Proietto
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Oct 28, 2025, 5:47:09 PM (13 days ago) Oct 28
to Daniele Di Proietto, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniele Di Proietto and Etienne Pierre-Doray
Joe Mason voted![]( "Open in Gerrit")
Attention is currently required from:
- Daniele Di Proietto
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 28, 2025, 5:50:16 PM (13 days ago) Oct 28
to Daniele Di Proietto, Etienne Pierre-Doray, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reduce size of chrome_track_event descriptor
The chrome_track_event descriptor also includes the
`track_event.proto`, which is already included by the basic trace
descriptor in trace processor.
We can use the same build tricks introduced in
https://github.com/google/perfetto/pull/3365 to remove the redundant
files and reduce the size by roughly 25 Kb.
Change-Id: I6c458da849dab90269b02c9da0ddab6f0fb7c13c
Reviewed-by: Joe Mason <joenot...@google.com>
Auto-Submit: Daniele Di Proietto <ddipr...@google.com>
Commit-Queue: Joe Mason <joenot...@google.com>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536907}
Files:
- M base/tracing/protos/BUILD.gn
- M base/tracing/protos/resources.grd
- M content/browser/tracing/tracing_controller_impl.cc
Change size: S
Delta: 3 files changed, 17 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Mason, +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages