Add tracing to Digital Credentials API create() flow [chromium/src : main]

1 view
Skip to first unread message

Christian Biesinger (Gerrit)

unread,
Jan 5, 2026, 1:50:39 PMJan 5
to Anushka Kulkarni, AyeAye, Mohamed Amir Yosef, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Anushka Kulkarni, Mohamed Amir Yosef and Tejas Dhagawkar

Christian Biesinger added 3 comments

Commit Message
Line 9, Patchset 3 (Latest):This CL introduces Perfetto-based tracing in the Digital Credentials API browser-side implementation for the create() method. The tracing captures critical points in the request lifecycle to aid debugging and performance
Christian Biesinger . unresolved

please wrap this line

File base/trace_event/builtin_categories.h
Line 119, Patchset 3 (Latest): "Traces for the Digital Credntials API"),
Christian Biesinger . unresolved

typo

File third_party/blink/renderer/modules/credentialmanagement/digital_identity_credential.cc
Line 85, Patchset 3 (Latest): TRACE_EVENT_INSTANT("content.digitalcredentials", "OnCompleteRequest:Get",
Christian Biesinger . unresolved

since this is now not in an if block anymore, you no longer need the _INSTANT

Open in Gerrit

Related details

Attention is currently required from:
  • Anushka Kulkarni
  • Mohamed Amir Yosef
  • Tejas Dhagawkar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
Gerrit-Change-Number: 7253960
Gerrit-PatchSet: 3
Gerrit-Owner: Anushka Kulkarni <anusku...@microsoft.com>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Tejas Dhagawkar <tdhag...@microsoft.com>
Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
Gerrit-Attention: Mohamed Amir Yosef <ma...@chromium.org>
Gerrit-Attention: Anushka Kulkarni <anusku...@microsoft.com>
Gerrit-Comment-Date: Mon, 05 Jan 2026 18:50:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anushka Kulkarni (Gerrit)

unread,
Jan 12, 2026, 4:02:50 AMJan 12
to AyeAye, Mohamed Amir Yosef, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Christian Biesinger, Mohamed Amir Yosef and Tejas Dhagawkar

Anushka Kulkarni added 3 comments

Commit Message
Line 9, Patchset 3:This CL introduces Perfetto-based tracing in the Digital Credentials API browser-side implementation for the create() method. The tracing captures critical points in the request lifecycle to aid debugging and performance
Christian Biesinger . resolved

please wrap this line

Anushka Kulkarni

Done

File base/trace_event/builtin_categories.h
Line 119, Patchset 3: "Traces for the Digital Credntials API"),
Christian Biesinger . resolved

typo

Anushka Kulkarni

Done

File third_party/blink/renderer/modules/credentialmanagement/digital_identity_credential.cc
Line 85, Patchset 3: TRACE_EVENT_INSTANT("content.digitalcredentials", "OnCompleteRequest:Get",
Christian Biesinger . resolved

since this is now not in an if block anymore, you no longer need the _INSTANT

Anushka Kulkarni

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Christian Biesinger
  • Mohamed Amir Yosef
  • Tejas Dhagawkar
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
      Gerrit-Change-Number: 7253960
      Gerrit-PatchSet: 6
      Gerrit-Owner: Anushka Kulkarni <anusku...@microsoft.com>
      Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
      Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
      Gerrit-CC: Kaan Icer <ic...@chromium.org>
      Gerrit-CC: Tejas Dhagawkar <tdhag...@microsoft.com>
      Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
      Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
      Gerrit-Attention: Mohamed Amir Yosef <ma...@chromium.org>
      Gerrit-Comment-Date: Mon, 12 Jan 2026 09:02:18 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Christian Biesinger <cbies...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Mohamed Amir Yosef (Gerrit)

      unread,
      Jan 12, 2026, 8:07:11 AMJan 12
      to Anushka Kulkarni, AyeAye, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
      Attention needed from Anushka Kulkarni, Christian Biesinger and Tejas Dhagawkar

      Mohamed Amir Yosef added 1 comment

      File third_party/blink/renderer/modules/credentialmanagement/digital_identity_credential.cc
      Line 85, Patchset 7 (Latest): TRACE_EVENT("content.digitalcredentials", "OnCompleteRequest:Get", "status",
      Mohamed Amir Yosef . unresolved

      This is invoked both Get and Create flows.
      We have the same issue in the Get tracing CL.

      I do think we need to condition it on the request_type or make it generic (e.g. OnCompleteRequest)

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Anushka Kulkarni
      • Christian Biesinger
      • Tejas Dhagawkar
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
        Gerrit-Change-Number: 7253960
        Gerrit-PatchSet: 7
        Gerrit-Owner: Anushka Kulkarni <anusku...@microsoft.com>
        Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
        Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
        Gerrit-CC: Kaan Icer <ic...@chromium.org>
        Gerrit-CC: Tejas Dhagawkar <tdhag...@microsoft.com>
        Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
        Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
        Gerrit-Attention: Anushka Kulkarni <anusku...@microsoft.com>
        Gerrit-Comment-Date: Mon, 12 Jan 2026 13:06:55 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Anushka Kulkarni (Gerrit)

        unread,
        Jan 14, 2026, 1:52:51 AMJan 14
        to AyeAye, Mohamed Amir Yosef, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
        Attention needed from Christian Biesinger, Mohamed Amir Yosef and Tejas Dhagawkar

        Anushka Kulkarni added 1 comment

        File third_party/blink/renderer/modules/credentialmanagement/digital_identity_credential.cc
        Line 85, Patchset 7: TRACE_EVENT("content.digitalcredentials", "OnCompleteRequest:Get", "status",
        Mohamed Amir Yosef . resolved

        This is invoked both Get and Create flows.
        We have the same issue in the Get tracing CL.

        I do think we need to condition it on the request_type or make it generic (e.g. OnCompleteRequest)

        Anushka Kulkarni

        Made it generic as adding the conditions changes the scope of the traces.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Christian Biesinger
        • Mohamed Amir Yosef
        • Tejas Dhagawkar
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
          Gerrit-Change-Number: 7253960
          Gerrit-PatchSet: 8
          Gerrit-Owner: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
          Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
          Gerrit-CC: Kaan Icer <ic...@chromium.org>
          Gerrit-CC: Tejas Dhagawkar <tdhag...@microsoft.com>
          Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
          Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
          Gerrit-Attention: Mohamed Amir Yosef <ma...@chromium.org>
          Gerrit-Comment-Date: Wed, 14 Jan 2026 06:52:22 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Mohamed Amir Yosef <ma...@chromium.org>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Mohamed Amir Yosef (Gerrit)

          unread,
          Jan 15, 2026, 6:20:07 AMJan 15
          to Anushka Kulkarni, Chromium LUCI CQ, AyeAye, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
          Attention needed from Anushka Kulkarni, Christian Biesinger and Tejas Dhagawkar

          Mohamed Amir Yosef voted and added 1 comment

          Votes added by Mohamed Amir Yosef

          Code-Review+1

          1 comment

          Patchset-level comments
          Mohamed Amir Yosef . resolved

          LGTM

          But maybe rebase this on top of https://crrev.com/c/7127319 and some code will be disappear.
          Either do it now, or land one after the other!

          Thank you!

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Anushka Kulkarni
          • Christian Biesinger
          • Tejas Dhagawkar
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
          Gerrit-Change-Number: 7253960
          Gerrit-PatchSet: 8
          Gerrit-Owner: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Reviewer: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
          Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
          Gerrit-CC: Kaan Icer <ic...@chromium.org>
          Gerrit-CC: Tejas Dhagawkar <tdhag...@microsoft.com>
          Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
          Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
          Gerrit-Attention: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Comment-Date: Thu, 15 Jan 2026 11:19:52 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Mohamed Amir Yosef (Gerrit)

          unread,
          Jan 23, 2026, 4:03:40 AMJan 23
          to Anushka Kulkarni, Chromium LUCI CQ, AyeAye, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
          Attention needed from Anushka Kulkarni, Christian Biesinger and Tejas Dhagawkar

          Mohamed Amir Yosef voted and added 1 comment

          Votes added by Mohamed Amir Yosef

          Code-Review+1

          1 comment

          Patchset-level comments
          Mohamed Amir Yosef . resolved

          LGTM

          Thank you!

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Anushka Kulkarni
          • Christian Biesinger
          • Tejas Dhagawkar
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
          Gerrit-Change-Number: 7253960
          Gerrit-PatchSet: 10
          Gerrit-Owner: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Reviewer: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
          Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
          Gerrit-CC: Kaan Icer <ic...@chromium.org>
          Gerrit-CC: Tejas Dhagawkar <tdhag...@microsoft.com>
          Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
          Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
          Gerrit-Attention: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Comment-Date: Fri, 23 Jan 2026 09:03:23 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Mohamed Amir Yosef (Gerrit)

          unread,
          Jan 23, 2026, 4:11:09 AMJan 23
          to Anushka Kulkarni, Jan Keitel, Chromium LUCI CQ, AyeAye, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
          Attention needed from Anushka Kulkarni, Christian Biesinger, Jan Keitel and Tejas Dhagawkar

          Mohamed Amir Yosef added 1 comment

          Patchset-level comments
          Mohamed Amir Yosef . resolved

          Hi Jan,

          Could you please take a look?
          (We need another +1)

          Thank you,
          Mohamed

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Anushka Kulkarni
          • Christian Biesinger
          • Jan Keitel
          • Tejas Dhagawkar
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
          Gerrit-Change-Number: 7253960
          Gerrit-PatchSet: 10
          Gerrit-Owner: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Reviewer: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
          Gerrit-Reviewer: Jan Keitel <jke...@google.com>
          Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
          Gerrit-CC: Kaan Icer <ic...@chromium.org>
          Gerrit-CC: Tejas Dhagawkar <tdhag...@microsoft.com>
          Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
          Gerrit-Attention: Jan Keitel <jke...@google.com>
          Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
          Gerrit-Attention: Anushka Kulkarni <anusku...@microsoft.com>
          Gerrit-Comment-Date: Fri, 23 Jan 2026 09:10:51 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Jan Keitel (Gerrit)

          unread,
          Jan 23, 2026, 4:29:15 AMJan 23
          to Anushka Kulkarni, Mohamed Amir Yosef, Chromium LUCI CQ, AyeAye, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
          Attention needed from Anushka Kulkarni, Christian Biesinger and Tejas Dhagawkar

          Jan Keitel voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Anushka Kulkarni
          • Christian Biesinger
          • Tejas Dhagawkar
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
            Gerrit-Change-Number: 7253960
            Gerrit-PatchSet: 10
            Gerrit-Owner: Anushka Kulkarni <anusku...@microsoft.com>
            Gerrit-Reviewer: Anushka Kulkarni <anusku...@microsoft.com>
            Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
            Gerrit-Reviewer: Jan Keitel <jke...@google.com>
            Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
            Gerrit-CC: Kaan Icer <ic...@chromium.org>
            Gerrit-CC: Tejas Dhagawkar <tdhag...@microsoft.com>
            Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
            Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
            Gerrit-Attention: Anushka Kulkarni <anusku...@microsoft.com>
            Gerrit-Comment-Date: Fri, 23 Jan 2026 09:29:01 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Mohamed Amir Yosef (Gerrit)

            unread,
            Jan 23, 2026, 4:31:31 AMJan 23
            to Anushka Kulkarni, Jan Keitel, Chromium LUCI CQ, AyeAye, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
            Attention needed from Anushka Kulkarni, Christian Biesinger and Tejas Dhagawkar

            Mohamed Amir Yosef voted Commit-Queue+2

            Commit-Queue+2
            Gerrit-Comment-Date: Fri, 23 Jan 2026 09:31:17 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Chromium LUCI CQ (Gerrit)

            unread,
            Jan 23, 2026, 6:11:55 AMJan 23
            to Anushka Kulkarni, Mohamed Amir Yosef, Jan Keitel, AyeAye, Christian Biesinger, Tejas Dhagawkar, chromium...@chromium.org, Kaan Icer, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org

            Chromium LUCI CQ submitted the change

            Change information

            Commit message:
            Add tracing to Digital Credentials API create() flow


            This CL introduces Perfetto-based tracing in the Digital Credentials API
            browser-side implementation for the create() method. The tracing
            captures critical points in the request lifecycle to aid debugging and
            performance analysis.

            Trace category: "content.digitalcredentials"
            Bug: 464296286
            Test: Verified with Perfetto UI on Android emulator.
            Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
            Reviewed-by: Jan Keitel <jke...@google.com>
            Reviewed-by: Mohamed Amir Yosef <ma...@chromium.org>
            Commit-Queue: Mohamed Amir Yosef <ma...@chromium.org>
            Cr-Commit-Position: refs/heads/main@{#1573593}
            Files:
            • M chrome/browser/digital_credentials/digital_identity_provider_android.cc
            • M content/browser/digital_credentials/digital_identity_request_impl.cc
            • M third_party/blink/renderer/modules/credentialmanagement/digital_identity_credential.cc
            Change size: XS
            Delta: 3 files changed, 7 insertions(+), 0 deletions(-)
            Branch: refs/heads/main
            Submit Requirements:
            • requirement satisfiedCode-Review: +1 by Jan Keitel, +1 by Mohamed Amir Yosef
            Open in Gerrit
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: merged
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ie7ad3f7bfac0ae39a958972ea8256386d76d350a
            Gerrit-Change-Number: 7253960
            Gerrit-PatchSet: 11
            Gerrit-Owner: Anushka Kulkarni <anusku...@microsoft.com>
            Gerrit-Reviewer: Anushka Kulkarni <anusku...@microsoft.com>
            Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Jan Keitel <jke...@google.com>
            Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
            open
            diffy
            satisfied_requirement
            Reply all
            Reply to author
            Forward
            0 new messages