[tracing] Skip v8 categories if perfetto is disabled in v8 [chromium/src : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
Jan 21, 2026, 3:44:55 AMJan 21
to Chromium LUCI CQ, Etienne Pierre-Doray, Camillo Bruni, chromium...@chromium.org, Michael Achenbach, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jan 21, 2026, 7:23:37 AMJan 21
to Clemens Backes, Chromium LUCI CQ, Camillo Bruni, chromium...@chromium.org, Michael Achenbach, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Clemens Backes
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Jan 21, 2026, 7:36:16 AMJan 21
to Etienne Pierre-Doray, Chromium LUCI CQ, Camillo Bruni, chromium...@chromium.org, Michael Achenbach, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 21, 2026, 7:40:28 AMJan 21
to Clemens Backes, Etienne Pierre-Doray, Camillo Bruni, chromium...@chromium.org, Michael Achenbach, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Skip v8 categories if perfetto is disabled in v8
This is a prerequisite for relanding https://crrev.com/c/7497812, which
again is a prerequisite for enabling https://crrev.com/c/7485635.
The `V8_USE_PERFETTO` preprocessor macro is listed in
`external_v8_defines` and is already being used in multiple public V8
headers, so we can also use it in chromium directly.
See linked bug for context.
R=etie...@chromium.org
CC=cbr...@chromium.org, mache...@chromium.org
Bug: 476343968
Change-Id: I76d558d8828b636a96182ba4c5e12b358f56efea
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572225}
Files:
- M content/browser/tracing/traces_internals/traces_internals_handler.cc
- M content/browser/tracing/tracing_controller_impl.cc
Change size: XS
Delta: 2 files changed, 6 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages