Optimize memory module infromation in memory-infra. 1. In ReportPartitionAllocStats function, variable total_virtual_size should add total_mmapped_bytes that is the sum of super_pages and direct mapped page, rather than add total_resident_bytes. 2.For win_heap, provide allocated_objects_size, virtual_size and virtual_committed_size infromation, it help us to better identify the memory issues. [chromium/src : main]

0 views
Skip to first unread message

Eric Seckler (Gerrit)

unread,
Aug 28, 2025, 10:57:26 AM (12 days ago) Aug 28
to 鹏强王, Benoit Lize, Mikhail Khokhlov, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Benoit Lize, Mikhail Khokhlov and 鹏强王

Eric Seckler added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Eric Seckler . unresolved

Benoit, you might actually be most familiar with what would be accurate in this context -- Do you have a take? 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Benoit Lize
  • Mikhail Khokhlov
  • 鹏强王
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9c3025a813851dddf293ae0b403ddd59e5c73976
Gerrit-Change-Number: 6896356
Gerrit-PatchSet: 1
Gerrit-Owner: 鹏强王 <wangpe...@bytedance.com>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
Gerrit-Attention: 鹏强王 <wangpe...@bytedance.com>
Gerrit-Attention: Mikhail Khokhlov <khok...@google.com>
Gerrit-Attention: Benoit Lize <li...@chromium.org>
Gerrit-Comment-Date: Thu, 28 Aug 2025 14:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages