fix UNSAFE_TODO's in trace_logging [chromium/src : main]
0 views
Skip to first unread message
David Bienvenu (Gerrit)
Dec 29, 2025, 9:28:40 AM (14 days ago) 12/29/25
to Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Petr Cermak
David Bienvenu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Petr Cermak
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Petr Cermak (Gerrit)
Jan 6, 2026, 6:52:13 AM (6 days ago) Jan 6
to David Bienvenu, Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from David Bienvenu
Petr Cermak voted and added 1 comment![]( "Open in Gerrit")
Votes added by Petr Cermak
| Code-Review | +1 |
1 comment
File base/trace_event/trace_logging_minimal_win.cc
Line 228, Patchset 2 (Latest):
descriptors[1].Size = static_cast<ULONG>(meta_data_index);Petr Cermak . unresolved
Is this cast needed? It seems that this CL doesn't change the type of `meta_data_index`, so it seems potentially unrelated.
Related details
Attention is currently required from:
- David Bienvenu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Bienvenu (Gerrit)
Jan 6, 2026, 6:21:33 PM (5 days ago) Jan 6
to Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
David Bienvenu added 1 comment![]( "Open in Gerrit")
File base/trace_event/trace_logging_minimal_win.cc
Line 228, Patchset 2:
descriptors[1].Size = static_cast<ULONG>(meta_data_index);Petr Cermak . resolved
Is this cast needed? It seems that this CL doesn't change the type of `meta_data_index`, so it seems potentially unrelated.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Bienvenu (Gerrit)
Jan 6, 2026, 6:21:40 PM (5 days ago) Jan 6
to Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
David Bienvenu voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 6, 2026, 7:03:58 PM (5 days ago) Jan 6
to David Bienvenu, Petr Cermak, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: base/trace_event/trace_logging_minimal_win.cc
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
fix UNSAFE_TODO's in trace_logging
use base::span to fix UNSAFE_TODO's in trace_logging_minimal_win.cc
Bug: 42271176
Change-Id: Ib773cd73a9478dac3a41bf24542240b1e04d415b
Reviewed-by: Petr Cermak <petrc...@chromium.org>
Commit-Queue: David Bienvenu <davidb...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1565332}
Files:
- M base/trace_event/etw_interceptor_win.cc
- M base/trace_event/trace_logging_minimal_win.cc
- M base/trace_event/trace_logging_minimal_win.h
Change size: M
Delta: 3 files changed, 41 insertions(+), 44 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Petr Cermak
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jan 7, 2026, 5:31:17 PM (4 days ago) Jan 7
to Chromium LUCI CQ, David Bienvenu, Petr Cermak, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from David Bienvenu
Tom Sepez added 1 comment![]( "Open in Gerrit")
File base/trace_event/etw_interceptor_win.cc
Line 356, Patchset 4 (Latest):
base::span(descriptors_),Tom Sepez . unresolved
Thanks for the CL!
drive-by: nit: The compiler should be able to deduce the conversion to span, so writing `descriptors_` directly should work. If not, I see this is an absl:: vector type, and there would be work to do to figure out why the compiler didn't deduce this.
Related details
Attention is currently required from:
- David Bienvenu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages