[tracing] Remove histogram snapshot in traces [chromium/src : main]

2 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Aug 28, 2025, 12:09:24 PM (12 days ago) Aug 28
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Mikhail Khokhlov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7261171ce31a9b9f618752fbb4ccea8e67cf7efa
Gerrit-Change-Number: 6896906
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
Gerrit-Attention: Mikhail Khokhlov <khok...@google.com>
Gerrit-Comment-Date: Thu, 28 Aug 2025 16:09:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mikhail Khokhlov (Gerrit)

unread,
Aug 28, 2025, 1:14:06 PM (12 days ago) Aug 28
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Mikhail Khokhlov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7261171ce31a9b9f618752fbb4ccea8e67cf7efa
    Gerrit-Change-Number: 6896906
    Gerrit-PatchSet: 4
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Thu, 28 Aug 2025 17:13:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Aug 28, 2025, 1:33:42 PM (12 days ago) Aug 28
    to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Etienne Pierre-Doray voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7261171ce31a9b9f618752fbb4ccea8e67cf7efa
    Gerrit-Change-Number: 6896906
    Gerrit-PatchSet: 4
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    Gerrit-Comment-Date: Thu, 28 Aug 2025 17:33:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 28, 2025, 1:53:58 PM (12 days ago) Aug 28
    to Etienne Pierre-Doray, Mikhail Khokhlov, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [tracing] Remove histogram snapshot in traces

    All of telemetry histograms and alerts were moved to TBMv3.
    This is no longer needed.
    Bug: 434242373
    Change-Id: I7261171ce31a9b9f618752fbb4ccea8e67cf7efa
    Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    Reviewed-by: Mikhail Khokhlov <khok...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1507869}
    Files:
    • M services/tracing/public/cpp/perfetto/custom_event_recorder.cc
    • M services/tracing/public/cpp/perfetto/custom_event_recorder.h
    • M services/tracing/public/cpp/perfetto/perfetto_config.cc
    Change size: M
    Delta: 3 files changed, 3 insertions(+), 86 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mikhail Khokhlov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7261171ce31a9b9f618752fbb4ccea8e67cf7efa
    Gerrit-Change-Number: 6896906
    Gerrit-PatchSet: 5
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages