update authors [chromium/src : main]

0 views

Skip to first unread message

unread,

Jun 21, 2024, 12:36:52 PM (10 days ago) Jun 21

to Johnson Adodo, chromium...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Johnson Adodo

Tom Sepez added 3 comments

Patchset-level comments

Tom Sepez . resolved

Hi, welcome, the code is fine but the commit message needs a little tidying.

Commit Message

Line 10, Patchset 1 (Latest):swap unique_ptr for HeapArray

Tom Sepez . unresolved

This should be the first sentence, e.g. the CL desciption

Swap unique_ptr<[]> for HeapArray<> in test_utils.h

Tom Sepez . unresolved

The follow-up should be something like

-- add self to authors file.

Attention is currently required from:

Submit Requirements:

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages