Remove superfluous file_util.h includes in various directories [chromium/src : main]

[Lei Zhang (Gerrit)]

Attention needed from Daniel Cheng

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I892d46ace056492fbf97d509be82a7d3cdb05b62

Gerrit-Change-Number: 7124288

Gerrit-PatchSet: 5

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sean Maher <sp...@chromium.org>

Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Fri, 07 Nov 2025 17:41:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Daniel Cheng (Gerrit)]

Attention needed from Lei Zhang

Daniel Cheng voted

Code-Review	+1
Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

• Lei Zhang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I892d46ace056492fbf97d509be82a7d3cdb05b62

Gerrit-Change-Number: 7124288

Gerrit-PatchSet: 5

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sean Maher <sp...@chromium.org>

Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Fri, 07 Nov 2025 18:46:54 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Lei Zhang (Gerrit)]

Attention needed from Daniel Cheng and Lei Zhang

Lei Zhang removed a vote from this change

Removed Commit-Queue+2 by Daniel Cheng <dch...@chromium.org>

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng
• Lei Zhang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: deleteVote

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I892d46ace056492fbf97d509be82a7d3cdb05b62

Gerrit-Change-Number: 7124288

Gerrit-PatchSet: 6

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sean Maher <sp...@chromium.org>

Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

[Lei Zhang (Gerrit)]

Attention needed from Daniel Cheng

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I892d46ace056492fbf97d509be82a7d3cdb05b62

Gerrit-Change-Number: 7124288

Gerrit-PatchSet: 6

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sean Maher <sp...@chromium.org>

Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Sat, 08 Nov 2025 00:05:37 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Daniel Cheng (Gerrit)]

Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Lei Zhang

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Sat, 08 Nov 2025 01:11:27 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Lei Zhang (Gerrit)]

Attention needed from Daniel Cheng

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Sat, 08 Nov 2025 01:41:48 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Lei Zhang (Gerrit)]

Attention needed from Daniel Cheng

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I892d46ace056492fbf97d509be82a7d3cdb05b62

Gerrit-Change-Number: 7124288

Gerrit-PatchSet: 7

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sean Maher <sp...@chromium.org>

Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Sat, 08 Nov 2025 04:38:42 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Lei Zhang (Gerrit)]

Gerrit-Comment-Date: Sun, 09 Nov 2025 04:37:14 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Lei Zhang (Gerrit)]

Lei Zhang submitted the change

Unreviewed changes

5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Remove superfluous file_util.h includes in various directories

Since base/files/file_util.h mostly contains a list of functions that
are labeled with BASE_EXPORT, one can make a list of these functions.
One can also easily make a list of files that include file_util.h. Then
for each file in the list, grep for the functions from the first list.
If there are no matches, then remove file_util.h with:

tools/add_header.py --header '"base/files/file_util.h"' --remove

Then do IWYU to fix the build.

Bug: 40318405

Change-Id: I892d46ace056492fbf97d509be82a7d3cdb05b62

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7124288

Auto-Submit: Lei Zhang <the...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1542285}

Files:

• M android_webview/browser/aw_browser_context_store.cc
• M android_webview/browser/aw_net_logs_connection.cc
• M android_webview/browser/variations/variations_seed_loader.cc
• M android_webview/common/aw_paths.cc
• M android_webview/nonembedded/component_updater/aw_component_installer_policy_shim_unittest.cc
• M ash/ambient/ambient_photo_controller.cc
• M ash/ambient/ambient_photo_controller_unittest.cc
• M ash/capture_mode/test_capture_mode_delegate.cc
• M ash/display/display_color_manager.cc
• M ash/quick_insert/views/quick_insert_list_item_view.cc
• M ash/quick_insert/views/quick_insert_list_item_view.h
• M ash/quick_insert/views/quick_insert_section_view.cc
• M ash/wallpaper/google_photos_wallpaper_manager.cc
• M ash/wallpaper/online_wallpaper_manager.cc
• M ash/webui/diagnostics_ui/backend/input/input_data_provider_keyboard.cc
• M ash/webui/help_app_ui/test/help_app_ui_browsertest.cc
• M base/base_paths_mac.mm
• M base/cpu.cc
• M base/debug/proc_maps_linux.cc
• M base/files/file_enumerator.cc
• M base/i18n/file_util_icu_unittest.cc
• M base/message_loop/fd_watch_controller_posix_unittest.cc
• M base/nix/xdg_util.cc
• M base/posix/unix_domain_socket_unittest.cc
• M base/process/internal_aix.cc
• M base/process/kill_mac.cc
• M base/process/kill_posix.cc
• M base/profiler/stack_sampling_profiler_unittest.cc
• M base/security_unittest.cc
• M base/test/launcher/unit_test_launcher_ios.cc
• M base/win/security_util_unittest.cc
• M base/win/win_includes_unittest.cc
• M cc/metrics/frame_info.cc
• M cc/test/pixel_test.h
• M device/bluetooth/bluetooth_low_energy_device_watcher_mac.mm
• M extensions/browser/api/web_request/web_request_info_unittest.cc
• M extensions/browser/content_hash_fetcher.cc
• M extensions/browser/content_hash_reader.cc
• M extensions/browser/updater/update_service.cc
• M extensions/common/manifest_handlers/icons_handler.cc
• M extensions/shell/browser/shell_extension_system.cc
• M fuchsia_web/runners/cast/api_bindings_client_browsertest.cc
• M fuchsia_web/runners/cast/cast_component.cc
• M fuchsia_web/runners/cast/cast_runner_integration_test.cc
• M fuchsia_web/runners/cast/named_message_port_connector_fuchsia_browsertest.cc
• M fuchsia_web/runners/common/web_content_runner.cc
• M fuchsia_web/webengine/browser/permissions_browsertest.cc
• M fuchsia_web/webengine/browser/web_engine_browser_context.cc
• M gpu/command_buffer/service/dawn_caching_interface_unittest.cc
• M gpu/command_buffer/service/gpu_persistent_cache_unittest.cc
• M gpu/command_buffer/tests/gl_helper_benchmark.cc
• M gpu/config/gpu_info_collector_win.cc
• M headless/test/headless_policy_browsertest.cc
• M ios/chrome/app/application_delegate/metric_kit_subscriber.mm
• M ios/chrome/app/application_delegate/metric_kit_subscriber_unittest.mm
• M ios/chrome/app/memory_monitor.mm
• M ios/chrome/browser/bring_android_tabs/model/bring_android_tabs_to_ios_service.mm
• M ios/chrome/browser/browser_view/ui_bundled/browser_coordinator_unittest.mm
• M ios/chrome/browser/crash_report/model/crash_helper.mm
• M ios/chrome/browser/download/model/ar_quick_look_tab_helper.mm
• M ios/chrome/browser/drive/model/drive_upload_task.mm
• M ios/chrome/browser/drive_file_picker/coordinator/drive_file_picker_mediator.mm
• M ios/chrome/browser/omnibox/eg_tests/omnibox_app_interface.mm
• M ios/chrome/browser/profile/model/profile_manager_ios_impl.mm
• M ios/chrome/browser/signin/model/signin_util_internal_unittest.mm
• M ios/chrome/browser/snapshots/model/legacy_snapshot_storage.mm
• M ios/chrome/browser/sync/model/prefs/sync_preferences_egtest.mm
• M ios/chrome/browser/translate/model/chrome_ios_translate_client_unittest.mm
• M ios/chrome/browser/web/model/chrome_web_client.mm
• M ios/chrome/browser/whats_new/ui/data_source/whats_new_data_source_unittest.mm
• M ios/net/cookies/cookie_store_ios.mm
• M media/base/android/media_codec_bridge_impl_unittest.cc
• M media/base/win/media_foundation_package_runtime_locator.cc
• M media/capture/video/chromeos/token_manager_unittest.cc
• M media/gpu/chromeos/image_processor_perf_test.cc
• M media/gpu/chromeos/image_processor_test.cc
• M media/gpu/chromeos/vulkan_overlay_adaptor_test.cc
• M media/gpu/test/video_decode_accelerator_tests.cc
• M media/gpu/test/video_encode_accelerator_tests.cc
• M media/gpu/v4l2/v4l2_stateful_video_decoder.cc
• M media/gpu/vaapi/vaapi_unittest.cc
• M media/gpu/vaapi/vaapi_wrapper.cc
• M net/base/filename_util.cc
• M net/base/filename_util_internal.cc
• M net/base/filename_util_unittest.cc
• M net/base/lookup_string_in_fixed_set_unittest.cc
• M net/cert/ct_serialization_unittest.cc
• M net/cert/internal/path_builder_trust_store_win_unittest.cc
• M net/cert/multi_log_ct_verifier_unittest.cc
• M net/disk_cache/disk_cache_fuzzer.cc
• M net/disk_cache/simple/simple_index.cc
• M net/dns/dns_config_service_linux_unittest.cc
• M net/dns/dns_config_service_posix_unittest.cc
• M net/extras/sqlite/sqlite_persistent_cookie_store.cc
• M net/extras/sqlite/sqlite_persistent_reporting_and_nel_store.cc
• M net/extras/sqlite/sqlite_persistent_shared_dictionary_store_unittest.cc
• M net/http/http_cache.cc
• M net/socket/ssl_client_socket_unittest.cc
• M net/socket/tcp_socket_posix.cc
• M net/spdy/fuzzing/hpack_example_generator.cc
• M net/test/quic_simple_test_server.cc
• M net/tools/dump_cache/dump_files.cc
• M net/tools/tld_cleanup/tld_cleanup.cc
• M net/tools/transport_security_state_generator/cert_util.cc
• M printing/backend/print_backend_cups_ipp.cc
• M remoting/base/crash/crashpad_linux.cc
• M remoting/base/crash/crashpad_win.cc
• M remoting/host/daemon_process.cc
• M remoting/host/linux/remoting_user_session.cc
• M remoting/host/setup/daemon_controller_delegate_mac.mm
• M sandbox/linux/services/scoped_process_unittest.cc
• M sandbox/linux/services/yama.cc
• M sandbox/linux/syscall_broker/broker_process.cc
• M sandbox/linux/tests/scoped_temporary_file.cc
• M sandbox/linux/tests/unit_tests.cc
• M sandbox/win/src/process_mitigations_unittest.cc
• M sandbox/win/src/win_utils_unittest.cc
• M services/audio/audio_sandbox_hook_linux.cc
• M services/cert_verifier/integration_tests/network_service_unittest.cc
• M services/data_decoder/xml_parser_unittest.cc
• M services/device/serial/serial_device_enumerator_mac.cc
• M services/network/http_cache_data_remover_unittest.cc
• M services/network/network_service.cc
• M services/network/public/cpp/cert_verifier/cert_verifier_mojom_traits_unittest.cc
• M services/network/session_cleanup_cookie_store.cc
• M services/network/session_cleanup_cookie_store_unittest.cc
• M services/network/ssl_config_service_mojo_unittest.cc
• M services/on_device_model/public/cpp/text_safety_assets.cc
• M services/screen_ai/sandbox/screen_ai_sandbox_hook_linux.cc
• M services/tracing/public/cpp/perfetto/java_heap_profiler/hprof_parser_android_unittest.cc
• M services/tracing/public/cpp/system_tracing_service.cc
• M skia/ext/recursive_gaussian_convolution_unittest.cc
• M storage/browser/blob/blob_flattener_unittest.cc
• M storage/browser/blob/blob_memory_controller_unittest.cc
• M storage/browser/blob/blob_storage_context_unittest.cc
• M storage/browser/file_system/file_system_usage_cache_unittest.cc
• M storage/browser/quota/quota_manager_unittest.cc
• M storage/browser/test/mock_quota_manager_unittest.cc
• M testing/android/native_test/native_test_launcher.cc
• M third_party/blink/renderer/controller/oom_intervention_impl_test.cc
• M third_party/blink/renderer/platform/testing/url_test_helpers.cc
• M tools/accessibility/inspect/ax_tree_server.cc
• M tools/accessibility/inspect/ax_utils.cc
• M tools/android/forwarder2/daemon.cc
• M tools/android/memdump/memdump.cc
• M ui/base/l10n/l10n_util.cc
• M ui/base/resource/resource_bundle_ios.mm
• M ui/base/resource/resource_bundle_mac.mm
• M ui/display/manager/touch_device_manager.cc
• M ui/events/ozone/evdev/gamepad_event_converter_evdev_unittest.cc
• M ui/events/ozone/evdev/libgestures_glue/gesture_feedback.cc
• M ui/events/ozone/evdev/libgestures_glue/gesture_feedback.h
• M ui/events/ozone/evdev/touch_evdev_debug_buffer.cc
• M ui/gfx/font_render_params_linux_unittest.cc
• M ui/ozone/platform/wayland/host/wayland_data_source.cc
• M ui/ozone/platform/wayland/host/wayland_syncobj_timeline_unittest.cc
• M ui/ozone/platform/wayland/host/zwp_text_input_v1.cc
• M ui/ozone/platform/wayland/host/zwp_text_input_v1_unittest.cc
• M ui/ozone/platform/wayland/test/test_wayland_server_thread.cc
• M ui/shell_dialogs/select_file_dialog_win.cc

Change size: M

Delta: 160 files changed, 25 insertions(+), 164 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I892d46ace056492fbf97d509be82a7d3cdb05b62

Gerrit-Change-Number: 7124288

Gerrit-PatchSet: 8