Jon Toohill (Gerrit)

unread,

Aug 22, 2025, 10:09:32 AMAug 22

to Andrew Williams, Chromium LUCI CQ, Dustin Mitchell, AyeAye, net-r...@chromium.org, ortuno...@chromium.org, spang...@chromium.org, rizvis...@google.com, tracing...@chromium.org, wfh+...@chromium.org, aakalla...@chromium.org

Attention needed from Andrew Williams

Jon Toohill voted

Auto-Submit	+1
Commit-Queue	+0

Open in Gerrit

Related details

Attention is currently required from:

Andrew Williams

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrew Williams (Gerrit)

unread,

Aug 22, 2025, 4:37:13 PMAug 22

to Jon Toohill, Chromium LUCI CQ, Dustin Mitchell, AyeAye, net-r...@chromium.org, ortuno...@chromium.org, spang...@chromium.org, rizvis...@google.com, tracing...@chromium.org, wfh+...@chromium.org, aakalla...@chromium.org

Attention needed from Jon Toohill

Andrew Williams voted and added 2 comments

Votes added by Andrew Williams

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Andrew Williams . resolved

LGTM with one question about the BUILD.gn dependencies. Thanks!

File components/ip_protection/common/BUILD.gn

Line 448, Patchset 7 (Latest): "//net/third_party/quiche:blind_sign_auth",

Andrew Williams . unresolved

does this need to be in public_deps or would deps suffice?

Open in Gerrit

Related details

Attention is currently required from:

Jon Toohill

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jon Toohill (Gerrit)

unread,

Aug 22, 2025, 5:23:44 PMAug 22

to Victor Vasiliev, Siddhartha S, Andrew Williams, Chromium LUCI CQ, Dustin Mitchell, AyeAye, net-r...@chromium.org, ortuno...@chromium.org, spang...@chromium.org, rizvis...@google.com, tracing...@chromium.org, wfh+...@chromium.org, aakalla...@chromium.org

Attention needed from Siddhartha S and Victor Vasiliev

Jon Toohill added 1 comment

File components/ip_protection/common/BUILD.gn

Line 448, Patchset 7 (Latest): "//net/third_party/quiche:blind_sign_auth",

Andrew Williams . resolved

does this need to be in public_deps or would deps suffice?

Jon Toohill

My reading of go/build-gn-best-practices: because this target only has `sources`, all of the sources are treated as being `public`. Therefore, because the header `#include`s something from BlindSignAuth, that dependency needs to be in `public_deps`.

But I'm also brand new to this, so I could have easily misinterpreted things.

Open in Gerrit

Related details

Attention is currently required from:

Siddhartha S
Victor Vasiliev

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Siddhartha S (Gerrit)

unread,

Aug 22, 2025, 5:29:43 PMAug 22

to Jon Toohill, Siddhartha S, Victor Vasiliev, Andrew Williams, Chromium LUCI CQ, Dustin Mitchell, AyeAye, net-r...@chromium.org, ortuno...@chromium.org, spang...@chromium.org, rizvis...@google.com, tracing...@chromium.org, wfh+...@chromium.org, aakalla...@chromium.org

Attention needed from Jon Toohill and Victor Vasiliev

Siddhartha S voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jon Toohill
Victor Vasiliev

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vasiliev (Gerrit)

unread,

Aug 22, 2025, 5:30:21 PMAug 22

to Jon Toohill, Siddhartha S, Andrew Williams, Chromium LUCI CQ, Dustin Mitchell, AyeAye, net-r...@chromium.org, ortuno...@chromium.org, spang...@chromium.org, rizvis...@google.com, tracing...@chromium.org, wfh+...@chromium.org, aakalla...@chromium.org

Attention needed from Jon Toohill

Victor Vasiliev voted and added 1 comment

Votes added by Victor Vasiliev

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Victor Vasiliev . resolved

+1 for //net/third_party/quiche

Open in Gerrit

Related details

Attention is currently required from:

Jon Toohill

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Jon Toohill (Gerrit)

unread,

Aug 22, 2025, 5:46:53 PMAug 22

to Victor Vasiliev, Siddhartha S, Andrew Williams, Chromium LUCI CQ, Dustin Mitchell, AyeAye, net-r...@chromium.org, ortuno...@chromium.org, spang...@chromium.org, rizvis...@google.com, tracing...@chromium.org, wfh+...@chromium.org, aakalla...@chromium.org

Jon Toohill voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Aug 22, 2025, 5:50:08 PMAug 22

to Jon Toohill, Victor Vasiliev, Siddhartha S, Andrew Williams, Dustin Mitchell, AyeAye, net-r...@chromium.org, ortuno...@chromium.org, spang...@chromium.org, rizvis...@google.com, tracing...@chromium.org, wfh+...@chromium.org, aakalla...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Implement quiche::BlindSignTracingHooks

The hooks cause trace events to be emitted to a specific
perfetto::Track so that they can be viewed as a sequence, regardless of
which thread they run on. (Currently all BlindSignAuth operations
happen in a single thread, but this may not be the case for long.)

Also adds a new `ip_protection` Perfetto category.

These hooks will be wired up in a subsequent CL.

Bug: b/438756313

Change-Id: I0525fa155e02b52c6f23c8c183629f376794b5cb

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6862041

Reviewed-by: Siddhartha S <ss...@chromium.org>

Reviewed-by: Victor Vasiliev <vas...@chromium.org>

Commit-Queue: Jon Toohill <jtoo...@google.com>

Reviewed-by: Andrew Williams <awi...@chromium.org>

Auto-Submit: Jon Toohill <jtoo...@google.com>

Cr-Commit-Position: refs/heads/main@{#1505351}

Files:

M base/trace_event/builtin_categories.h
M components/ip_protection/BUILD.gn
M components/ip_protection/common/BUILD.gn
A components/ip_protection/common/ip_protection_performance_hooks.cc
A components/ip_protection/common/ip_protection_performance_hooks.h
A components/ip_protection/common/ip_protection_performance_hooks_unittest.cc
M net/third_party/quiche/BUILD.gn

Change size: M

Delta: 7 files changed, 211 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Andrew Williams, +1 by Victor Vasiliev, +1 by Siddhartha S

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Implement quiche::BlindSignTracingHooks [chromium/src : main]

Jon Toohill (Gerrit)

Jon Toohill voted

Related details

Andrew Williams (Gerrit)

Andrew Williams voted and added 2 comments

Votes added by Andrew Williams

2 comments

Related details

Jon Toohill (Gerrit)

Jon Toohill added 1 comment

Related details

Siddhartha S (Gerrit)

Siddhartha S voted Code-Review+1

Related details

Victor Vasiliev (Gerrit)

Victor Vasiliev voted and added 1 comment

Votes added by Victor Vasiliev

1 comment

Related details

Jon Toohill (Gerrit)

Jon Toohill voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information