| Auto-Submit | +1 |
| Commit-Queue | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Just randomly looking around.
FWIW, if you want to split this CL and only do one include in 1 CL. e.g. All strcat.h, I can review some of these too.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Also, I see a red bot, but that may be due to one of my CLs that just got reverted.
I looked through but it looks like the build is broken as thestig@ noted.
| Auto-Submit | +1 |
I looked through but it looks like the build is broken as thestig@ noted.
Hm, I don't think my CL was the cause of that red bot because it only adds includes, it doesn't remove them. But the failure was due to an IWYU issue too, so I fixed it now and updated the CL description.
Victor ViannaExtra newline here?
Thanks, there were a couple of other instances too, fixed them now
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
#include "base/strings/strcat.h"Already on line 69.
#include "base/strings/strcat.h"Not needed. StrCat() only referenced in a comment.
#include "base/strings/strcat.h"Shouldn't include itself.
#include "base/strings/strcat.h"Ditto. Only referenced in a comment.
#include "base/strings/to_string.h"ToString() only mentioned in a comment.
#include "base/strings/strcat.h"Ditto.
#include "base/strings/strcat.h"base::StrCat() only mentioned in a comment.
| Auto-Submit | +1 |
Thanks!
Not needed. StrCat() only referenced in a comment.
Done
#include "base/strings/strcat.h"Victor ViannaShouldn't include itself.
Done and I checked the other headers
Ditto. Only referenced in a comment.
Done
ToString() only mentioned in a comment.
Done
This is the only file that has a deletion, because it makes the existing include cross-platform
https://source.chromium.org/chromium/chromium/src/+/main:chrome/updater/test/integration_tests.cc;l=2092;drc=a92f7aa487c74c8db5c1166d853439cff2ad9854
#include "base/strings/strcat.h"Victor ViannaAlready on line 69.
Wrote a script to catch duplicates
https://paste.googleplex.com/5843861027028992
Duplicate found: 'chrome/browser/enterprise/connectors/connectors_service_unittest.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_apitest.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/browser/feedback/show_feedback_page.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/browser/ui/test/test_browser_dialog.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/browser/ui/web_applications/web_app_browsertest.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/browser/ui/webui/settings/about_handler.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/browser/web_applications/test/os_integration_test_override_impl.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/enterprise_companion/enterprise_companion_status.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/updater/lock.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/updater/test/integration_tests.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chrome/updater/updater.cc' includes 'base/strings/to_string.h'
Duplicate found: 'chrome/updater/util/util.cc' includes 'base/strings/strcat.h'
Duplicate found: 'chromecast/cast_core/grpc/grpc_server_test.cc' includes 'base/strings/strcat.h'
Duplicate found: 'components/exo/wayland/wayland_protocol_logger.cc' includes 'base/strings/strcat.h'
Duplicate found: 'media/gpu/v4l2/v4l2_video_encode_accelerator.cc' includes 'base/strings/strcat.h'
Duplicate found: 'net/base/url_util.cc' includes 'base/strings/strcat.h'
Duplicate found: 'net/http/no_vary_search_cache_storage_file_operations.cc' includes 'base/strings/strcat.h'
Duplicate found: 'net/http/no_vary_search_cache_storage_file_operations_unittest.cc' includes 'base/strings/strcat.h'
Duplicate found: 'sql/database_unittest.cc' includes 'base/strings/strcat.h'
Duplicate found: 'ui/accessibility/ax_tree_unittest.cc' includes 'base/strings/to_string.h'
Duplicate found: 'ui/base/test/skia_gold_pixel_diff.cc' includes 'base/strings/strcat.h'
Done
base::StrCat() only mentioned in a comment.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fix more IWYU issues
These issues came up while trying to replace base/types/expected.h with
<expected>. We might not adopt std::expected<> in the end, but this
is still worth landing.
Headers added with `git grep` + `tools/add_header.py`
- base/strings/strcat.h
- base/strings/to_string.h
- base/strings/string_view_util.h
Headers added manually in a few instances.
- build/build_config.h
- base/check.h
- base/notreached.h
- base/time/time.h
- base/functional/callback_helpers.h
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |