Fix more IWYU issues [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Dec 5, 2025, 6:10:07 PMDec 5
to Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Victor Vianna voted and added 1 comment

Votes added by Victor Vianna

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 16 (Latest):
Victor Vianna . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
Gerrit-Change-Number: 7228863
Gerrit-PatchSet: 16
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Dec 2025 23:10:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Dec 5, 2025, 8:48:53 PMDec 5
to Victor Vianna, Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng and Victor Vianna

Lei Zhang added 2 comments

Patchset-level comments
File-level comment, Patchset 17 (Latest):
Lei Zhang . resolved

Just randomly looking around.

FWIW, if you want to split this CL and only do one include in 1 CL. e.g. All strcat.h, I can review some of these too.

File chrome/browser/glic/fre/glic_fre_controller_interactive_uitest.cc
Line 5, Patchset 17 (Latest):
Lei Zhang . unresolved

Extra newline here?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Victor Vianna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
    Gerrit-Change-Number: 7228863
    Gerrit-PatchSet: 17
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Lei Zhang <the...@chromium.org>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Peter Williamson <pet...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 01:48:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Dec 5, 2025, 8:50:02 PMDec 5
    to Victor Vianna, Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Daniel Cheng and Victor Vianna

    Lei Zhang added 1 comment

    Patchset-level comments
    Lei Zhang . resolved

    Also, I see a red bot, but that may be due to one of my CLs that just got reverted.

    Gerrit-Comment-Date: Sat, 06 Dec 2025 01:49:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Dec 8, 2025, 12:02:39 PM (12 days ago) Dec 8
    to Victor Vianna, Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Victor Vianna

    Daniel Cheng added 1 comment

    Patchset-level comments
    Daniel Cheng . resolved

    I looked through but it looks like the build is broken as thestig@ noted.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Victor Vianna
    Gerrit-Comment-Date: Mon, 08 Dec 2025 17:02:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Dec 8, 2025, 6:44:39 PM (12 days ago) Dec 8
    to Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Daniel Cheng

    Victor Vianna voted and added 3 comments

    Votes added by Victor Vianna

    Auto-Submit+1

    3 comments

    Patchset-level comments
    Daniel Cheng . resolved

    I looked through but it looks like the build is broken as thestig@ noted.

    Victor Vianna

    Hm, I don't think my CL was the cause of that red bot because it only adds includes, it doesn't remove them. But the failure was due to an IWYU issue too, so I fixed it now and updated the CL description.

    File-level comment, Patchset 20 (Latest):
    Victor Vianna . resolved

    Thanks!

    File chrome/browser/glic/fre/glic_fre_controller_interactive_uitest.cc
    Line 5, Patchset 17:
    Lei Zhang . resolved

    Extra newline here?

    Victor Vianna

    Thanks, there were a couple of other instances too, fixed them now

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
      Gerrit-Change-Number: 7228863
      Gerrit-PatchSet: 20
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Mon, 08 Dec 2025 23:44:27 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
      Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Lei Zhang (Gerrit)

      unread,
      Dec 8, 2025, 6:54:40 PM (12 days ago) Dec 8
      to Victor Vianna, Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Daniel Cheng and Victor Vianna

      Lei Zhang added 1 comment

      File sql/database_unittest.cc
      Line 40, Patchset 20 (Latest):#include "base/strings/strcat.h"
      Lei Zhang . unresolved

      Already on line 69.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      • Victor Vianna
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        Gerrit-Attention: Victor Vianna <victor...@google.com>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Comment-Date: Mon, 08 Dec 2025 23:54:29 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Lei Zhang (Gerrit)

        unread,
        Dec 8, 2025, 7:06:55 PM (12 days ago) Dec 8
        to Victor Vianna, Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
        Attention needed from Daniel Cheng and Victor Vianna

        Lei Zhang added 3 comments

        File base/strings/lazy_string_builder.h
        Line 19, Patchset 20 (Latest):#include "base/strings/strcat.h"
        Lei Zhang . unresolved

        Not needed. StrCat() only referenced in a comment.

        File base/strings/strcat.h
        Line 13, Patchset 20 (Latest):#include "base/strings/strcat.h"
        Lei Zhang . unresolved

        Shouldn't include itself.

        File base/types/expected_macros.h
        Line 22, Patchset 20 (Latest):#include "base/strings/strcat.h"
        Lei Zhang . unresolved

        Ditto. Only referenced in a comment.

        Gerrit-Comment-Date: Tue, 09 Dec 2025 00:06:43 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Lei Zhang (Gerrit)

        unread,
        Dec 8, 2025, 7:08:52 PM (12 days ago) Dec 8
        to Victor Vianna, Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
        Attention needed from Daniel Cheng and Victor Vianna

        Lei Zhang added 3 comments

        File chrome/browser/actor/tools/attempt_form_filling_tool_request.h
        Line 13, Patchset 20 (Latest):#include "base/strings/to_string.h"
        Lei Zhang . unresolved

        ToString() only mentioned in a comment.

        File net/base/ip_address.h
        Line 21, Patchset 20 (Latest):#include "base/strings/strcat.h"
        Lei Zhang . unresolved

        Ditto.

        File third_party/blink/renderer/platform/wtf/text/strcat.h
        Line 11, Patchset 20 (Latest):#include "base/strings/strcat.h"
        Lei Zhang . unresolved

        base::StrCat() only mentioned in a comment.

        Gerrit-Comment-Date: Tue, 09 Dec 2025 00:08:41 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Victor Vianna (Gerrit)

        unread,
        Dec 8, 2025, 7:32:43 PM (12 days ago) Dec 8
        to Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
        Attention needed from Daniel Cheng and Lei Zhang

        Victor Vianna voted and added 9 comments

        Votes added by Victor Vianna

        Auto-Submit+1

        9 comments

        Patchset-level comments
        Victor Vianna . resolved

        Thanks!

        File base/strings/lazy_string_builder.h
        Line 19, Patchset 20:#include "base/strings/strcat.h"
        Lei Zhang . resolved

        Not needed. StrCat() only referenced in a comment.

        Victor Vianna

        Done

        File base/strings/strcat.h
        Line 13, Patchset 20:#include "base/strings/strcat.h"
        Lei Zhang . resolved

        Shouldn't include itself.

        Victor Vianna

        Done and I checked the other headers

        File base/types/expected_macros.h
        Line 22, Patchset 20:#include "base/strings/strcat.h"
        Lei Zhang . resolved

        Ditto. Only referenced in a comment.

        Victor Vianna

        Done

        File chrome/browser/actor/tools/attempt_form_filling_tool_request.h
        Line 13, Patchset 20:#include "base/strings/to_string.h"
        Lei Zhang . resolved

        ToString() only mentioned in a comment.

        Victor Vianna

        Done

        File chrome/updater/test/integration_tests.cc
        File net/base/ip_address.h
        Line 21, Patchset 20:#include "base/strings/strcat.h"
        Lei Zhang . resolved

        Ditto.

        Victor Vianna

        Done

        File sql/database_unittest.cc
        Line 40, Patchset 20:#include "base/strings/strcat.h"
        Lei Zhang . resolved

        Already on line 69.

        Victor Vianna

        Wrote a script to catch duplicates
        https://paste.googleplex.com/5843861027028992

        Duplicate found: 'chrome/browser/enterprise/connectors/connectors_service_unittest.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_apitest.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/browser/feedback/show_feedback_page.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/browser/ui/test/test_browser_dialog.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/browser/ui/web_applications/web_app_browsertest.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/browser/ui/webui/settings/about_handler.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/browser/web_applications/test/os_integration_test_override_impl.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/enterprise_companion/enterprise_companion_status.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/updater/lock.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/updater/test/integration_tests.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chrome/updater/updater.cc' includes 'base/strings/to_string.h'
        Duplicate found: 'chrome/updater/util/util.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'chromecast/cast_core/grpc/grpc_server_test.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'components/exo/wayland/wayland_protocol_logger.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'media/gpu/v4l2/v4l2_video_encode_accelerator.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'net/base/url_util.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'net/http/no_vary_search_cache_storage_file_operations.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'net/http/no_vary_search_cache_storage_file_operations_unittest.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'sql/database_unittest.cc' includes 'base/strings/strcat.h'
        Duplicate found: 'ui/accessibility/ax_tree_unittest.cc' includes 'base/strings/to_string.h'
        Duplicate found: 'ui/base/test/skia_gold_pixel_diff.cc' includes 'base/strings/strcat.h'

        Done

        File third_party/blink/renderer/platform/wtf/text/strcat.h
        Line 11, Patchset 20:#include "base/strings/strcat.h"
        Lei Zhang . resolved

        base::StrCat() only mentioned in a comment.

        Victor Vianna

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Daniel Cheng
        • Lei Zhang
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
          Gerrit-Change-Number: 7228863
          Gerrit-PatchSet: 21
          Gerrit-Attention: Lei Zhang <the...@chromium.org>
          Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
          Gerrit-Comment-Date: Tue, 09 Dec 2025 00:32:36 +0000
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Lei Zhang (Gerrit)

          unread,
          Dec 8, 2025, 7:39:29 PM (12 days ago) Dec 8
          to Victor Vianna, Lei Zhang, Daniel Cheng, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
          Attention needed from Daniel Cheng and Victor Vianna

          Lei Zhang voted

          Code-Review+1
          Owners-Override+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Daniel Cheng
          • Victor Vianna
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
          Gerrit-Change-Number: 7228863
          Gerrit-PatchSet: 21
          Gerrit-Owner: Victor Vianna <victor...@google.com>
          Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
          Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
          Gerrit-Reviewer: Victor Vianna <victor...@google.com>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Andrew Rayskiy <green...@google.com>
          Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
          Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
          Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-CC: Hongchan Choi <hong...@chromium.org>
          Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
          Gerrit-CC: James Maclean <wjma...@chromium.org>
          Gerrit-CC: Jiewei Qian <q...@chromium.org>
          Gerrit-CC: Kaan Icer <ic...@chromium.org>
          Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
          Gerrit-CC: Peter Beverloo <pe...@chromium.org>
          Gerrit-CC: Peter Williamson <pet...@chromium.org>
          Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
          Gerrit-CC: Simon Hangl <sim...@google.com>
          Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
          Gerrit-Attention: Victor Vianna <victor...@google.com>
          Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
          Gerrit-Comment-Date: Tue, 09 Dec 2025 00:39:15 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Victor Vianna (Gerrit)

          unread,
          Dec 8, 2025, 7:40:00 PM (12 days ago) Dec 8
          to Daniel Cheng, Lei Zhang, AyeAye, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
          Attention needed from Daniel Cheng

          Victor Vianna voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Daniel Cheng
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
          Gerrit-Change-Number: 7228863
          Gerrit-PatchSet: 21
          Gerrit-Owner: Victor Vianna <victor...@google.com>
          Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
          Gerrit-Reviewer: Victor Vianna <victor...@google.com>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Andrew Rayskiy <green...@google.com>
          Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
          Gerrit-CC: Daniel Cheng <dch...@chromium.org>
          Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
          Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-CC: Hongchan Choi <hong...@chromium.org>
          Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
          Gerrit-CC: James Maclean <wjma...@chromium.org>
          Gerrit-CC: Jiewei Qian <q...@chromium.org>
          Gerrit-CC: Kaan Icer <ic...@chromium.org>
          Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
          Gerrit-CC: Peter Beverloo <pe...@chromium.org>
          Gerrit-CC: Peter Williamson <pet...@chromium.org>
          Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
          Gerrit-CC: Simon Hangl <sim...@google.com>
          Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
          Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
          Gerrit-Comment-Date: Tue, 09 Dec 2025 00:39:50 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Victor Vianna (Gerrit)

          unread,
          Dec 8, 2025, 9:29:10 PM (12 days ago) Dec 8
          to Daniel Cheng, Lei Zhang, AyeAye, Akihiro Ota, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Hongchan Choi, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Hiroki Nakagawa, Hu, Ningxin, Permissions Reviews, Peter Beverloo, Peter Williamson, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Maclean, Chromium LUCI CQ, agriev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, torne...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, antoniosarto...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, arthursonzog...@chromium.org, asumane...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eic+...@google.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, jimmyxgong+f...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, lingqi...@chromium.org, liu+wa...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marinacio...@chromium.org, marq+...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+...@google.com, minap+watch-p...@google.com, mkwst+w...@chromium.org, mreichhoff+watc...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, njeunje+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, pmonett...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, storage...@chromium.org, suzukike...@chromium.org, svend+w...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tote-eng...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiaohui...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

          Victor Vianna submitted the change

          Change information

          Commit message:
          Fix more IWYU issues

          These issues came up while trying to replace base/types/expected.h with
          <expected>. We might not adopt std::expected<> in the end, but this
          is still worth landing.

          Headers added with `git grep` + `tools/add_header.py`
          - base/strings/strcat.h
          - base/strings/to_string.h
          - base/strings/string_view_util.h

          Headers added manually in a few instances.
          - build/build_config.h
          - base/check.h
          - base/notreached.h
          - base/time/time.h
          - base/functional/callback_helpers.h
          Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
          Reviewed-by: Lei Zhang <the...@chromium.org>
          Commit-Queue: Victor Vianna <victor...@google.com>
          Auto-Submit: Victor Vianna <victor...@google.com>
          Owners-Override: Lei Zhang <the...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1555861}
          Files:
          • M android_webview/browser/aw_browser_context_store.cc
          • M ash/glanceables/glanceables_unittest.cc
          • M ash/login/ui/lock_contents_view.cc
          • M ash/metrics/demo_session_metrics_recorder.cc
          • M ash/system/focus_mode/focus_mode_detailed_view_unittest.cc
          • M ash/system/keyboard_brightness/keyboard_brightness_controller.cc
          • M ash/wm/coral/coral_controller.cc
          • M base/android/pre_freeze_background_memory_trimmer_unittest.cc
          • M base/check_unittest.cc
          • M base/process/process_metrics_win.cc
          • M base/test/values_test_util.cc
          • M cc/metrics/ukm_manager_unittest.cc
          • M chrome/browser/actor/actor_functional_browsertest.cc
          • M chrome/browser/actor/actor_policy_checker.cc
          • M chrome/browser/actor/actor_policy_checker_browsertest.cc
          • M chrome/browser/actor/actor_task.cc
          • M chrome/browser/actor/browser_action_util.cc
          • M chrome/browser/actor/execution_engine_origin_gating_browsertest.cc
          • M chrome/browser/actor/execution_engine_unittest.cc
          • M chrome/browser/actor/tools/attempt_form_filling_tool_request.cc
          • M chrome/browser/actor/tools/attempt_login_tool_interactive_ui_test.cc
          • M chrome/browser/apps/app_service/app_install/app_install_service_ash.cc
          • M chrome/browser/apps/app_service/app_install/arc_app_installer.cc
          • M chrome/browser/apps/app_service/app_install/web_app_installer.cc
          • M chrome/browser/apps/app_service/metrics/app_discovery_metrics.cc
          • M chrome/browser/ash/app_list/search/local_image_search/image_annotation_worker_unittest.cc
          • M chrome/browser/ash/arc/extensions/fake_arc_support.cc
          • M chrome/browser/ash/arc/tracing/overview_tracing_handler_unittest.cc
          • M chrome/browser/ash/child_accounts/on_device_controls/blocked_app_registry_unittest.cc
          • M chrome/browser/ash/dbus/arc_tracing_service_provider.cc
          • M chrome/browser/ash/dbus/arc_tracing_service_provider_unittest.cc
          • M chrome/browser/ash/dbus/chrome_features_service_provider.cc
          • M chrome/browser/ash/exo/chrome_security_delegate.cc
          • M chrome/browser/ash/extensions/file_manager/private_api_util.cc
          • M chrome/browser/ash/file_manager/file_manager_jstest_base.cc
          • M chrome/browser/ash/file_manager/file_tasks_unittest.cc
          • M chrome/browser/ash/file_manager/path_util_unittest.cc
          • M chrome/browser/ash/file_manager/trash_auto_cleanup_unittest.cc
          • M chrome/browser/ash/file_system_provider/content_cache/local_fd_unittest.cc
          • M chrome/browser/ash/growth/campaigns_manager_interactive_uitest.cc
          • M chrome/browser/ash/login/enrollment/enrollment_screen_unittest.cc
          • M chrome/browser/ash/login/saml/fake_saml_idp_mixin.cc
          • M chrome/browser/ash/login/webview_login_browsertest.cc
          • M chrome/browser/ash/login/wizard_controller_unittest.cc
          • M chrome/browser/ash/policy/reporting/metrics_reporting/fatal_crash/fatal_crash_events_observer_unittest.cc
          • M chrome/browser/ash/policy/reporting/user_session_activity/user_session_activity_reporter_unittest.cc
          • M chrome/browser/ash/policy/skyvault/odfs_skyvault_uploader_browsertest.cc
          • M chrome/browser/ash/policy/skyvault/signin_notification_helper.cc
          • M chrome/browser/ash/policy/skyvault/signin_notification_helper_unittest.cc
          • M chrome/browser/ash/shimless_rma/chrome_shimless_rma_delegate_unittest.cc
          • M chrome/browser/ash/system_web_apps/apps/demo_mode_app_integration_browsertest.cc
          • M chrome/browser/ash/wallpaper_handlers/wallpaper_handlers.cc
          • M chrome/browser/autofill/glic/actor_form_filling_service_impl.cc
          • M chrome/browser/banners/app_banner_manager_browsertest.cc
          • M chrome/browser/chrome_web_platform_security_metrics_browsertest.cc
          • M chrome/browser/chromeos/cros_apps/api/cros_apps_api_access_control_browsertest.cc
          • M chrome/browser/chromeos/extensions/login_screen/login/shared_session_handler.cc
          • M chrome/browser/chromeos/gemini_app/gemini_app_tab_helper_unittest.cc
          • M chrome/browser/compose/chrome_compose_client_unittest.cc
          • M chrome/browser/contextual_cueing/zero_state_suggestions_browsertest.cc
          • M chrome/browser/enterprise/connectors/common_unittest.cc
          • M chrome/browser/enterprise/connectors/interstitials/enterprise_page_unittest.cc
          • M chrome/browser/enterprise/connectors/test/active_user_test_mixin.cc
          • M chrome/browser/enterprise/data_protection/data_protection_navigation_observer_unittest.cc
          • M chrome/browser/enterprise/profile_management/oidc_auth_response_capture_navigation_throttle_browsertest.cc
          • M chrome/browser/enterprise/signin/oidc_authentication_signin_interceptor_unittest.cc
          • M chrome/browser/extensions/api/autofill_private/autofill_private_api_unittest.cc
          • M chrome/browser/extensions/api/developer_private/developer_private_apitest.cc
          • M chrome/browser/extensions/api/developer_private/developer_private_functions_shared.cc
          • M chrome/browser/extensions/api/management/management_api_browsertest.cc
          • M chrome/browser/extensions/api/messaging/externally_connectable_messaging_apitest.cc
          • M chrome/browser/extensions/api/side_panel/side_panel_service.cc
          • M chrome/browser/extensions/extension_browser_test_util.cc
          • M chrome/browser/extensions/initial_external_extension_loader_browsertest.cc
          • M chrome/browser/extensions/process_map_browsertest.cc
          • M chrome/browser/glic/actor/glic_actor_task_manager.cc
          • M chrome/browser/glic/browser_ui/tab_underline_view_interactive_uitest.cc
          • M chrome/browser/glic/fre/glic_fre_controller_interactive_uitest.cc
          • M chrome/browser/glic/glic_metrics.cc
          • M chrome/browser/glic/glic_user_status_browsertest.cc
          • M chrome/browser/glic/glic_user_status_request.cc
          • M chrome/browser/glic/host/glic_actor_toctou_interactive_uitest.cc
          • M chrome/browser/glic/host/glic_annotation_manager_interactive_uitest.cc
          • M chrome/browser/glic/host/glic_ui.cc
          • M chrome/browser/glic/test_support/glic_api_test.h
          • M chrome/browser/glic/test_support/glic_test_util.cc
          • M chrome/browser/glic/widget/glic_inactive_side_panel_ui.cc
          • M chrome/browser/glic/widget/glic_side_panel_ui.cc
          • M chrome/browser/loader/from_gws_navigation_and_keep_alive_request_observer_unittest.cc
          • M chrome/browser/loader/from_gws_navigation_and_keep_alive_request_tracker_unittest.cc
          • M chrome/browser/media/router/providers/dial/dial_internal_message_util.cc
          • M chrome/browser/media/webrtc/webrtc_logging_controller.cc
          • M chrome/browser/navigation_predictor/preloading_model_keyed_service_browsertest.cc
          • M chrome/browser/net/chrome_shared_dictionary_browsertest.cc
          • M chrome/browser/net/qwac_web_contents_observer_browsertest.cc
          • M chrome/browser/new_tab_page/modules/file_suggestion/drive_service.cc
          • M chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc
          • M chrome/browser/notifications/win/notification_template_builder_unittest.cc
          • M chrome/browser/optimization_guide/chrome_model_quality_logs_uploader_service.cc
          • M chrome/browser/optimization_guide/optimization_guide_keyed_service.cc
          • M chrome/browser/page_content_annotations/multi_source_page_context_fetcher_browsertest.cc
          • M chrome/browser/page_load_metrics/observers/from_gws_abandoned_page_load_metrics_observer_browsertest.cc
          • M chrome/browser/page_load_metrics/observers/lcp_critical_path_predictor_page_load_metrics_observer.cc
          • M chrome/browser/page_load_metrics/observers/third_party_cookie_deprecation_metrics_observer_browsertest.cc
          • M chrome/browser/page_load_metrics/observers/webui_page_load_metrics_observer.cc
          • M chrome/browser/password_manager/android/password_manager_error_message_delegate_unittest.cc
          • M chrome/browser/password_manager/password_change/form_filling_helper.cc
          • M chrome/browser/pdf/pdf_extension_js_test.cc
          • M chrome/browser/pdf/pdf_viewer_stream_manager.cc
          • M chrome/browser/performance_manager/metrics/metrics_provider_desktop.cc
          • M chrome/browser/permissions/prediction_service/prediction_service_browsertest.cc
          • M chrome/browser/picture_in_picture/document_picture_in_picture_pixel_browsertest.cc
          • M chrome/browser/policy/test/autofill_ai_policy_browsertest.cc
          • M chrome/browser/preloading/prefetch/search_prefetch/streaming_search_prefetch_url_loader.cc
          • M chrome/browser/preloading/search_preload/search_preload_browsertest.cc
          • M chrome/browser/privacy_sandbox/privacy_sandbox_service_impl.cc
          • M chrome/browser/privacy_sandbox/privacy_sandbox_service_impl_unittest.cc
          • M chrome/browser/privacy_sandbox/profile_bucket_metrics_unittest.cc
          • M chrome/browser/profiles/profile_manager.cc
          • M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
          • M chrome/browser/safe_browsing/cloud_content_scanning/cloud_binary_upload_service.cc
          • M chrome/browser/safe_browsing/download_protection/deep_scanning_request.cc
          • M chrome/browser/save_to_drive/multipart_drive_uploader.cc
          • M chrome/browser/save_to_drive/multipart_drive_uploader_unittest.cc
          • M chrome/browser/save_to_drive/pdf_content_reader_browsertest.cc
          • M chrome/browser/save_to_drive/resumable_drive_uploader.cc
          • M chrome/browser/save_to_drive/resumable_drive_uploader_unittest.cc
          • M chrome/browser/search_engine_choice/search_engine_choice_dialog_browsertest.cc
          • M chrome/browser/shell_integration_win.cc
          • M chrome/browser/shortcuts/icon_badging_unittest.cc
          • M chrome/browser/signin/bound_session_credentials/bound_session_oauth_multilogin_delegate_impl_unittest.cc
          • M chrome/browser/signin/dice_browsertest.cc
          • M chrome/browser/signin/signin_manager_unittest.cc
          • M chrome/browser/tpcd/metadata/manager_browsertest.cc
          • M chrome/browser/ui/android/autofill/autofill_save_card_bottom_sheet_bridge_unittest.cc
          • M chrome/browser/ui/ash/holding_space/holding_space_keyed_service_browsertest.cc
          • M chrome/browser/ui/ash/holding_space/holding_space_keyed_service_unittest.cc
          • M chrome/browser/ui/ash/main_extra_parts/chrome_browser_main_extra_parts_ash.cc
          • M chrome/browser/ui/ash/read_write_cards/read_write_cards_manager_impl_unittest.cc
          • M chrome/browser/ui/ash/user_education/welcome_tour/welcome_tour_interactive_uitest.cc
          • M chrome/browser/ui/autofill/autofill_message_controller_impl_unittest.cc
          • M chrome/browser/ui/autofill/payments/mandatory_reauth_bubble_controller_impl_unittest.cc
          • M chrome/browser/ui/browser_focus_interactive_uitest.cc
          • M chrome/browser/ui/browser_live_tab_context.cc
          • M chrome/browser/ui/lens/lens_overlay_controller.cc
          • M chrome/browser/ui/lens/lens_overlay_controller_browsertest.cc
          • M chrome/browser/ui/omnibox/omnibox_search_aggregator_browsertest.cc
          • M chrome/browser/ui/plus_addresses/views/plus_address_creation_dialog_interactive_uitest.cc
          • M chrome/browser/ui/signin/promos/bubble_signin_promo_view.cc
          • M chrome/browser/ui/tabs/saved_tab_groups/collaboration_messaging_observer_browsertest.cc
          • M chrome/browser/ui/tabs/tab_strip_model_selection_adapter_unittest.cc
          • M chrome/browser/ui/tabs/vertical_tab_strip_state_controller.cc
          • M chrome/browser/ui/url_identity_unittest.cc
          • M chrome/browser/ui/views/autofill/payments/autofill_progress_dialog_views_browsertest.cc
          • M chrome/browser/ui/views/autofill/payments/card_unmask_otp_input_dialog_browsertest.cc
          • M chrome/browser/ui/views/autofill/payments/iban_bubble_view_interactive_uitest.cc
          • M chrome/browser/ui/views/autofill/payments/offer_notification_bubble_views_interactive_uitest.cc
          • M chrome/browser/ui/views/autofill/payments/save_card_bubble_views_browsertest.cc
          • M chrome/browser/ui/views/autofill/payments/save_payment_method_and_virtual_card_enroll_confirmation_bubble_views_interactive_uitest.cc
          • M chrome/browser/ui/views/autofill/payments/virtual_card_enroll_bubble_views_interactive_uitest.cc
          • M chrome/browser/ui/views/bookmarks/bookmark_account_storage_move_dialog.cc
          • M chrome/browser/ui/views/bookmarks/saved_tab_groups/shared_tab_group_interactive_uitest.cc
          • M chrome/browser/ui/views/commerce/discounts_interactive_uitest.cc
          • M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
          • M chrome/browser/ui/views/download/bubble/download_bubble_interactive_uitest.cc
          • M chrome/browser/ui/views/hats/hats_browsertest.cc
          • M chrome/browser/ui/views/page_action/collaboration_messaging_page_action_icon_view_interactive_uitest.cc
          • M chrome/browser/ui/views/page_action/page_action_controller_unittest.cc
          • M chrome/browser/ui/views/page_action/page_action_metrics_recorder_unittest.cc
          • M chrome/browser/ui/views/passwords/password_change/password_change_toast_browsertest.cc
          • M chrome/browser/ui/views/performance_controls/memory_saver_interactive_ui_test.cc
          • M chrome/browser/ui/views/permissions/embedded_permission_prompt_interactive_uitest.cc
          • M chrome/browser/ui/views/profiles/batch_upload_dialog_view_pixel_browsertest.cc
          • M chrome/browser/ui/views/profiles/first_run_interactive_uitest.cc
          • M chrome/browser/ui/views/profiles/profile_picker_post_sign_in_adapter.cc
          • M chrome/browser/ui/views/profiles/profile_picker_sign_in_provider.cc
          • M chrome/browser/ui/views/profiles/profile_picker_view_browsertest.cc
          • M chrome/browser/ui/views/save_to_drive/account_chooser_radio_group_view.cc
          • M chrome/browser/ui/views/save_to_drive/account_chooser_view.cc
          • M chrome/browser/ui/views/toolbar/pinned_action_toolbar_button_menu_model.cc
          • M chrome/browser/ui/views/toolbar/toolbar_controller_unittest.cc
          • M chrome/browser/ui/views/web_apps/isolated_web_apps/isolated_web_app_installer_view_browsertest.cc
          • M chrome/browser/ui/views/web_apps/isolated_web_apps/isolated_web_app_installer_view_controller_unittest.cc
          • M chrome/browser/ui/web_applications/app_browser_document_picture_in_picture_browsertest.cc
          • M chrome/browser/ui/web_applications/navigation_capturing_process.cc
          • M chrome/browser/ui/web_applications/sub_apps_admin_policy_browsertest.cc
          • M chrome/browser/ui/web_applications/test/web_app_browsertest_util.cc
          • M chrome/browser/ui/webui/ash/lobster/lobster_page_handler_unittest.cc
          • M chrome/browser/ui/webui/autofill_and_password_manager_internals/internals_ui_handler.cc
          • M chrome/browser/ui/webui/downloads/downloads_page_interactive_uitest.cc
          • M chrome/browser/ui/webui/new_tab_page/action_chips/remote_suggestions_service_simple.cc
          • M chrome/browser/ui/webui/new_tab_page/action_chips/remote_suggestions_service_simple_unittest.cc
          • M chrome/browser/ui/webui/on_device_internals/on_device_internals_page_handler.cc
          • M chrome/browser/ui/webui/search_engine_choice/search_engine_choice_ui.cc
          • M chrome/browser/ui/webui/settings/performance_settings_interactive_uitest.cc
          • M chrome/browser/ui/webui/settings/settings_ui.cc
          • M chrome/browser/ui/webui/side_panel/customize_chrome/wallpaper_search/wallpaper_search_handler.cc
          • M chrome/browser/ui/webui/side_panel/customize_chrome/wallpaper_search/wallpaper_search_handler_unittest.cc
          • M chrome/browser/ui/webui/signin/history_sync_optin_helper.cc
          • M chrome/browser/ui/webui/test_support/webui_interactive_test_mixin.h
          • M chrome/browser/ui/webui/web_app_internals/iwa_internals_handler.cc
          • M chrome/browser/web_applications/app_service/web_app_publisher_helper.cc
          • M chrome/browser/web_applications/app_service/web_apps_chromeos_browsertest.cc
          • M chrome/browser/web_applications/ash/migrations/adobe_express_oem_to_default_migration_browsertest.cc
          • M chrome/browser/web_applications/commands/apply_pending_manifest_update_command.cc
          • M chrome/browser/web_applications/commands/fetch_manifest_and_install_command_unittest.cc
          • M chrome/browser/web_applications/commands/fetch_manifest_and_update_command.cc
          • M chrome/browser/web_applications/commands/generated_icon_fix_command.cc
          • M chrome/browser/web_applications/commands/set_user_display_mode_command.cc
          • M chrome/browser/web_applications/commands/uninstall_all_user_installed_web_apps_command.cc
          • M chrome/browser/web_applications/external_install_options.cc
          • M chrome/browser/web_applications/isolated_web_apps/commands/install_isolated_web_app_command.cc
          • M chrome/browser/web_applications/isolated_web_apps/commands/isolated_web_app_apply_update_command.cc
          • M chrome/browser/web_applications/isolated_web_apps/commands/isolated_web_app_install_command_helper_unittest.cc
          • M chrome/browser/web_applications/isolated_web_apps/install/isolated_web_app_installation_manager.cc
          • M chrome/browser/web_applications/isolated_web_apps/jobs/get_isolated_web_app_size_job.cc
          • M chrome/browser/web_applications/isolated_web_apps/policy/isolated_web_app_installer.cc
          • M chrome/browser/web_applications/isolated_web_apps/signed_web_bundle_metadata_unittest.cc
          • M chrome/browser/web_applications/isolated_web_apps/update_manifest/update_manifest.cc
          • M chrome/browser/web_applications/jobs/get_progressive_web_app_size_job.cc
          • M chrome/browser/web_applications/jobs/install_from_info_job.cc
          • M chrome/browser/web_applications/jobs/install_placeholder_job.cc
          • M chrome/browser/web_applications/os_integration/mac/app_shim_registry_unittest.cc
          • M chrome/browser/web_applications/os_integration/web_app_shortcut_linux.cc
          • M chrome/browser/web_applications/preinstalled_web_app_manager_unittest.cc
          • M chrome/browser/web_applications/test/debug_info_printer.cc
          • M chrome/browser/web_applications/test/web_app_test_observers.cc
          • M chrome/browser/web_applications/visited_manifest_manager_unittest.cc
          • M chrome/browser/web_applications/web_app_database_unittest.cc
          • M chrome/browser/web_applications/web_app_link_capturing_parameterized_browsertest.cc
          • M chrome/browser/web_applications/web_app_run_on_os_login_manager_browsertest.cc
          • M chrome/browser/web_applications/web_app_sync_bridge_unittest.cc
          • M chrome/browser/web_applications/web_app_unittest.cc
          • M chrome/browser/webauthn/enclave_manager_unittest.cc
          • M chrome/browser/win/conflicts/enumerate_shell_extensions.cc
          • M chrome/browser/win/conflicts/enumerate_shell_extensions_unittest.cc
          • M chrome/browser/win/conflicts/module_info_util.cc
          • M chrome/browser/win/parental_controls.cc
          • M chrome/credential_provider/gaiacp/device_policies_manager_unittest.cc
          • M chrome/credential_provider/gaiacp/gcp_utils.cc
          • M chrome/credential_provider/gaiacp/gcp_utils_unittest.cc
          • M chrome/credential_provider/gaiacp/os_process_manager.cc
          • M chrome/credential_provider/gaiacp/reg_utils.cc
          • M chrome/credential_provider/gaiacp/scoped_user_profile.cc
          • M chrome/credential_provider/gaiacp/win_http_url_fetcher.cc
          • M chrome/credential_provider/test/gcp_setup_unittest.cc
          • M chrome/enterprise_companion/event_logger.cc
          • M chrome/enterprise_companion/event_logger_unittest.cc
          • M chrome/install_static/product_install_details_unittest.cc
          • M chrome/installer/setup/google_chrome_behaviors.cc
          • M chrome/installer/setup/install.cc
          • M chrome/installer/setup/install_unittest.cc
          • M chrome/installer/setup/install_worker_unittest.cc
          • M chrome/installer/util/app_commands.cc
          • M chrome/installer/util/create_reg_key_work_item.cc
          • M chrome/installer/util/install_service_work_item_unittest.cc
          • M chrome/installer/util/installation_state.cc
          • M chrome/installer/util/l10n_string_util.cc
          • M chrome/installer/util/unbuffered_file_writer.cc
          • M chrome/renderer/actor/select_tool.cc
          • M chrome/renderer/supervised_user/supervised_user_error_page_controller.cc
          • M chrome/test/base/chromeos/crosier/chromeos_integration_login_mixin.cc
          • M chrome/test/data/webui/chromeos/settings/os_settings_focus_test.cc
          • M chrome/test/interaction/interactive_browser_window_test.h
          • M chrome/test/supervised_user/family_live_test.cc
          • M chrome/updater/event_logger_unittest.cc
          • M chrome/updater/test/dm_policy_builder.cc
          • M chrome/updater/test/integration_tests.cc
          • M chrome/updater/update_service_impl_impl.cc
          • M chrome/updater/win/setup/uninstall.cc
          • M chromecast/base/metrics/grouped_histogram.cc
          • M chromeos/ash/components/boca/babelorca/babel_orca_caption_translator.cc
          • M chromeos/ash/components/dbus/featured/featured_client_unittest.cc
          • M chromeos/ash/components/dbus/fwupd/fake_fwupd_client.cc
          • M chromeos/ash/components/fwupd/firmware_update_manager.cc
          • M chromeos/ash/components/geolocation/cached_location_provider_unittest.cc
          • M components/autofill/content/browser/content_autofill_driver_unittest.cc
          • M components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_encoding.cc
          • M components/autofill/core/browser/crowdsourcing/determine_possible_field_types_unittest.cc
          • M components/autofill/core/browser/filling/autofill_ai/field_filling_entity_util_unittest.cc
          • M components/autofill/core/browser/geo/alternative_state_name_map_updater_unittest.cc
          • M components/autofill/core/browser/integrators/autofill_ai/metrics/autofill_ai_logger_unittest.cc
          • M components/autofill/core/browser/metrics/payments/bnpl_metrics_unittest.cc
          • M components/autofill/core/browser/metrics/payments/card_metadata_metrics_unittest.cc
          • M components/autofill/core/browser/payments/amount_extraction_manager_unittest.cc
          • M components/autofill/core/browser/payments/credit_card_save_manager.cc
          • M components/autofill/core/browser/payments/payments_service_url.cc
          • M components/autofill/core/browser/suggestions/payments/credit_card_suggestion_generator.cc
          • M components/autofill/core/browser/webdata/autofill_ai/entity_sync_util_unittest.cc
          • M components/autofill/core/browser/webdata/payments/payments_sync_bridge_util_unittest.cc
          • M components/breadcrumbs/core/application_breadcrumbs_logger_unittest.cc
          • M components/cronet/android/test/test_server/embedded_test_server_adapter.cc
          • M components/data_sharing/public/data_sharing_sdk_delegate.h
          • M components/download/internal/common/download_item_impl_unittest.cc
          • M components/download/internal/common/download_stats.cc
          • M components/enterprise/browser/reporting/user_security_signals_service_unittest.cc
          • M components/enterprise/connectors/core/reporting_utils.cc
          • M components/facilitated_payments/core/browser/payment_link_manager_unittest.cc
          • M components/facilitated_payments/core/browser/pix_manager_unittest.cc
          • M components/facilitated_payments/core/metrics/facilitated_payments_metrics_unittest.cc
          • M components/omnibox/browser/zero_suggest_provider.cc
          • M components/optimization_guide/core/model_execution/on_device_context.cc
          • M components/optimization_guide/core/model_execution/on_device_execution.cc
          • M components/optimization_guide/core/model_execution/performance_class.cc
          • M components/optimization_guide/core/model_execution/session_impl.cc
          • M components/optimization_guide/core/optimization_guide_util.cc
          • M components/page_load_metrics/browser/observers/abandoned_page_load_metrics_observer.cc
          • M components/page_load_metrics/browser/observers/service_worker_page_load_metrics_observer.cc
          • M components/page_load_metrics/browser/observers/service_worker_page_load_metrics_observer_unittest.cc
          • M components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
          • M components/password_manager/core/browser/password_manager_metrics_util_unittest.cc
          • M components/password_manager/core/browser/password_manual_fallback_flow_unittest.cc
          • M components/password_manager/core/browser/ui/credential_ui_entry.cc
          • M components/password_manager/core/browser/ui/passwords_grouper.cc
          • M components/persistent_cache/persistent_cache_unittest.cc
          • M components/plus_addresses/core/browser/metrics/plus_address_submission_logger.cc
          • M components/plus_addresses/core/browser/metrics/plus_address_submission_logger_unittest.cc
          • M components/plus_addresses/core/browser/plus_address_http_client_impl_unittest.cc
          • M components/policy/core/common/cloud/cloud_policy_client.cc
          • M components/policy/test_support/request_handler_for_client_cert_provisioning_unittest.cc
          • M components/reporting/encryption/decryption.cc
          • M components/reporting/resources/resource_managed_buffer_unittest.cc
          • M components/reporting/util/file_unittest.cc
          • M components/safe_browsing/content/browser/browser_url_loader_throttle.cc
          • M components/safe_browsing/core/browser/web_ui/web_ui_info_singleton.cc
          • M components/services/storage/dom_storage/leveldb/session_storage_leveldb_unittest.cc
          • M components/signin/core/browser/about_signin_internals.cc
          • M components/signin/core/browser/account_investigator_unittest.cc
          • M components/signin/internal/identity_manager/oauth_multilogin_helper_unittest.cc
          • M components/storage_monitor/volume_mount_watcher_win.cc
          • M components/supervised_user/core/browser/supervised_user_utils.cc
          • M components/sync/service/sync_stopped_reporter_unittest.cc
          • M components/themes/ntp_background_service_unittest.cc
          • M components/trusted_vault/trusted_vault_connection_impl_unittest.cc
          • M components/user_education/common/ntp_promo/ntp_promo_controller_unittest.cc
          • M components/variations/seed_reader_writer_unittest.cc
          • M components/variations/service/google_groups_manager_unittest.cc
          • M components/visited_url_ranking/internal/transformer/recency_filter_transformer_unittest.cc
          • M components/visited_url_ranking/internal/url_grouping/group_suggestions_manager_unittest.cc
          • M components/webapps/isolated_web_apps/error/uma_logging.cc
          • M components/webapps/isolated_web_apps/reading/response_reader_unittest.cc
          • M components/webauthn/content/browser/internal_authenticator_impl_unittest.cc
          • M components/webdata/common/web_database_migration_unittest.cc
          • M content/browser/attribution_reporting/attribution_data_host_manager_impl_unittest.cc
          • M content/browser/attribution_reporting/attribution_manager_impl.cc
          • M content/browser/attribution_reporting/attribution_report_network_sender_unittest.cc
          • M content/browser/btm/btm_page_visit_observer_browsertest.cc
          • M content/browser/btm/btm_test_utils.cc
          • M content/browser/cache_storage/cache_storage_cache_unittest.cc
          • M content/browser/content_security_policy_browsertest.cc
          • M content/browser/cookie_insight_list/cookie_readiness_list/cookie_readiness_list_parser.cc
          • M content/browser/devtools/devtools_instrumentation.cc
          • M content/browser/devtools/protocol/network_handler.cc
          • M content/browser/devtools/protocol/storage_handler.cc
          • M content/browser/first_party_sets/test/first_party_sets_initialization_browsertest.cc
          • M content/browser/indexed_db/instance/connection.cc
          • M content/browser/indexed_db/instance/mock_blob_storage_context.cc
          • M content/browser/indexed_db/instance/transaction_unittest.cc
          • M content/browser/interest_group/ad_auction_headers_util_unittest.cc
          • M content/browser/interest_group/ad_auction_service_impl_unittest.cc
          • M content/browser/interest_group/interest_group_manager_impl_unittest.cc
          • M content/browser/loader/fetch_later_browsertest.cc
          • M content/browser/loader/loader_browsertest.cc
          • M content/browser/loader/send_beacon_browsertest.cc
          • M content/browser/navigation_transitions/back_forward_transition_animation_manager_android_browsertest.cc
          • M content/browser/network_sandbox.cc
          • M content/browser/preloading/prefetch/prefetch_container_unittest.cc
          • M content/browser/preloading/prefetch/prefetch_service_unittest.cc
          • M content/browser/preloading/prerender/prerender_browsertest.cc
          • M content/browser/preloading/prerenderer_impl_unittest.cc
          • M content/browser/renderer_host/clipboard_host_impl.cc
          • M content/browser/renderer_host/cookie_utils.cc
          • M content/browser/renderer_host/navigation_transitions/navigation_entry_screenshot_manager_unittest.cc
          • M content/browser/renderer_host/render_frame_host_manager.cc
          • M content/browser/service_host/utility_sandbox_delegate_unittest.cc
          • M content/browser/service_worker/service_worker_synthetic_response_manager.cc
          • M content/browser/shared_storage/shared_storage_url_loader_factory_proxy_unittest.cc
          • M content/browser/storage_partition_impl_unittest.cc
          • M content/browser/tracing/tracing_controller_impl.cc
          • M content/browser/web_contents/web_contents_impl.cc
          • M content/browser/web_contents/web_contents_impl_browsertest.cc
          • M content/browser/web_contents/web_contents_observer_browsertest.cc
          • M content/browser/webid/url_computations.cc
          • M content/browser/webui/web_ui_navigation_browsertest.cc
          • M content/browser/worker_host/worker_browsertest.cc
          • M content/public/test/test_download_http_response.cc
          • M content/renderer/renderer_navigation_metrics_manager.cc
          • M content/services/auction_worklet/bidder_worklet_unittest.cc
          • M content/services/auction_worklet/seller_worklet_unittest.cc
          • M content/services/auction_worklet/shared_storage_bindings.cc
          • M content/services/auction_worklet/trusted_signals.cc
          • M extensions/browser/api/messaging/message_service.cc
          • M extensions/browser/api/printer_provider/printer_provider_api.cc
          • M extensions/common/file_util.cc
          • M gin/object_template_builder.cc
          • M google_apis/gaia/oauth2_mint_access_token_fetcher_adapter_unittest.cc
          • M gpu/command_buffer/client/client_discardable_manager_unittest.cc
          • M gpu/command_buffer/client/mock_transfer_buffer.cc
          • M ios/chrome/browser/ai_prototyping/model/ai_prototyping_service_impl.mm
          • M ios/chrome/browser/ai_prototyping/model/tab_organization_service_impl.mm
          • M ios/chrome/browser/authentication/ui_bundled/separate_profiles_egtest.mm
          • M ios/chrome/browser/authentication/ui_bundled/separate_profiles_migration_egtest.mm
          • M ios/chrome/browser/autofill/model/credit_card/autofill_save_card_infobar_delegate_unittest.mm
          • M ios/chrome/browser/autofill/model/form_structure_browsertest.mm
          • M ios/chrome/browser/intelligence/enhanced_calendar/model/enhanced_calendar_service_impl.mm
          • M ios/chrome/browser/intelligence/persist_tab_context/model/persist_tab_context_browser_agent.mm
          • M ios/chrome/browser/intelligence/smart_tab_grouping/model/smart_tab_grouping_service_impl.mm
          • M ios/chrome/browser/overlays/ui_bundled/infobar_banner/save_card/save_card_infobar_banner_overlay_mediator_unittest.mm
          • M ios/chrome/browser/overlays/ui_bundled/infobar_modal/save_card/save_card_infobar_modal_overlay_mediator_unittest.mm
          • M ios/chrome/browser/passwords/ui_bundled/bottom_sheet/credential_suggestion_bottom_sheet_view_controller.mm
          • M ios/chrome/browser/passwords/ui_bundled/password_suggestion_coordinator.mm
          • M ios/chrome/browser/policy/model/reporting/browser_report_generator_ios_unittest.mm
          • M ios/chrome/browser/policy/model/reporting/report_generator_ios_unittest.mm
          • M ios/chrome/browser/policy/model/reporting/reporting_util.mm
          • M ios/chrome/browser/push_notification/model/push_notification_client.mm
          • M ios/chrome/browser/settings/model/sync/utils/sync_fake_server_egtest.mm
          • M ios/chrome/browser/supervised_user/model/supervised_user_incognito_mode_egtest.mm
          • M ios/chrome/browser/sync/model/prefs/sync_preferences_egtest.mm
          • M ios/chrome/browser/webui/ui_bundled/policy/policy_egtest.mm
          • M ios/chrome/test/variations_smoke_test/variations_smoke_egtest.mm
          • M media/audio/android/audio_android_unittest.cc
          • M media/base/stream_parser_unittest.cc
          • M media/capture/video/chromeos/camera_device_delegate.cc
          • M media/gpu/android/ndk_video_encode_accelerator.cc
          • M media/mojo/services/mojo_video_encoder_metrics_provider_service_unittest.cc
          • M mojo/public/cpp/platform/named_platform_channel_win.cc
          • M net/disk_cache/sql/sql_backend_impl_unittest.cc
          • M net/dns/host_resolver_dns_task.cc
          • M net/dns/host_resolver_manager_job.cc
          • M net/dns/mdns_client_unittest.cc
          • M net/http/http_network_transaction.cc
          • M net/http/http_proxy_connect_job.cc
          • M net/http/http_stream_factory_job.cc
          • M net/http/http_stream_pool_attempt_manager.cc
          • M net/http/http_stream_pool_job.cc
          • M net/nqe/network_quality_estimator.cc
          • M net/quic/quic_chromium_client_session.cc
          • M net/quic/quic_proxy_datagram_client_socket.cc
          • M net/quic/quic_proxy_datagram_client_socket_unittest.cc
          • M net/quic/quic_session_pool.cc
          • M net/spdy/spdy_proxy_client_socket_unittest.cc
          • M net/test/embedded_test_server/websocket_close_observer_handler.cc
          • M net/url_request/url_request_http_job.cc
          • M net/url_request/url_request_quic_unittest.cc
          • M pdf/pdf_view_web_plugin_unittest.cc
          • M remoting/host/chromoting_host_services_server.cc
          • M remoting/host/linux/gnome_capture_stream_manager.cc
          • M remoting/host/linux/portal_capture_stream_manager.cc
          • M remoting/host/linux/portal_remote_desktop_session.cc
          • M remoting/host/usage_stats_consent_win.cc
          • M sandbox/win/src/process_mitigations_dyncode_unittest.cc
          • M services/audio/stream_factory.cc
          • M services/network/devtools_durable_msg_collector_unittest.cc
          • M services/network/url_loader_util.cc
          • M services/webnn/tflite/graph_impl_tflite.cc
          • M third_party/blink/renderer/core/frame/local_frame.cc
          • M third_party/blink/renderer/core/frame/use_counter_impl.cc
          • M third_party/blink/renderer/core/loader/frame_loader.cc
          • M third_party/blink/renderer/core/timing/window_performance.cc
          • M third_party/blink/renderer/modules/ai/rewriter.cc
          • M third_party/blink/renderer/modules/ai/summarizer.cc
          • M third_party/blink/renderer/modules/ai/writer.cc
          • M third_party/blink/renderer/modules/webaudio/audio_context.cc
          • M third_party/blink/renderer/modules/webcodecs/codec_logger.cc
          • M ui/base/metadata/base_type_conversion.cc
          • M ui/views/accessibility/ax_virtual_view.cc
          Change size: L
          Delta: 466 files changed, 476 insertions(+), 1 deletion(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Lei Zhang
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I490cd1630d813dd6f07e57fe31f7677076597884
          Gerrit-Change-Number: 7228863
          Gerrit-PatchSet: 22
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages