[webgl] Report per-renderer WebGL memory size to UMA [chromium/src : main]

5 views
Skip to first unread message

Benoit Lize (Gerrit)

unread,
May 21, 2026, 11:26:09 AMMay 21
to Colin Blundell, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Colin Blundell and Joe Mason

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Joe Mason
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I22926dfc4906e95e5218418775ab786a79a7c7cf
Gerrit-Change-Number: 7865288
Gerrit-PatchSet: 1
Gerrit-Owner: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Thu, 21 May 2026 15:25:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
May 21, 2026, 12:42:34 PMMay 21
to Benoit Lize, Colin Blundell, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Benoit Lize and Joe Mason

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Benoit Lize
  • Joe Mason
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I22926dfc4906e95e5218418775ab786a79a7c7cf
    Gerrit-Change-Number: 7865288
    Gerrit-PatchSet: 1
    Gerrit-Owner: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Benoit Lize <li...@chromium.org>
    Gerrit-Attention: Joe Mason <joenot...@google.com>
    Gerrit-Comment-Date: Thu, 21 May 2026 16:42:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joe Mason (Gerrit)

    unread,
    May 21, 2026, 7:36:07 PMMay 21
    to Benoit Lize, Colin Blundell, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
    Attention needed from Benoit Lize

    Joe Mason voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Benoit Lize
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I22926dfc4906e95e5218418775ab786a79a7c7cf
    Gerrit-Change-Number: 7865288
    Gerrit-PatchSet: 1
    Gerrit-Owner: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Benoit Lize <li...@chromium.org>
    Gerrit-Comment-Date: Thu, 21 May 2026 23:36:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Benoit Lize (Gerrit)

    unread,
    May 22, 2026, 4:53:15 AMMay 22
    to Eric Seckler, Colin Blundell, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
    Attention needed from Eric Seckler

    Benoit Lize added 1 comment

    Patchset-level comments
    Benoit Lize . resolved

    +esecklet for base/trace_event. PTAL, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eric Seckler
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I22926dfc4906e95e5218418775ab786a79a7c7cf
    Gerrit-Change-Number: 7865288
    Gerrit-PatchSet: 1
    Gerrit-Owner: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Eric Seckler <esec...@chromium.org>
    Gerrit-Comment-Date: Fri, 22 May 2026 08:52:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Eric Seckler (Gerrit)

    unread,
    May 22, 2026, 5:10:14 AMMay 22
    to Benoit Lize, Colin Blundell, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
    Attention needed from Benoit Lize

    Eric Seckler voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Benoit Lize
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I22926dfc4906e95e5218418775ab786a79a7c7cf
    Gerrit-Change-Number: 7865288
    Gerrit-PatchSet: 1
    Gerrit-Owner: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Benoit Lize <li...@chromium.org>
    Gerrit-Comment-Date: Fri, 22 May 2026 09:09:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Benoit Lize (Gerrit)

    unread,
    May 22, 2026, 8:39:16 AMMay 22
    to Eric Seckler, Colin Blundell, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Benoit Lize voted and added 1 comment

    Votes added by Benoit Lize

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Benoit Lize . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I22926dfc4906e95e5218418775ab786a79a7c7cf
    Gerrit-Change-Number: 7865288
    Gerrit-PatchSet: 1
    Gerrit-Owner: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Fri, 22 May 2026 12:38:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 22, 2026, 9:16:46 AMMay 22
    to Benoit Lize, Eric Seckler, Colin Blundell, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [webgl] Report per-renderer WebGL memory size to UMA

    To assess upcoming field experiments aimed at reducing WebGL memory
    usage, add a metric to report it to UMA.
    Bug: 514593915
    Change-Id: I22926dfc4906e95e5218418775ab786a79a7c7cf
    Reviewed-by: Joe Mason <joenot...@google.com>
    Reviewed-by: Eric Seckler <esec...@chromium.org>
    Commit-Queue: Benoit Lize <li...@chromium.org>
    Reviewed-by: Colin Blundell <blun...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1634877}
    Files:
    • M base/trace_event/memory_infra_background_allowlist.cc
    • M chrome/browser/metrics/process_memory_metrics_emitter.cc
    • M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
    • M tools/metrics/histograms/metadata/memory/histograms.xml
    Change size: S
    Delta: 4 files changed, 33 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Eric Seckler, +1 by Joe Mason, +1 by Colin Blundell
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I22926dfc4906e95e5218418775ab786a79a7c7cf
    Gerrit-Change-Number: 7865288
    Gerrit-PatchSet: 2
    Gerrit-Owner: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages