Add trace events for CrxDownloader and Unpacker. [chromium/src : main]

0 views
Skip to first unread message

Steven Holte (Gerrit)

unread,
Feb 9, 2026, 3:32:59 PMFeb 9
to Steven Holte, Joshua Pawlicki, Jingyun Liu, AyeAye, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org
Attention needed from Joshua Pawlicki

Steven Holte voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joshua Pawlicki
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I37a63d961d0da088df70cc9815c6bf9c9ee36e47
Gerrit-Change-Number: 7560372
Gerrit-PatchSet: 1
Gerrit-Owner: Steven Holte <ho...@chromium.org>
Gerrit-Reviewer: Joshua Pawlicki <waf...@chromium.org>
Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
Gerrit-CC: Jingyun Liu <jin...@google.com>
Gerrit-Attention: Joshua Pawlicki <waf...@chromium.org>
Gerrit-Comment-Date: Mon, 09 Feb 2026 20:32:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sorin Jianu (Gerrit)

unread,
Feb 9, 2026, 4:15:37 PMFeb 9
to Steven Holte, Chromium LUCI CQ, Joshua Pawlicki, Jingyun Liu, AyeAye, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org
Attention needed from Joshua Pawlicki and Steven Holte

Sorin Jianu voted and added 1 comment

Votes added by Sorin Jianu

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sorin Jianu . resolved

lgtm ty!

Open in Gerrit

Related details

Attention is currently required from:
  • Joshua Pawlicki
  • Steven Holte
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I37a63d961d0da088df70cc9815c6bf9c9ee36e47
    Gerrit-Change-Number: 7560372
    Gerrit-PatchSet: 1
    Gerrit-Owner: Steven Holte <ho...@chromium.org>
    Gerrit-Reviewer: Joshua Pawlicki <waf...@chromium.org>
    Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    Gerrit-CC: Jingyun Liu <jin...@google.com>
    Gerrit-Attention: Steven Holte <ho...@chromium.org>
    Gerrit-Attention: Joshua Pawlicki <waf...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Feb 2026 21:15:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Steven Holte (Gerrit)

    unread,
    Feb 9, 2026, 4:24:19 PMFeb 9
    to Steven Holte, Etienne Pierre-Doray, Sorin Jianu, Chromium LUCI CQ, Joshua Pawlicki, Jingyun Liu, AyeAye, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org
    Attention needed from Etienne Pierre-Doray and Joshua Pawlicki

    Steven Holte voted

    Auto-Submit+1
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    • Joshua Pawlicki
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I37a63d961d0da088df70cc9815c6bf9c9ee36e47
    Gerrit-Change-Number: 7560372
    Gerrit-PatchSet: 2
    Gerrit-Owner: Steven Holte <ho...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joshua Pawlicki <waf...@chromium.org>
    Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    Gerrit-CC: Jingyun Liu <jin...@google.com>
    Gerrit-Attention: Joshua Pawlicki <waf...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Feb 2026 21:24:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joshua Pawlicki (Gerrit)

    unread,
    Feb 9, 2026, 4:55:42 PMFeb 9
    to Steven Holte, Etienne Pierre-Doray, Sorin Jianu, Chromium LUCI CQ, Jingyun Liu, AyeAye, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org
    Attention needed from Etienne Pierre-Doray and Steven Holte

    Joshua Pawlicki voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    • Steven Holte
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I37a63d961d0da088df70cc9815c6bf9c9ee36e47
    Gerrit-Change-Number: 7560372
    Gerrit-PatchSet: 2
    Gerrit-Owner: Steven Holte <ho...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joshua Pawlicki <waf...@chromium.org>
    Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    Gerrit-CC: Jingyun Liu <jin...@google.com>
    Gerrit-Attention: Steven Holte <ho...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Feb 2026 21:55:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Feb 10, 2026, 2:42:56 PMFeb 10
    to Steven Holte, Joshua Pawlicki, Sorin Jianu, Chromium LUCI CQ, Jingyun Liu, AyeAye, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org
    Attention needed from Steven Holte

    Etienne Pierre-Doray voted and added 1 comment

    Votes added by Etienne Pierre-Doray

    Code-Review+1
    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Etienne Pierre-Doray . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Steven Holte
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I37a63d961d0da088df70cc9815c6bf9c9ee36e47
    Gerrit-Change-Number: 7560372
    Gerrit-PatchSet: 2
    Gerrit-Owner: Steven Holte <ho...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joshua Pawlicki <waf...@chromium.org>
    Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    Gerrit-CC: Jingyun Liu <jin...@google.com>
    Gerrit-Attention: Steven Holte <ho...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 19:42:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 10, 2026, 2:46:31 PMFeb 10
    to Steven Holte, Etienne Pierre-Doray, Joshua Pawlicki, Sorin Jianu, Jingyun Liu, AyeAye, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add trace events for CrxDownloader and Unpacker.
    Change-Id: I37a63d961d0da088df70cc9815c6bf9c9ee36e47
    Reviewed-by: Joshua Pawlicki <waf...@chromium.org>
    Auto-Submit: Steven Holte <ho...@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
    Reviewed-by: Sorin Jianu <so...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1582700}
    Files:
    • M base/trace_event/builtin_categories.h
    • M components/update_client/crx_downloader.cc
    • M components/update_client/unpacker.cc
    Change size: S
    Delta: 3 files changed, 30 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Sorin Jianu, +1 by Etienne Pierre-Doray, +1 by Joshua Pawlicki
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I37a63d961d0da088df70cc9815c6bf9c9ee36e47
    Gerrit-Change-Number: 7560372
    Gerrit-PatchSet: 3
    Gerrit-Owner: Steven Holte <ho...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joshua Pawlicki <waf...@chromium.org>
    Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    Gerrit-CC: Jingyun Liu <jin...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages