[M151] Disable WebUI omnibox Features in failing tests. [chromium/src : refs/branch-heads/7922]
1 view
Skip to first unread message
Justin Donnelly (Gerrit)
Aug 3, 2026, 1:43:48 PM (3 days ago) Aug 3
to Justin Donnelly, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, tracing...@chromium.org, spang...@chromium.org, wfh+...@chromium.org
Justin Donnelly added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Justin Donnelly . resolved
Hi Riley, can you review this merge? There was a trivial(ish) merge conflict in contextual_tasks_pixel_interactive_ui_test.cc.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Riley Tatum (Gerrit)
Aug 4, 2026, 12:17:59 PM (2 days ago) Aug 4
to Justin Donnelly, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, tracing...@chromium.org, spang...@chromium.org, wfh+...@chromium.org
Attention needed from Justin Donnelly
Riley Tatum voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Justin Donnelly
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Krishna Govind (Gerrit)
Aug 5, 2026, 1:59:47 PM (14 hours ago) Aug 5
to Justin Donnelly, Riley Tatum, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, tracing...@chromium.org, spang...@chromium.org, wfh+...@chromium.org
Attention needed from Justin Donnelly
Krishna Govind voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Justin Donnelly
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Donnelly (Gerrit)
Aug 5, 2026, 2:01:11 PM (14 hours ago) Aug 5
to Justin Donnelly, Krishna Govind, Riley Tatum, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, tracing...@chromium.org, spang...@chromium.org, wfh+...@chromium.org
Justin Donnelly voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 5, 2026, 2:05:55 PM (14 hours ago) Aug 5
to Justin Donnelly, Krishna Govind, Riley Tatum, android-bu...@system.gserviceaccount.com, tracing...@chromium.org, spang...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[M151] Disable WebUI omnibox Features in failing tests.
I seem to have missed these when disabling the Features in all the tests
in https://crrev.com/c/8168560.
(cherry picked from commit 9317189fce08ba3485b0a7b56ab1bed68307b6b3)
Bug: b:452061489, 542160702
Change-Id: If19bfcf98c0032decf6b000851241bd05b72ddd2
Reviewed-by: Tibor Goldschwendt <tib...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Justin Donnelly <jdon...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1670658}
Reviewed-by: Riley Tatum <rta...@google.com>
Owners-Override: Krishna Govind <gov...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7922@{#2600}
Cr-Branched-From: 059c884787b1bc15faa5afe5250f7d3a7e0ef64a-refs/heads/main@{#1654411}
Files:
- M chrome/browser/default_browser/default_browser_manager_browsertest.cc
- M chrome/test/data/webui/contextual_tasks/contextual_tasks_pixel_interactive_ui_test.cc
- M content/browser/tracing/startup_tracing_browsertest.cc
Change size: S
Delta: 3 files changed, 19 insertions(+), 3 deletions(-)
Branch: refs/branch-heads/7922
Submit Requirements:
Code-Review: +1 by Riley Tatum
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages