Convert `PageState` into a regular Mojo struct [chromium/src : main]

[Daniel Cheng (Gerrit)]

Daniel Cheng added 1 comment

File content/common/navigation_client.mojom

Line 52, Patchset 3: // If support for older `PageState` serializations (version < 26), it should

Will Harris . resolved

curious how old is version 25? because we do have a (reasonable) limit on supporting old profiles and if this is really really old (5 years?) then maybe we don't need to support it.

maybe a metric somewhere to measure usage of this would be nice?

Daniel Cheng

It is quite old. I'm not sure if we have metrics. It would be nice to fix, but I don't plan on doing it :)

I filed a bug and added the TODO here. Though based on the responses on the bug, it sounds like we probably won't be deleting the old versions any time soon :)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I31c932fa88adefaa3e1bfd520184055fe41fb050

Gerrit-Change-Number: 7534122

Gerrit-PatchSet: 4

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Peter Williamson <pet...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Feb 2026 03:24:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Will Harris <w...@chromium.org>

[Daniel Cheng (Gerrit)]

Daniel Cheng voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I31c932fa88adefaa3e1bfd520184055fe41fb050

Gerrit-Change-Number: 7534122

Gerrit-PatchSet: 7

Gerrit-Comment-Date: Tue, 03 Feb 2026 18:29:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: content/common/navigation_client.mojom
Insertions: 4, Deletions: 2.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

Convert `PageState` into a regular Mojo struct

This removes the legacy ParamTraits for `PageState` and replaces it with
the Mojo `StructTraits` equivalent. This CL maintains pre-existing
behaviour; notably, this means that `PageState` is still sent over IPC
as an opaque binary string, even though this is contrary to the standard
guidance for IPC.

Bug: 393179188

Change-Id: I31c932fa88adefaa3e1bfd520184055fe41fb050

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7534122

Reviewed-by: Will Harris <w...@chromium.org>

Reviewed-by: Rakina Zata Amni <rak...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1578914}

Files:

• M content/common/BUILD.gn
• M content/common/navigation_client.mojom
• A content/common/page_state_mojom_traits.h
• M mojo/public/tools/bindings/checks/mojom_attributes_check.py

Change size: M

Delta: 4 files changed, 64 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Rakina Zata Amni, +1 by Will Harris

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I31c932fa88adefaa3e1bfd520184055fe41fb050

Gerrit-Change-Number: 7534122

Gerrit-PatchSet: 8

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>