partition_alloc: merge buildflags.h [chromium/src : main]

0 views
Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,
Jun 19, 2024, 9:46:09 AM (12 days ago) Jun 19
to Keishi Hattori, danakj, Tricium, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Zijie He, alexmo...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, chromiumme...@microsoft.com, kinuko...@chromium.org, creis...@chromium.org, ios-r...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, net-r...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, grt+...@chromium.org, ios-revie...@chromium.org, bartek...@chromium.org, blundell+...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, glazuno...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Keishi Hattori and danakj

Arthur Sonzogni added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Arthur Sonzogni . resolved

Hi Keishi,
What do you think about this change?

The manual changes are in:

  • `base/allocator/partition_allocator/src/partition_alloc/BUILD.gn`
  • `base/allocator/partition_allocator/src/partition_alloc/partition_alloc_buildflags.h`


+Dana: If Keishi approve this patch, I would need your +1 to update the includes everywhere.

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
  • danakj
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56a30e5bb453c19a8d262f7a19b3d76ecae23a26
Gerrit-Change-Number: 5630428
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: danakj <dan...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Jun 2024 13:45:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages