PA: Remove `ThreadCache.*` histograms [chromium/src : main]
0 views
Skip to first unread message
Kalvin Lee (Gerrit)
Jun 17, 2024, 3:38:50 AMJun 17
to Benoit Lize, Tricium, Chromium Metrics Reviews, chromium...@chromium.org, Chromium LUCI CQ, asvitkine...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Benoit Lize
Kalvin Lee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kalvin Lee . resolved
Benoit, over to you - hopefully nobody actually cares about these histograms?
Related details
Attention is currently required from:
- Benoit Lize
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benoit Lize (Gerrit)
Jun 20, 2024, 4:41:37 AM (11 days ago) Jun 20
to Kalvin Lee, Code Review Nudger, Tricium, Chromium Metrics Reviews, chromium...@chromium.org, Chromium LUCI CQ, asvitkine...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Kalvin Lee
Benoit Lize voted and added 1 comment![]( "Open in Gerrit")
Votes added by Benoit Lize
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Kalvin Lee
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kalvin Lee (Gerrit)
Jun 20, 2024, 4:52:26 AM (11 days ago) Jun 20
to Nico Weber, Benoit Lize, Code Review Nudger, Tricium, Chromium Metrics Reviews, chromium...@chromium.org, Chromium LUCI CQ, asvitkine...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Nico Weber
Kalvin Lee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kalvin Lee . resolved
Roll d4 on intersection of Gerrit owners on remaining files (dropping everybody marked OOO) -> 3 -> Nico to review, please.
Related details
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Jun 20, 2024, 6:31:30 AM (11 days ago) Jun 20
to Kalvin Lee, Nico Weber, Benoit Lize, Code Review Nudger, Tricium, Chromium Metrics Reviews, chromium...@chromium.org, Chromium LUCI CQ, asvitkine...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Kalvin Lee
Nico Weber voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kalvin Lee
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kalvin Lee (Gerrit)
Jun 20, 2024, 6:34:46 AM (11 days ago) Jun 20
to Nico Weber, Benoit Lize, Code Review Nudger, Tricium, Chromium Metrics Reviews, chromium...@chromium.org, Chromium LUCI CQ, asvitkine...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Kalvin Lee voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 20, 2024, 7:59:40 AM (11 days ago) Jun 20
to Kalvin Lee, Nico Weber, Benoit Lize, Code Review Nudger, Tricium, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
PA: Remove `ThreadCache.*` histograms
These histograms have been outdated for years and are no longer
collected in UMA. They were originally implemented to investigate PA-E
performance [1][2]. This CL
* removes the histogram definitions,
* removes the UMA emission code, and
* removes an old Blink test for the same.
[1] https://crbug.com/40642257
[2] https://crrev.com/c/2549968
Bug: 336308069
Change-Id: I4c9f0b57e98a2f2ad38f293634f2d44530f003de
Reviewed-by: Benoit Lize <li...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Commit-Queue: Kalvin Lee <kd...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1317295}
Files:
- M base/trace_event/malloc_dump_provider.cc
- M third_party/blink/renderer/platform/instrumentation/BUILD.gn
- D third_party/blink/renderer/platform/instrumentation/partition_alloc_memory_dump_provider_test.cc
- M tools/metrics/histograms/metadata/memory/histograms.xml
Change size: M
Delta: 4 files changed, 14 insertions(+), 114 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nico Weber, +1 by Benoit Lize
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages