| Commit-Queue | +1 |
Andrew, this should cover everything directly touched by //components/ip_protection but excludes the feature definitions and histograms. I'll tackle those in a later CL after doing the proxy chain refactoring.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
LGTM 😢
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: joenot...@google.com
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): joenot...@google.com
Reviewer source(s):
joenot...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Code-Review | +1 |
traffic_annotation/ LGTM
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
Thanks all for the reviews!
[IPP] Delete components/ip_protection
Additionally, delete the random bits of tracing, traffic annotations and
unused BUILD rules/visibility that are no longer needed.
//components/ip_protection/OWNERS is left untouched so that the
histograms and other OTHERS that reference it can be cleaned up in a
later CL.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |