[gtest][base] Clean up single-argument `testing::Invoke()`s [chromium/src : main]
0 views
Skip to first unread message
Jonathan Lee (Gerrit)
Aug 20, 2025, 1:13:03 PMAug 20
to Francois Pierre Doray, AyeAye, chromium...@chromium.org, Sadrul Chowdhury, Chromium LUCI CQ, mac-r...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Francois Pierre Doray
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Aug 22, 2025, 7:15:04 AMAug 22
to Jonathan Lee, AyeAye, chromium...@chromium.org, Sadrul Chowdhury, Chromium LUCI CQ, mac-r...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jonathan Lee
Francois Pierre Doray voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jonathan Lee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Lee (Gerrit)
Aug 22, 2025, 11:59:35 AMAug 22
to Francois Pierre Doray, AyeAye, chromium...@chromium.org, Sadrul Chowdhury, Chromium LUCI CQ, mac-r...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Jonathan Lee voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 22, 2025, 12:24:43 PMAug 22
to Jonathan Lee, Francois Pierre Doray, AyeAye, chromium...@chromium.org, Sadrul Chowdhury, mac-r...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[gtest][base] Clean up single-argument `testing::Invoke()`s
Not needed and deprecated [0]. This CL should be a no-op.
[0]: https://chromium.googlesource.com/external/github.com/google/googletest.git/+/a05c0915074bcd1b82f232e081da9bb6c205c28d/googlemock/include/gmock/gmock-actions.h#2046
Bug: 439838457
Change-Id: Ie1296e2ac057916b73dcdbbeccd61a074fa7227d
Commit-Queue: Jonathan Lee <jonath...@google.com>
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1505115}
Files:
- M base/files/file_descriptor_watcher_posix_unittest.cc
- M base/message_loop/message_pump_unittest.cc
- M base/power_monitor/thermal_state_observer_mac_unittest.mm
- M base/task/sequence_manager/sequence_manager_impl_unittest.cc
- M base/task/sequence_manager/test/mock_time_message_pump_unittest.cc
- M base/task/sequence_manager/thread_controller_with_message_pump_impl_unittest.cc
- M base/test/launcher/test_launcher_unittest.cc
- M base/trace_event/memory_dump_manager_unittest.cc
- M base/trace_event/memory_dump_scheduler_unittest.cc
Change size: L
Delta: 9 files changed, 181 insertions(+), 207 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Francois Pierre Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages