[content] Optimize stringstream usage [chromium/src : main]

3 views
Skip to first unread message

Andrew Paseltiner (Gerrit)

unread,
Apr 10, 2026, 12:08:35 PMApr 10
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, abigailbk...@google.com, alexmo...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavin...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Daniel Cheng

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I49d057563cab1841bb7e4fb2c1e12e0c22b4d03e
Gerrit-Change-Number: 7747348
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Apr 2026 16:08:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
May 8, 2026, 3:35:21 PMMay 8
to Andrew Paseltiner, Daniel Cheng, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, abigailbk...@google.com, alexmo...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavin...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Andrew Paseltiner

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Daniel Cheng . resolved

Personal opinion: we shouldn't use streams as much as we do. But meh :)

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Paseltiner
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I49d057563cab1841bb7e4fb2c1e12e0c22b4d03e
    Gerrit-Change-Number: 7747348
    Gerrit-PatchSet: 3
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Comment-Date: Fri, 08 May 2026 19:35:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jordan Bayles (Gerrit)

    unread,
    May 8, 2026, 3:57:27 PMMay 8
    to Andrew Paseltiner, Daniel Cheng, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, abigailbk...@google.com, alexmo...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavin...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Andrew Paseltiner

    Jordan Bayles added 1 comment

    Patchset-level comments
    Daniel Cheng . resolved

    Personal opinion: we shouldn't use streams as much as we do. But meh :)

    Jordan Bayles

    My question is when is base gonna switch to std::format??

    https://en.cppreference.com/cpp/utility/format/format

    Gerrit-CC: Jordan Bayles <jop...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Comment-Date: Fri, 08 May 2026 19:57:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Paseltiner (Gerrit)

    unread,
    Jun 15, 2026, 12:49:03 PMJun 15
    to Jordan Bayles, Daniel Cheng, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, abigailbk...@google.com, alexmo...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavin...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

    Andrew Paseltiner abandoned this change.

    View Change

    Abandoned

    Andrew Paseltiner abandoned this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: abandon
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages